Skip to content

Commit 920959f

Browse files
lucian-tosafealebenpae
authored andcommitted
Fix SSLDC markdowns indentation (#4106)
# Summary The markdown files generated in an SSDLC report had incorrect indentation. Because of an extra `\t` the links to the SBOMs did not work. ## Proof of Work Before ![image](https://github.com/user-attachments/assets/cda913af-aa5f-40ff-a162-08c922d10506) After ![image](https://github.com/user-attachments/assets/efc492ab-b66e-4b64-aa77-3820ceff8ef7) ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes? ## Reminder (Please remove this when merging) - Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible - Our Short Guide for PRs: [Link](REDACTED) - Remember the following Communication Standards - use comment prefixes for clarity: * **blocking**: Must be addressed before approval. * **follow-up**: Can be addressed in a later PR or ticket. * **q**: Clarifying question. * **nit**: Non-blocking suggestions. * **note**: Side-note, non-actionable. Example: Praise * --> no prefix is considered a question
1 parent 55a8569 commit 920959f

4 files changed

+17
-19
lines changed

generate_ssdlc_report.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,11 +204,9 @@ def prepare_sbom_markdown(supported_images: Dict[str, SupportedImage], subreport
204204
for supported_image_key in supported_images:
205205
supported_image = supported_images[supported_image_key]
206206
if supported_image.subreport == subreport:
207-
lines = f"{lines}\n\t\t- {supported_image.ssdlc_report_name}:"
207+
lines = f"{lines}\n\t- {supported_image.ssdlc_report_name}:"
208208
for sbom_location in supported_image.sbom_file_names:
209-
lines = (
210-
f"{lines}\n\t\t\t- [{sbom_location}](./{supported_image.subreport.sbom_subpath}/{sbom_location})"
211-
)
209+
lines = f"{lines}\n\t\t- [{sbom_location}](./{supported_image.subreport.sbom_subpath}/{sbom_location})"
212210
return lines
213211

214212

scripts/ssdlc/templates/SSDLC Containerized MongoDB Agent ${VERSION}.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,4 @@ Assumptions and attestations:
4242

4343
2. The Dependency document does not specify third party OSS CVEs fixed by the release and the date we discovered them.
4444

45-
3. There is no CycloneDX field for original/modified CVSS score or discovery date. The `x-` prefix indicates this.
45+
3. There is no CycloneDX field for original/modified CVSS score or discovery date. The `x-` prefix indicates this.

scripts/ssdlc/templates/SSDLC Containerized MongoDB Enterprise Kubernetes Operator ${VERSION}.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,4 @@ Assumptions and attestations:
4242

4343
2. The Dependency document does not specify third party OSS CVEs fixed by the release and the date we discovered them.
4444

45-
3. There is no CycloneDX field for original/modified CVSS score or discovery date. The `x-` prefix indicates this.
45+
3. There is no CycloneDX field for original/modified CVSS score or discovery date. The `x-` prefix indicates this.

scripts/ssdlc/templates/SSDLC Containerized MongoDB Enterprise OpsManager ${VERSION}.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,38 +8,38 @@ Overview:
88

99
- **Product and Release Name**
1010

11-
- MongoDB Enterprise Operator ${VERSION}, ${DATE}.
12-
- Release Type: ${RELEASE_TYPE}
11+
- MongoDB Enterprise Operator ${VERSION}, ${DATE}.
12+
- Release Type: ${RELEASE_TYPE}
1313

1414
- **Process Document**
15-
- http://go/how-we-develop-software-doc
15+
- http://go/how-we-develop-software-doc
1616

1717
- **Tool used to track third party vulnerabilities**
18-
- Snyk
18+
- Snyk
1919

2020
- **Dependency Information**
21-
- See SBOMS Lite manifests (CycloneDX in JSON format for the SBOM and JSON for the supplementary report on CVEs):
21+
- See SBOMS Lite manifests (CycloneDX in JSON format for the SBOM and JSON for the supplementary report on CVEs):
2222
${SBOMS}
2323

2424
- **Static Analysis Report**
25-
- We use GoSec for static analysis scanning on our CI tests. There are no findings (neither critical nor high) unresolved.
25+
- We use GoSec for static analysis scanning on our CI tests. There are no findings (neither critical nor high) unresolved.
2626

2727
- **Release Signature Report**
28-
- Image signatures enforced by CI pipeline.
29-
- Signatures verification: documentation in-progress: https://jira.mongodb.org/browse/DOCSP-39646
28+
- Image signatures enforced by CI pipeline.
29+
- Signatures verification: documentation in-progress: https://jira.mongodb.org/browse/DOCSP-39646
3030

3131
- **Security Testing Report**
32-
- Sast: https://jira.mongodb.org/browse/CLOUDP-251553
33-
- Pentest: (Same as the others) https://jira.mongodb.org/browse/CLOUDP-251555
34-
- Dast: We decided not to do per https://jira.mongodb.org/browse/CLOUDP-251554 and the linked scope
32+
- Sast: https://jira.mongodb.org/browse/CLOUDP-251553
33+
- Pentest: (Same as the others) https://jira.mongodb.org/browse/CLOUDP-251555
34+
- Dast: We decided not to do per https://jira.mongodb.org/browse/CLOUDP-251554 and the linked scope
3535

3636
- **Security Assessment Report**
37-
- https://jira.mongodb.org/browse/CLOUDP-251555
37+
- https://jira.mongodb.org/browse/CLOUDP-251555
3838

3939
Assumptions and attestations:
4040

4141
1. Internal processes are used to ensure CVEs are identified and mitigated within SLAs.
4242

4343
2. The Dependency document does not specify third party OSS CVEs fixed by the release and the date we discovered them.
4444

45-
3. There is no CycloneDX field for original/modified CVSS score or discovery date. The `x-` prefix indicates this.
45+
3. There is no CycloneDX field for original/modified CVSS score or discovery date. The `x-` prefix indicates this.

0 commit comments

Comments
 (0)