Move all env vars to constants.py

Author: MaciejKaras

docker/mongodb-community-tests/Dockerfile

@@ -6,9 +6,7 @@
 #
 # Ref: https://cryptography.io/en/latest/installation/#building-cryptography-on-linux
 #
-ARG GOLANG_VERSION
-
-FROM public.ecr.aws/docker/library/golang:${GOLANG_VERSION} as builder
+FROM public.ecr.aws/docker/library/golang:1.24 as builder
 
 ENV GO111MODULE=on
 ENV GOPATH ""

scripts/release/atomic_pipeline.py

@@ -122,25 +122,19 @@ def build_mco_tests_image(build_configuration: ImageBuildConfiguration):
     """
     Builds image used to run community tests.
     """
-    golang_version = os.getenv("GOLANG_VERSION", "1.24")
-    if golang_version == "":
-        raise Exception("Missing GOLANG_VERSION environment variable")
-
-    buildargs = dict({"GOLANG_VERSION": golang_version})
 
     pipeline_process_image(
         dockerfile_path="docker/mongodb-community-tests/Dockerfile",
         build_configuration=build_configuration,
-        dockerfile_args=buildargs,
     )
 
 
 def build_operator_image(build_configuration: ImageBuildConfiguration):
     """Calculates arguments required to build the operator image, and starts the build process."""
     # In evergreen, we can pass test_suffix env to publish the operator to a quay
     # repository with a given suffix.
-    test_suffix = os.environ.get("test_suffix", "")
-    log_automation_config_diff = os.environ.get("LOG_AUTOMATION_CONFIG_DIFF", "false")
+    test_suffix = os.getenv("test_suffix", "")
+    log_automation_config_diff = os.getenv("LOG_AUTOMATION_CONFIG_DIFF", "false")
 
     args = {
         "version": build_configuration.version,
@@ -283,17 +277,9 @@ def build_readiness_probe_image(build_configuration: ImageBuildConfiguration):
     Builds image used for readiness probe.
     """
 
-    golang_version = os.getenv("GOLANG_VERSION", "1.24")
-
-    extra_args = {
-        "version": build_configuration.version,
-        "GOLANG_VERSION": golang_version,
-    }
-
     pipeline_process_image(
         dockerfile_path="docker/mongodb-kubernetes-readinessprobe/Dockerfile",
         build_configuration=build_configuration,
-        dockerfile_args=extra_args,
     )
 
 
@@ -302,17 +288,9 @@ def build_upgrade_hook_image(build_configuration: ImageBuildConfiguration):
     Builds image used for version upgrade post-start hook.
     """
 
-    golang_version = os.getenv("GOLANG_VERSION", "1.24")
-
-    extra_args = {
-        "version": build_configuration.version,
-        "GOLANG_VERSION": golang_version,
-    }
-
     pipeline_process_image(
         dockerfile_path="docker/mongodb-kubernetes-upgrade-hook/Dockerfile",
         build_configuration=build_configuration,
-        dockerfile_args=extra_args,
     )
 
 

scripts/release/build/build_scenario.py

@@ -5,6 +5,7 @@
 from git import Repo
 
 from scripts.release.version import calculate_next_version
+from scripts.release.constants import triggered_by_git_tag, is_evg_patch, is_running_in_evg, get_version_id
 
 COMMIT_SHA_LENGTH = 8
 
@@ -18,10 +19,10 @@ class BuildScenario(StrEnum):
     @classmethod
     def infer_scenario_from_environment(cls) -> "BuildScenario":
         """Infer the build scenario from environment variables."""
-        git_tag = os.getenv("triggered_by_git_tag")
-        is_patch = os.getenv("is_patch", "false").lower() == "true"
-        is_evg = os.getenv("RUNNING_IN_EVG", "false").lower() == "true"
-        patch_id = os.getenv("version_id")
+        git_tag = triggered_by_git_tag()
+        is_patch = is_evg_patch()
+        is_evg = is_running_in_evg()
+        patch_id = get_version_id()
 
         if git_tag:
             # Release scenario and the git tag will be used for promotion process only
@@ -46,7 +47,7 @@ def get_version(self, repository_path: str, changelog_sub_path: str, initial_com
 
         match self:
             case BuildScenario.PATCH:
-                patch_id = os.getenv("version_id")
+                patch_id = get_version_id()
                 if not patch_id:
                     raise ValueError(f"version_id environment variable is not set for `{self}` build scenario")
                 return patch_id

scripts/release/constants.py

@@ -14,3 +14,19 @@ def get_initial_version() -> str | None:
 
 def get_initial_commit_sha() -> str | None:
     return os.getenv(RELEASE_INITIAL_COMMIT_SHA_ENV_VAR)
+
+
+def triggered_by_git_tag() -> str | None:
+    return os.getenv("triggered_by_git_tag")
+
+
+def is_evg_patch() -> bool:
+    return os.getenv("is_patch", "false").lower() == "true"
+
+
+def is_running_in_evg() -> bool:
+    return os.getenv("RUNNING_IN_EVG", "false").lower() == "true"
+
+
+def get_version_id() -> str | None:
+    return os.getenv("version_id")

scripts/release/pipeline_main.py

@@ -56,14 +56,13 @@ def get_builder_function_for_image_name() -> Dict[str, Callable]:
         "upgrade-hook": build_upgrade_hook_image,  # working, but still using single arch build
         "operator-quick": build_operator_image_patch,  # TODO: remove this image, it is not used anymore
         "database": build_database_image,  # working
-        "agent-pct": build_agent_on_agent_bump,
-        "agent": build_agent_default_case,
+        "agent": build_agent_default_case,  # working
         # Init images
         "init-appdb": build_init_appdb_image,  # working
         "init-database": build_init_database_image,  # working
         "init-ops-manager": build_init_om_image,  # working
         # Ops Manager image
-        "ops-manager": build_om_image,
+        "ops-manager": build_om_image,  # working
     }
 
     return image_builders
@@ -185,16 +184,7 @@ def main():
         "--registry",
         help="Override the base registry instead of resolving from build scenario",
     )
-    parser.add_argument(
-        "--sign", action="store_true", help="Force signing instead of resolving condition from build scenario"
-    )
-
-    # Agent specific arguments
-    parser.add_argument(
-        "--all-agents",
-        action="store_true",
-        help="Build all agent variants instead of only the latest",
-    )
+    # For agent builds
     parser.add_argument(
         "--parallel-factor",
         default=0,