You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CLOUDP-295945 - stop calling mms repo in precommit hook (#4100)
# Summary
This PR removes calls to mms repository in precommit hook.
[update_agent_and_tools_version](https://github.com/10gen/ops-manager-kubernetes/blob/008c01523d5a1576a1ed2aaeecb08e208315c3a1/scripts/evergreen/release/update_release.py#L95)
function is the only code that calls mms to get agent and mongo tools
version for the most recent OM version in release.json
(`["supportedImages"]["ops-manager"]["versions"][-1]`). This information
is used for:
- `update_om_mapping` -> it updates the
`["supportedImages"]["mongodb-agent"]["opsManagerMapping"]["ops_manager"][latest_version]`
agent and tools mapping. I see that those values are set [by PCT during
OM
release](10gen/ops-manager-kubernetes@53b970c)
and precommit hook tries to update this path again with no changes
- `update_mongodb_tools_bundle` -> this updates
`["mongodbToolsBundle"]["ubi"]` bundle version that is used when
building `init_appdb` and `init_database`. We can get this information
from latest version in opsManagerMapping that PCT sets during OM release
## Followup tasks (after merging)
- [ ] update docs
[here](REDACTED)
and [here](REDACTED)
after merging PR
## Proof of Work
Run locally precommit hook with updated OM mapping in `release.json` and
it updated `mongodbToolsBundle` entry. Without changes to release.json
there are no updates - CI lint task
[succeeded](https://spruce.mongodb.com/task/ops_manager_kubernetes_unit_tests_lint_repo_patch_f316028ac429a42806039a834ce78906b5e2c1f1_67ae19a200e9150007c7d8ab_25_02_13_16_11_16/logs?execution=0).
## Checklist
- [x] Have you linked a jira ticket and/or is the ticket in the title?
- [x] Have you checked whether your jira ticket required DOCSP changes?
- [x] Have you checked for release_note changes?
## Reminder (Please remove this when merging)
- Please try to Approve or Reject Changes the PR, keep PRs in review as
short as possible
- Our Short Guide for PRs:
[Link](REDACTED)
- Remember the following Communication Standards - use comment prefixes
for clarity:
* **blocking**: Must be addressed before approval.
* **follow-up**: Can be addressed in a later PR or ticket.
* **q**: Clarifying question.
* **nit**: Non-blocking suggestions.
* **note**: Side-note, non-actionable. Example: Praise
* --> no prefix is considered a question
0 commit comments