Skip to content

Commit d3b59e6

Browse files
authored
CLOUDP-313599 - fix todos and Documentation cleanup (#29)
# Summary This pull request includes various changes across multiple files, focusing on cleanup, documentation updates, and dependency management. The most significant updates include removing outdated or redundant documentation, updating license references, and adding a new dependency to the project. ### Documentation and License Cleanup: * Removed the full Apache 2.0 license text from `mongodb-community-operator/APACHE2`, likely because it is no longer required in the repository. * Deleted the `mongodb-community-operator/CODE_OF_CONDUCT.md`, which referenced the MongoDB Code of Conduct. * Updated `mongodb-community-operator/LICENSE.md` by removing references to the MongoDB Agent binary and the Apache license file. ### Codebase Comments and TODO Updates: * Updated a TODO comment in `mongodb_community.py` to reference a specific ticket (`CLOUDP-307051`) for missing "observedGeneration" in the MongoDBCommunity status. * Updated/Removed a bunch of TODOs which don't apply anymore ## Proof of Work - tests are green ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes?
1 parent cf59a35 commit d3b59e6

File tree

17 files changed

+11
-1059
lines changed

17 files changed

+11
-1059
lines changed

.evergreen.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ git_tag_aliases:
231231
variant_tags: [ "release" ]
232232
task_tags: [ "image_release", "image_preflight", "openshift_bundles", "code_snippets" ]
233233

234-
# TODO: MCK: have this part of e2e.sh and its expansions
235234
tasks:
236235
- name: unit_tests_golang
237236
tags: [ "unit_tests" ]

docker/mongodb-enterprise-tests/kubetester/mongodb_community.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def assert_reaches_phase(self, phase: Phase, msg_regexp=None, timeout=None, igno
3838
lambda s: in_desired_state(
3939
current_state=self.get_status_phase(),
4040
desired_state=phase,
41-
# TODO: MCK we don't have "observedGeneration" in MongoDBCommunity status
41+
# TODO: CLOUDP-307051 we don't have "observedGeneration" in MongoDBCommunity status
4242
current_generation=1,
4343
observed_generation=1,
4444
current_message=self.get_status_message(),

mongodb-community-operator/APACHE2

Lines changed: 0 additions & 202 deletions
This file was deleted.

mongodb-community-operator/CODE_OF_CONDUCT.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

mongodb-community-operator/LICENSE.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

mongodb-community-operator/controllers/validation/validation.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,6 @@ func validateAgentCertSecret(mdb mdbv1.MongoDBCommunity, log *zap.SugaredLogger)
199199
func validateStatefulSet(mdb mdbv1.MongoDBCommunity) error {
200200
stsReplicas := mdb.Spec.StatefulSetConfiguration.SpecWrapper.Spec.Replicas
201201

202-
// TODO: MCK fix all nolint:gosec
203202
if stsReplicas != nil && *stsReplicas != int32(mdb.Spec.Members) { //nolint:gosec
204203
return fmt.Errorf("spec.statefulset.spec.replicas has to be equal to spec.members")
205204
}

0 commit comments

Comments
 (0)