CLOUDP-315085: Rename member list cm (#66)

# Summary

## Why

The multi cluster member-list configmap is created by both the helm
chart and kubectl tool.
It should not be created by helm. E.g one drawback is that the configmap
can be removed upon release uninstallation, which leads to a panic in
the currently running operator.
This is also confusing and it should be the responsibility of a single
tool to create that map.

The name of that configmap is 
mongodb-enterprise-operator-member-list and we should take the
opportunity to rename it to mongodb-kubernetes-operator-member-list, to
stay consistent with our new naming conventions.

Customers deploying multi cluster resources must run the kubectl plugin
when upgrading, so we can safely rename it.

## How

The config map name was mostly defined by constants so it's a small
renaming.

## Proof of Work

E2E tests pass (including upgrade tests)

---------

Co-authored-by: Mircea Cosbuc <[email protected]>

Author: Julien-Ben

api/v1/om/opsmanager_types.go

@@ -186,7 +186,7 @@ type Logging struct {
 // ClusterSpecOMItem defines members cluster details for Ops Manager multi-cluster deployment.
 type ClusterSpecOMItem struct {
 	// ClusterName is name of the cluster where the Ops Manager Statefulset will be scheduled.
-	// The operator is using ClusterName to find API credentials in `mongodb-enterprise-operator-member-list` config map to use for this member cluster.
+	// The operator is using ClusterName to find API credentials in `mongodb-kubernetes-operator-member-list` config map to use for this member cluster.
 	// If the credentials are not found, then the member cluster is considered unreachable and ignored in the reconcile process.
 	// +kubebuilder:validation:Required
 	ClusterName string `json:"clusterName,omitempty"`

config/crd/bases/mongodb.com_opsmanagers.yaml

@@ -1420,7 +1420,7 @@ spec:
                     clusterName:
                       description: |-
                         ClusterName is name of the cluster where the Ops Manager Statefulset will be scheduled.
-                        The operator is using ClusterName to find API credentials in `mongodb-enterprise-operator-member-list` config map to use for this member cluster.
+                        The operator is using ClusterName to find API credentials in `mongodb-kubernetes-operator-member-list` config map to use for this member cluster.
                         If the credentials are not found, then the member cluster is considered unreachable and ignored in the reconcile process.
                       type: string
                     configuration:

docker/mongodb-kubernetes-tests/tests/conftest.py

@@ -70,7 +70,7 @@
 DATABASE_SA_NAME = "mongodb-kubernetes-database-pods"
 OM_SA_NAME = "mongodb-kubernetes-ops-manager"
 TELEMETRY_CONFIGMAP_NAME = LEGACY_OPERATOR_NAME + "-telemetry"
-MULTI_CLUSTER_MEMBER_LIST_CONFIGMAP = LEGACY_OPERATOR_NAME + "-member-list"
+MULTI_CLUSTER_MEMBER_LIST_CONFIGMAP = OPERATOR_NAME + "-member-list"
 
 logger = test_logger.get_test_logger(__name__)
 
@@ -856,7 +856,28 @@ def official_operator(
         central_cluster_client,
         member_cluster_clients,
         member_cluster_names,
-        None,
+    )
+
+
+@fixture(scope="module")
+def official_meko_operator(
+    namespace: str,
+    managed_security_context: str,
+    operator_installation_config: Dict[str, str],
+    central_cluster_name: str,
+    central_cluster_client: client.ApiClient,
+    member_cluster_clients: List[MultiClusterClient],
+    member_cluster_names: List[str],
+) -> Operator:
+    return install_official_operator(
+        namespace,
+        managed_security_context,
+        operator_installation_config,
+        central_cluster_name,
+        central_cluster_client,
+        member_cluster_clients,
+        member_cluster_names,
+        operator_name=LEGACY_OPERATOR_NAME,
     )
 
 
@@ -869,6 +890,7 @@ def install_official_operator(
     member_cluster_clients: Optional[List[MultiClusterClient]],
     member_cluster_names: Optional[List[str]],
     custom_operator_version: Optional[str] = None,
+    operator_name: Optional[str] = OPERATOR_NAME,
 ) -> Operator:
     """
     Installs the Operator from the official Helm Chart.
@@ -887,8 +909,6 @@ def install_official_operator(
         "operator.mdbDefaultArchitecture": operator_installation_config["operator.mdbDefaultArchitecture"],
     }
 
-    operator_name = "mongodb-enterprise-operator"
-
     # Note, that we don't intend to install the official Operator to standalone clusters (kops/openshift) as we want to
     # avoid damaged CRDs. But we may need to install the "openshift like" environment to Kind instead of the "ubi"
     # images are used for installing the dev Operator
@@ -925,6 +945,7 @@ def install_official_operator(
                 namespace,
                 member_cluster_names,
                 service_account_name=operator_name + "-multi-cluster",
+                operator_name=operator_name,
             )
         operator_name = operator_name + "-multi-cluster"
         helm_args.update(
@@ -1203,6 +1224,7 @@ def run_kube_config_creation_tool(
     member_cluster_names: List[str],
     cluster_scoped: Optional[bool] = False,
     service_account_name: Optional[str] = "mongodb-kubernetes-operator-multi-cluster",
+    operator_name: Optional[str] = OPERATOR_NAME,
 ):
     central_cluster = _read_multi_cluster_config_value("central_cluster")
     member_clusters_str = ",".join(member_clusters)
@@ -1223,6 +1245,8 @@ def run_kube_config_creation_tool(
         central_namespace,
         "--service-account",
         service_account_name,
+        "--operator-name",
+        operator_name,
     ]
 
     if os.getenv("MULTI_CLUSTER_CREATE_SERVICE_ACCOUNT_TOKEN_SECRETS") == "true":
@@ -1279,6 +1303,7 @@ def run_multi_cluster_recovery_tool(
     member_namespace: str,
     cluster_scoped: Optional[bool] = False,
     service_account_name: Optional[str] = "mongodb-kubernetes-operator-multi-cluster",
+    operator_name: Optional[str] = OPERATOR_NAME,
 ) -> int:
     central_cluster = _read_multi_cluster_config_value("central_cluster")
     member_clusters_str = ",".join(member_clusters)
@@ -1303,6 +1328,8 @@ def run_multi_cluster_recovery_tool(
         member_clusters[0],
         "--service-account",
         service_account_name,
+        "--operator-name",
+        operator_name,
     ]
     if os.getenv("MULTI_CLUSTER_CREATE_SERVICE_ACCOUNT_TOKEN_SECRETS") == "true":
         args.append("--create-service-account-secrets")

docker/mongodb-kubernetes-tests/tests/multicluster/multi_cluster_recover_clusterwide.py

@@ -22,6 +22,7 @@
 from pytest import fixture, mark
 from tests.conftest import (
     MULTI_CLUSTER_OPERATOR_NAME,
+    OPERATOR_NAME,
     _install_multi_cluster_operator,
     run_kube_config_creation_tool,
     run_multi_cluster_recovery_tool,
@@ -97,6 +98,7 @@ def install_operator(
         member_cluster_names,
         True,
         service_account_name=MULTI_CLUSTER_OPERATOR_NAME,
+        operator_name=OPERATOR_NAME,
     )
 
     return _install_multi_cluster_operator(
@@ -218,7 +220,6 @@ def test_prepare_namespace(
 def test_copy_configmap_and_secret_across_ns(
     namespace: str,
     central_cluster_client: client.ApiClient,
-    multi_cluster_operator_installation_config: Dict[str, str],
     mdba_ns: str,
     mdbb_ns: str,
 ):

docker/mongodb-kubernetes-tests/tests/multicluster_appdb/multicluster_appdb_state_operator_upgrade_downgrade.py

@@ -2,8 +2,7 @@
 from typing import Dict, List, Optional
 
 import kubernetes.client
-from kubernetes import client
-from kubetester import create_or_update_configmap, get_deployments, read_configmap
+from kubetester import read_configmap
 from kubetester.kubetester import fixture as yaml_fixture
 from kubetester.mongodb import Phase
 from kubetester.operator import Operator
@@ -15,12 +14,10 @@
     LEGACY_MULTI_CLUSTER_OPERATOR_NAME,
     LEGACY_OPERATOR_NAME,
     MULTI_CLUSTER_OPERATOR_NAME,
-    OPERATOR_NAME,
     create_appdb_certs,
     get_central_cluster_name,
     get_custom_appdb_version,
     install_official_operator,
-    local_operator,
     log_deployments_info,
 )
 from tests.multicluster.conftest import cluster_spec_list
@@ -200,7 +197,8 @@ def test_install_legacy_state_official_operator(
             central_cluster_client,
             member_cluster_clients,
             member_cluster_names,
-            LEGACY_DEPLOYMENT_STATE_VERSION,
+            custom_operator_version=LEGACY_DEPLOYMENT_STATE_VERSION,
+            operator_name=LEGACY_OPERATOR_NAME,
         )
         operator.assert_is_running()
         # Dumping deployments in logs ensure we are using the correct operator version
@@ -317,7 +315,8 @@ def test_install_legacy_state_official_operator(
             central_cluster_client,
             member_cluster_clients,
             member_cluster_names,
-            LEGACY_DEPLOYMENT_STATE_VERSION,
+            custom_operator_version=LEGACY_DEPLOYMENT_STATE_VERSION,
+            operator_name=LEGACY_OPERATOR_NAME,
         )
         operator.assert_is_running()
         # Dumping deployments in logs ensure we are using the correct operator version

docker/mongodb-kubernetes-tests/tests/upgrades/meko_mck_upgrade.py

@@ -98,8 +98,8 @@ def replica_set(
 
 # Installs the latest officially released version of MEKO, from Quay
 @mark.e2e_meko_mck_upgrade
-def test_install_latest_official_operator(official_operator: Operator, namespace: str):
-    official_operator.assert_is_running()
+def test_install_latest_official_operator(official_meko_operator: Operator, namespace: str):
+    official_meko_operator.assert_is_running()
     # Dumping deployments in logs ensures we are using the correct operator version
     log_deployments_info(namespace)
 
@@ -141,7 +141,7 @@ def test_upgrade_operator(
             namespace=namespace,
             helm_args=operator_installation_config,
             helm_chart_path="helm_chart",
-            name="mongodb-kubernetes-operator",
+            name=OPERATOR_NAME,
         )
         operator.install()
     operator.assert_is_running()
@@ -156,7 +156,7 @@ def test_replicaset_reconciled(replica_set: MongoDB):
 
 @mark.e2e_meko_mck_upgrade
 def test_uninstall_latest_official_operator(namespace: str):
-    helm_uninstall("mongodb-enterprise-operator-multi-cluster" if is_multi_cluster() else "mongodb-enterprise-operator")
+    helm_uninstall(LEGACY_MULTI_CLUSTER_OPERATOR_NAME if is_multi_cluster() else LEGACY_OPERATOR_NAME)
     log_deployments_info(namespace)
 
 

docker/mongodb-kubernetes-tests/tests/upgrades/operator_upgrade_appdb_tls.py

@@ -89,7 +89,8 @@ def test_install_latest_official_operator(
         central_cluster_client,
         member_cluster_clients,
         member_cluster_names,
-        "1.32.0",  # latest operator version before fixing the appdb hostnames
+        custom_operator_version="1.32.0",  # latest operator version before fixing the appdb hostnames
+        operator_name=LEGACY_OPERATOR_NAME,
     )
     operator.assert_is_running()
 

docker/mongodb-kubernetes-tests/tests/upgrades/operator_upgrade_ops_manager.py

@@ -100,8 +100,8 @@ def some_mdb_health_checker(some_mdb: MongoDB) -> MongoDBBackgroundTester:
 
 
 @mark.e2e_operator_upgrade_ops_manager
-def test_install_latest_official_operator(official_operator: Operator):
-    official_operator.assert_is_running()
+def test_install_latest_official_operator(official_meko_operator: Operator):
+    official_meko_operator.assert_is_running()
 
 
 @mark.e2e_operator_upgrade_ops_manager

docker/mongodb-kubernetes-tests/tests/upgrades/operator_upgrade_replica_set.py

@@ -82,8 +82,8 @@ def replica_set_user(replica_set: MongoDB) -> MongoDBUser:
 
 
 @mark.e2e_operator_upgrade_replica_set
-def test_install_latest_official_operator(official_operator: Operator):
-    official_operator.assert_is_running()
+def test_install_latest_official_operator(official_meko_operator: Operator):
+    official_meko_operator.assert_is_running()
 
 
 @mark.e2e_operator_upgrade_replica_set

docker/mongodb-kubernetes-tests/tests/upgrades/operator_upgrade_sharded_cluster.py

@@ -106,6 +106,7 @@ def test_install_latest_official_operator(
             member_cluster_clients=None,
             member_cluster_names=None,
             custom_operator_version=LEGACY_DEPLOYMENT_STATE_VERSION,
+            operator_name=LEGACY_OPERATOR_NAME,
         )
         operator.assert_is_running()
         # Dumping deployments in logs ensures we are using the correct operator version
@@ -179,6 +180,7 @@ def test_downgrade_operator(
             member_cluster_clients=None,
             member_cluster_names=None,
             custom_operator_version=LEGACY_DEPLOYMENT_STATE_VERSION,
+            operator_name=LEGACY_OPERATOR_NAME,
         )
         operator.assert_is_running()
         # Dumping deployments in logs ensures we are using the correct operator version