CLOUDP-239791: Replace log.Fatal calls in main.go with run() error pattern#941
Open
m1kola wants to merge 1 commit intomongodb:masterfrom
Open
CLOUDP-239791: Replace log.Fatal calls in main.go with run() error pattern#941m1kola wants to merge 1 commit intomongodb:masterfrom
m1kola wants to merge 1 commit intomongodb:masterfrom
Conversation
…ttern Extract operator startup logic into a run() function that returns an error, so deferred cleanup (tracer shutdown, span end) runs on failure instead of being bypassed by os.Exit via log.Fatal.
m1kola
added
the
skip-changelog
josvazg
reviewed
Mar 27, 2026
Comment on lines
+114
to
+115
| log.Error(err) | ||
| os.Exit(1) |
Collaborator
There was a problem hiding this comment.
q: why not making this a fatal? I would also wrap the error with some info.
Suggested change
| log.Error(err) | |
| os.Exit(1) | |
| log.Fatalf("Fatal error: %v", err) |
Contributor
Author
There was a problem hiding this comment.
I normally prefer explicit over implicit. And log.Fatalf has an implicit exit.
But I don't mind changing it to log.Fatalf, if you prefer.
Collaborator
There was a problem hiding this comment.
I'd say log.Fatalf is more idiomatic and standard
josvazg
reviewed
Mar 27, 2026
josvazg
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract operator startup logic into a
run()function that returns anerror, so deferred cleanup (tracer shutdown, span end) runs on failure instead of being bypassed byos.Exitvialog.Fatal.Proof of Work
CI must be green
Checklist
skip-changeloglabel if not needed