Skip to content

Commit e1159b7

Browse files
authored
fix: Sets scopes in Read to support Scope updates (#1234)
1 parent 88a6e64 commit e1159b7

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

cfn-resources/database-user/cmd/resource/resource.go

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -104,19 +104,12 @@ func Read(req handler.Request, prevModel *Model, currentModel *Model) (handler.P
104104
return progressevent.GetFailedEventByResponse(err.Error(), resp), nil
105105
}
106106

107+
_, _ = logger.Debugf("databaseUser:%+v", databaseUser)
107108
currentModel.DatabaseName = &databaseUser.DatabaseName
108-
109-
if currentModel.LdapAuthType != nil {
110-
currentModel.LdapAuthType = databaseUser.LdapAuthType
111-
}
112-
if currentModel.AWSIAMType != nil {
113-
currentModel.AWSIAMType = databaseUser.AwsIAMType
114-
}
115-
if currentModel.X509Type != nil {
116-
currentModel.X509Type = databaseUser.X509Type
117-
}
109+
currentModel.LdapAuthType = databaseUser.LdapAuthType
110+
currentModel.AWSIAMType = databaseUser.AwsIAMType
111+
currentModel.X509Type = databaseUser.X509Type
118112
currentModel.Username = &databaseUser.Username
119-
_, _ = logger.Debugf("databaseUser:%+v", databaseUser)
120113
var roles []RoleDefinition
121114

122115
for _, r := range databaseUser.GetRoles() {
@@ -141,7 +134,15 @@ func Read(req handler.Request, prevModel *Model, currentModel *Model) (handler.P
141134
labels = append(labels, label)
142135
}
143136
currentModel.Labels = labels
144-
137+
var scopes []ScopeDefinition
138+
for _, s := range databaseUser.GetScopes() {
139+
scope := ScopeDefinition{
140+
Name: &s.Name,
141+
Type: &s.Type,
142+
}
143+
scopes = append(scopes, scope)
144+
}
145+
currentModel.Scopes = scopes
145146
updateUserCFNIdentifier(currentModel)
146147

147148
return handler.ProgressEvent{

cfn-resources/database-user/test/inputs_2_update.template.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
"Roles": [
88
{
99
"RoleName": "readWrite",
10-
"DatabaseName": "testdb",
10+
"DatabaseName": "testdb2",
1111
"CollectionName": "col2"
1212
}
1313
],
1414
"Scopes": [
1515
{
1616
"Type": "CLUSTER",
17-
"Name": "testdb"
17+
"Name": "testdb2"
1818
}
1919
]
2020
}

0 commit comments

Comments
 (0)