Skip to content

Conversation

@maastha
Copy link
Collaborator

@maastha maastha commented Apr 14, 2025

Proposed changes

Jira ticket: CLOUDP-295769

Adds Description attribute to Resource Policy resource.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@maastha maastha changed the base branch from master to atlas-sdk-update April 14, 2025 19:22
@maastha maastha marked this pull request as ready for review April 14, 2025 19:31
@maastha maastha requested a review from a team as a code owner April 14, 2025 19:31
Base automatically changed from atlas-sdk-update to master April 15, 2025 06:47
Name: model.Name,
Policies: modelPoliciesToSDKPolicies(model.Policies),
Name: model.Name,
Description: model.Description,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen in the update if the description is removed from the template? I guess it will be nil and therefore, not update/delete the description?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, since we don't validate against previous model in CFN at this point, users can still unset the description by setting it to an empty string. It's not ideal but atleast we have a workaround until we have alignment on this.

@maastha maastha added this pull request to the merge queue Apr 15, 2025
Merged via the queue into master with commit 0a47a26 Apr 15, 2025
35 checks passed
@maastha maastha deleted the CLOUDP-295769-rp-desc-2 branch April 15, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants