MONGOID-5477 / MONGOID-5474 / MONGOID-5478 add user test (#5459)

* MONGOID-5474 add user test

* MONGOID-5474 change to read-only

* MOGOID-5474 switch order of flag docs

Author: neilshweky

lib/mongoid/config.rb

@@ -127,13 +127,13 @@ module Config
     # always return a Hash.
     option :legacy_attributes, default: false
 
-    # When this flag is true, a document is only readonly if it has been
-    # projected using #only or #without, and readonly documents will not
-    # be deletable/destroyable. When this flag is false, a document will
-    # become readonly only once the #readonly! method is called, and an error
-    # will be raised on attempting to save or update such documents, instead
-    # of just on delete.
-    # When this feature flag is turned on, the readonly state will be reset on
+    # When this flag is false, a document will become read-only only once the 
+    # #readonly! method is called, and an error will be raised on attempting
+    # to save or update such documents, instead of just on delete. When this
+    # flag is true, a document is only read-only if it has been projected
+    # using #only or #without, and read-only documents will not be
+    # deletable/destroyable, but they will be savable/updatable.
+    # When this feature flag is turned on, the read-only state will be reset on
     # reload, but when it is turned off, it won't be.
     option :legacy_readonly, default: false
 

spec/mongoid/stateful_spec.rb

@@ -173,6 +173,36 @@
           op
         end
       end
+
+      context "when overriding readonly?" do
+
+        let(:doc) { ReadonlyModel.create! }
+
+        before do
+          class ReadonlyModel
+            include Mongoid::Document
+
+            attr_accessor :locked
+
+            def readonly?
+              !!locked
+            end
+          end
+        end
+
+        after do
+          Object.send(:remove_const, :ReadonlyModel)
+        end
+
+        it "raises when readonly? is true" do
+          expect(doc.readonly?).to be false
+          doc.locked = true
+          expect(doc.readonly?).to be true
+          expect do
+            doc.destroy
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
     end
 
     context "when legacy_readonly is false" do
@@ -206,6 +236,36 @@
           expect(document).to_not be_readonly
         end
       end
+
+      context "when overriding readonly?" do
+
+        let(:doc) { ReadonlyModel.new }
+
+        before do
+          class ReadonlyModel
+            include Mongoid::Document
+
+            attr_accessor :locked
+
+            def readonly?
+              !!locked
+            end
+          end
+        end
+
+        after do
+          Object.send(:remove_const, :ReadonlyModel)
+        end
+
+        it "raises when readonly? is true" do
+          expect(doc.readonly?).to be false
+          doc.locked = true
+          expect(doc.readonly?).to be true
+          expect do
+            doc.save!
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
     end
   end
 end