Skip to content

Commit 2384b48

Browse files
johnnyshieldsp
andauthored
MONGOID-5323: Remove deprecated Mongoid::Errors::EagerLoad class (#5240)
* Remove deprecated Mongoid::Errors::EagerLoad class. It is not used in the code at all. * Remove I18n message * Remove require * add release note Co-authored-by: shields <[email protected]> Co-authored-by: Oleg Pudeyev <[email protected]>
1 parent 3bf0d96 commit 2384b48

File tree

5 files changed

+9
-65
lines changed

5 files changed

+9
-65
lines changed

docs/release-notes/mongoid-8.0.txt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,15 @@ The previously deprecated ``Document#to_a`` method has been removed in
310310
Mongoid 8.
311311

312312

313+
Removed ``Mongoid::Errors::EagerLoad`` Exception Class
314+
------------------------------------------------------
315+
316+
The previously deprecated ``Mongoid::Errors::EagerLoad`` exception class
317+
has been removed in Mongoid 8. It has not been used by Mongoid since
318+
version 7.1.1 when eager loading for polymorphic ``belongs_to`` associations
319+
was implemented.
320+
321+
313322
Replaced ``Mongoid::Criteria#geo_spacial`` with ``#geo_spatial``
314323
----------------------------------------------------------------
315324

lib/config/locales/en.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,6 @@ en:
7272
resolution: "Search for attributes that are in the database or set
7373
the Mongoid.raise_not_found_error configuration option to false,
7474
which will cause a nil to be returned instead of raising this error."
75-
eager_load:
76-
message: "Eager loading :%{name} is not supported since it is a
77-
polymorphic belongs_to association."
78-
summary: "Mongoid cannot currently determine the classes it needs to
79-
eager load when the association is polymorphic. The parents reside in
80-
different collections so a simple id lookup is not sufficient enough."
81-
resolution: "Don't attempt to perform this action and have patience,
82-
maybe this will be supported in the future."
8375
empty_config_file:
8476
message: "Empty configuration file: %{path}."
8577
summary: "Your mongoid.yml configuration file appears to be empty."

lib/mongoid/errors.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
require "mongoid/errors/criteria_argument_required"
77
require "mongoid/errors/document_not_destroyed"
88
require "mongoid/errors/document_not_found"
9-
require "mongoid/errors/eager_load"
109
require "mongoid/errors/empty_config_file"
1110
require "mongoid/errors/in_memory_collation_not_supported"
1211
require "mongoid/errors/invalid_collection"

lib/mongoid/errors/eager_load.rb

Lines changed: 0 additions & 25 deletions
This file was deleted.

spec/mongoid/errors/eager_load_spec.rb

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)