MONGOID-5222 get rid of 42bogus

Author: neilshweky

docs/release-notes/mongoid-8.0.txt

@@ -73,10 +73,6 @@ functionality:
 +--------------+------------------------+------------------------+-------------------+
 | Field Type   | Situation              | Previous Functionality | New Functionality |
 +==============+========================+========================+===================+
-| Integer/Float| When a non-numeric     | return ``nil``         | return ``42``     |
-|              | string starts with a   |                        |                   |
-|              | number: "42bogus"      |                        |                   |
-+--------------+------------------------+------------------------+-------------------+
 | Boolean      | When a non-boolean     | return ``false``       | return ``nil`` or |
 |              | string is assigned:    |                        | raise             |
 |              | "bogus value"          |                        | ``InvalidError``  |

lib/mongoid/extensions/big_decimal.rb

@@ -74,13 +74,11 @@ def mongoize(object)
               BSON::Decimal128.new(object)
             elsif object.numeric?
               BSON::Decimal128.new(object.to_s)
-            elsif object.respond_to?(:to_d)
-              BSON::Decimal128.new(object.to_d)
             end
           else
             if object.is_a?(BSON::Decimal128) || object.numeric?
               object.to_s
-            elsif object.respond_to?(:to_d)
+            elsif object.numeric?
               object.to_d.to_s
             end
           end.tap do |res|

lib/mongoid/extensions/float.rb

@@ -38,7 +38,7 @@ module ClassMethods
         def mongoize(object)
           return if object.nil?
           return if object.is_a?(String) && object.blank?
-          if object.respond_to?(:to_f)
+          if object.numeric?
             object.to_f
           else
             raise Errors::InvalidValue.new(self, object)

lib/mongoid/extensions/integer.rb

@@ -46,7 +46,7 @@ module ClassMethods
         def mongoize(object)
           return if object.nil?
           return if object.is_a?(String) && object.blank?
-          if object.respond_to?(:to_i)
+          if object.numeric?
             object.to_i
           else
             raise Errors::InvalidValue.new(self, object)

spec/mongoid/extensions/big_decimal_spec.rb

@@ -268,8 +268,10 @@
           "1a2"
         end
 
-        it "returns a string" do
-          expect(mongoized).to eq("1.0")
+        it "raises an error" do
+          expect do
+            mongoized
+          end.to raise_error(Mongoid::Errors::InvalidValue)
         end
       end
 
@@ -711,7 +713,9 @@
         end
 
         it "returns a decimal128" do
-          expect(mongoized).to eq(BSON::Decimal128.new("1"))
+          expect do
+            mongoized
+          end.to raise_error(Mongoid::Errors::InvalidValue)
         end
       end
 

spec/mongoid/extensions/float_spec.rb

@@ -61,7 +61,9 @@
     context "when the value is not a float string" do
 
       it "return 0" do
-        expect(Float.demongoize('asdf')).to eq(0)
+        expect do
+          Float.demongoize('asdf')
+        end.to raise_error(Mongoid::Errors::InvalidValue)
       end
     end
   end
@@ -125,7 +127,9 @@
       context "when the string is non numerical" do
 
         it "return 0" do
-          expect(Float.mongoize("foo")).to eq(0)
+          expect do
+            Float.mongoize("foo")
+          end.to raise_error(Mongoid::Errors::InvalidValue)
         end
       end
 

spec/mongoid/extensions/integer_spec.rb

@@ -112,7 +112,9 @@
       context "when the string is non numerical" do
 
         it "returns 0" do
-          expect(Integer.mongoize("foo")).to eq(0)
+          expect do
+            Integer.mongoize("foo")
+          end.to raise_error(Mongoid::Errors::InvalidValue)
         end
       end