MONGOID-5222 fix more comments and update compatibility release note

Author: neilshweky

docs/release-notes/mongoid-8.0.txt

@@ -80,6 +80,12 @@ functionality:
 |              | ``to_sym`` is          |                        |                   |
 |              | assigned: ``[]``       |                        |                   |
 +--------------+------------------------+------------------------+-------------------+
+| Array/Set    | When a value that is   | return ``[ 1, 2, 3 ]`` | return ``nil``    |
+|              | not an array or set is | return ``[[ :x, 1 ]]`` | return ``nil``    |
+|              | assigned, but does     |                        |                   |
+|              | respond to ``to_a``:   |                        |                   |
+|              | ``1..3``, ``{ x: 1 }`` |                        |                   |
++--------------+------------------------+------------------------+-------------------+
 | All Other    | When an uncastable     | undefined behavior,    | return ``nil``    |
 | Types        | value is assigned      | occasionally raises    |                   |
 |              |                        | ``NoMethodError``      |                   |

lib/mongoid/extensions/big_decimal.rb

@@ -66,8 +66,7 @@ def demongoize(object)
         #   representing the object or nil. String if Mongoid.map_big_decimal_to_decimal128
         #   is false, BSON::Decimal128 otherwise.
         def mongoize(object)
-          return if object.nil?
-          return if object.is_a?(String) && object.blank?
+          return if object.blank?
           if Mongoid.map_big_decimal_to_decimal128
             if object.is_a?(BSON::Decimal128)
               object
@@ -79,8 +78,6 @@ def mongoize(object)
           else
             if object.is_a?(BSON::Decimal128) || object.numeric?
               object.to_s
-            elsif object.numeric?
-              object.to_d.to_s
             end
           end
         end

lib/mongoid/extensions/boolean.rb

@@ -13,7 +13,7 @@ class << self
       #
       # @return [ true | false | nil ] The object mongoized or nil.
       def mongoize(object)
-        return if object.nil?
+        return if object.blank?
         if object.to_s =~ (/\A(true|t|yes|y|on|1|1.0)\z/i)
           true
         elsif object.to_s =~ (/\A(false|f|no|n|off|0|0.0)\z/i)

lib/mongoid/extensions/date.rb

@@ -52,21 +52,19 @@ def demongoize(object)
         #
         # @return [ Time | nil ] The object mongoized or nil.
         def mongoize(object)
-          return if object.nil?
-          unless object.blank?
-            begin
-              if object.is_a?(String)
-                # https://jira.mongodb.org/browse/MONGOID-4460
-                time = ::Time.parse(object)
-              else
-                time = object.__mongoize_time__
-              end
-              if time.acts_like?(:time)
-                ::Time.utc(time.year, time.month, time.day)
-              end
-            rescue ArgumentError
-              nil
+          return if object.blank?
+          begin
+            if object.is_a?(String)
+              # https://jira.mongodb.org/browse/MONGOID-4460
+              time = ::Time.parse(object)
+            else
+              time = object.__mongoize_time__
             end
+            if time.acts_like?(:time)
+              ::Time.utc(time.year, time.month, time.day)
+            end
+          rescue ArgumentError
+            nil
           end
         end
       end

lib/mongoid/extensions/float.rb

@@ -36,7 +36,7 @@ module ClassMethods
         #
         # @return [ Float | nil ] The object mongoized or nil.
         def mongoize(object)
-          return if object.nil?
+          return if object.blank?
           if object.numeric?
             object.to_f
           end

lib/mongoid/extensions/hash.rb

@@ -221,7 +221,7 @@ module ClassMethods
         def mongoize(object)
           return if object.nil?
           if object.is_a?(Hash)
-            evolve(object.dup).transform_values!(&:mongoize)
+            object.dup.transform_values!(&:mongoize)
           end
         end
 

lib/mongoid/extensions/integer.rb

@@ -44,7 +44,7 @@ module ClassMethods
         #
         # @return [ Integer | nil ] The object mongoized or nil.
         def mongoize(object)
-          return if object.nil?
+          return if object.blank?
           if object.numeric?
             object.to_i
           end

lib/mongoid/extensions/time.rb

@@ -65,7 +65,7 @@ def demongoize(object)
         #
         # @return [ Time | nil ] The object mongoized or nil.
         def mongoize(object)
-          return if object.nil?
+          return if object.blank?
           begin
             time = object.__mongoize_time__
             if time.acts_like?(:time)

spec/mongoid/extensions/date_spec.rb

@@ -76,4 +76,23 @@
       expect(date.mongoize).to eq(time)
     end
   end
+
+  describe ".mongoize" do
+    let(:date) do
+      Date.new(2010, 1, 1)
+    end
+
+    let(:time) do
+      Time.utc(2010, 1, 1, 0, 0, 0, 0)
+    end
+
+    let(:mongoized) do
+      byebug
+      Date.mongoize(date)
+    end
+
+    it "returns the date as a time" do
+      expect(mongoized).to eq(time)
+    end
+  end
 end