MONGOID-5080 Add tests for locating inverses (#5210)

* MONGOID-5275 add failing test

* MONGOID-5275 attempt a fix

* MONGOID-5275 another potential fix

* MONGOID-5275 add back name_with_module

* MONGOID-5275 go back to comparing classes

* MONGOID-5275 next on no class found

* MONGOID-5275 remove unused code

* MONGOID-5275 add touch tests

* MONGOID-5275 add module into relation class name

* remove leftover commented code

* MONGOID-5275 include short docstring

* move test

* add docstring

* add a test which does not use a class name which also exists on top level

* add test escaping namespacing

* add test when inverse is not found

* reinstate comment

* test unqualified class_name

* test does not work yet

* revert everything other than tests relevant to MONGOID-5080

* mark pending

* mark pending correctly

Co-authored-by: Neil Shweky <[email protected]>
Co-authored-by: Oleg Pudeyev <[email protected]>

Author: 3 people

spec/mongoid/association/embedded/embeds_many/proxy_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require_relative '../embeds_many_models.rb'
 
 describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 

spec/mongoid/association/embedded/embeds_many_models.rb

@@ -104,3 +104,61 @@ class EmmOrder
 
   embedded_in :user, class_name: 'EmmUser'
 end
+
+module EmmSpec
+  # There is also a top-level Car class defined.
+  class Car
+    include Mongoid::Document
+
+    embeds_many :doors
+  end
+
+  class Door
+    include Mongoid::Document
+
+    embedded_in :car
+  end
+
+  class Tank
+    include Mongoid::Document
+
+    embeds_many :guns
+    embeds_many :emm_turrets
+    # This association references a model that is not in our module,
+    # and it does not define class_name hence Mongoid will not be able to
+    # figure out the inverse for this association.
+    embeds_many :emm_hatches
+
+    # class_name is intentionally unqualified, references a class in the
+    # same module. Rails permits class_name to be unqualified like this.
+    embeds_many :launchers, class_name: 'Launcher'
+  end
+
+  class Gun
+    include Mongoid::Document
+
+    embedded_in :tank
+  end
+
+  class Launcher
+    include Mongoid::Document
+
+    # class_name is intentionally unqualified.
+    embedded_in :tank, class_name: 'Tank'
+  end
+end
+
+# This is intentionally on top level.
+class EmmTurret
+  include Mongoid::Document
+
+  embedded_in :tank, class_name: 'EmmSpec::Tank'
+end
+
+# This is intentionally on top level.
+class EmmHatch
+  include Mongoid::Document
+
+  # No :class_name option on this association intentionally.
+  embedded_in :tank
+end

spec/mongoid/association/embedded/embeds_many_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require_relative 'embeds_many_models'
 
 describe Mongoid::Association::Embedded::EmbedsMany do
 
@@ -861,4 +862,71 @@ class OtherEmbeddedObject; end
       expect(association.path(double( :_parent => true))).to be_a(Mongoid::Atomic::Paths::Embedded::Many)
     end
   end
+
+  context "when the document and embedded document's klass is in a submodule" do
+
+    let(:tank) { EmmSpec::Tank.create! }
+    let(:gun) { tank.guns.create! }
+
+    let(:inverse_assoc) { gun._association.inverse_association }
+
+    it "has the correct inverses" do
+      pending 'MONGOID-5080'
+
+      inverse_assoc.should be_a(Mongoid::Association::Embedded::EmbeddedIn)
+      inverse_assoc.name.should == :tank
+    end
+
+    context "when embedded association is not namespaced but has class_name" do
+
+      let(:turret) { tank.emm_turrets.create! }
+
+      let(:inverse_assoc) { turret._association.inverse_association }
+
+      it "has the correct inverses" do
+        inverse_assoc.should be_a(Mongoid::Association::Embedded::EmbeddedIn)
+        inverse_assoc.name.should == :tank
+      end
+    end
+
+    context "when embedded association is not namespaced and lacks class_name" do
+
+      let(:hatch) { tank.emm_hatches.create! }
+
+      let(:inverse_assoc) { hatch._association.inverse_association }
+
+      it "does not find the inverse" do
+        inverse_assoc.should be nil
+      end
+    end
+
+    context "when the class names exist on top level and namespaced" do
+
+      let(:car) { EmmSpec::Car.create! }
+      let(:door) { car.doors.create! }
+
+      let(:inverse_assoc) { door._association.inverse_association }
+
+      it "has the correct inverses" do
+        pending 'MONGOID-5080'
+
+        inverse_assoc.should be_a(Mongoid::Association::Embedded::EmbeddedIn)
+        inverse_assoc.name.should == :car
+      end
+    end
+
+    context "when the association has an unqualified class_name in same module" do
+
+      let(:launcher) { tank.launchers.create! }
+
+      let(:inverse_assoc) { launcher._association.inverse_association }
+
+      it "has the correct inverses" do
+        pending 'unqualified class_name arguments do not work per MONGOID-5080'
+
+        inverse_assoc.should be_a(Mongoid::Association::Embedded::EmbeddedIn)
+        inverse_assoc.name.should == :tank
+      end
+    end
+  end
 end