MONGOID-5760 Update feature flags defaults and remove deprecations (#5811)

* configure defaults for <= 8.1

* deprecate "running_with_passenger?"

* remove code deprecated <= 8.1

* fix failing specs

Author: jamis

lib/mongoid/config.rb

@@ -376,10 +376,14 @@ def time_zone
     #   config.running_with_passenger?
     #
     # @return [ true | false ] If the app is deployed on Passenger.
+    #
+    # @deprecated
     def running_with_passenger?
       @running_with_passenger ||= defined?(PhusionPassenger)
     end
 
+    Mongoid.deprecate(self, :running_with_passenger?)
+
     private
 
     def set_log_levels

lib/mongoid/config/defaults.rb

@@ -25,6 +25,8 @@ def load_defaults(version)
         when "8.1"
           self.immutable_ids = false
           self.legacy_persistence_context_behavior = true
+          self.around_callbacks_for_embeds = true
+          self.prevent_multiple_calls_of_embedded_callbacks = false
 
           load_defaults "9.0"
         when "9.0"

lib/mongoid/contextual/geo_near.rb

@@ -6,7 +6,6 @@
 require "mongoid/contextual/atomic"
 require "mongoid/contextual/aggregable/mongo"
 require "mongoid/contextual/command"
-require "mongoid/contextual/geo_near"
 require "mongoid/contextual/map_reduce"
 require "mongoid/association/eager_loadable"
 
@@ -24,8 +23,6 @@ class Mongo
       include Association::EagerLoadable
       include Queryable
 
-      Mongoid.deprecate(self, :geo_near)
-
       # Options constant.
       OPTIONS = [ :hint,
                   :limit,
@@ -263,29 +260,6 @@ def find_first
         end
       end
 
-      # Execute a $geoNear command against the database.
-      #
-      # @example Find documents close to 10, 10.
-      #   context.geo_near([ 10, 10 ])
-      #
-      # @example Find with spherical distance.
-      #   context.geo_near([ 10, 10 ]).spherical
-      #
-      # @example Find with a max distance.
-      #   context.geo_near([ 10, 10 ]).max_distance(0.5)
-      #
-      # @example Provide a distance multiplier.
-      #   context.geo_near([ 10, 10 ]).distance_multiplier(1133)
-      #
-      # @param [ Array<Float> ] coordinates The coordinates.
-      #
-      # @return [ GeoNear ] The GeoNear command.
-      #
-      # @deprecated
-      def geo_near(coordinates)
-        GeoNear.new(collection, criteria, coordinates)
-      end
-
       # Create the new Mongo context. This delegates operations to the
       # underlying driver.
       #

lib/mongoid/contextual/mongo.rb

@@ -71,8 +71,10 @@ def mongoize(object)
             if object.is_a?(String)
               # https://jira.mongodb.org/browse/MONGOID-4460
               time = ::Time.parse(object)
-            else
+            elsif object.respond_to?(:__mongoize_time__)
               time = object.__mongoize_time__
+            else
+              nil
             end
           rescue ArgumentError
             nil

lib/mongoid/extensions/date.rb

@@ -32,22 +32,6 @@ def __find_args__
       end
       Mongoid.deprecate(self, :__find_args__)
 
-      # Mongoize a plain object into a time.
-      #
-      # @note This method should not be used, because it does not
-      #   return correct results for non-Time objects. Override
-      #   __mongoize_time__ in classes that are time-like to return an
-      #   instance of Time or ActiveSupport::TimeWithZone.
-      #
-      # @example Mongoize the object.
-      #   object.__mongoize_time__
-      #
-      # @return [ Object ] self.
-      # @deprecated
-      def __mongoize_time__
-        self
-      end
-
       # Try to form a setter from this object.
       #
       # @example Try to form a setter.

lib/mongoid/extensions/object.rb

@@ -71,7 +71,7 @@ def demongoize(object)
         def mongoize(object)
           return if object.blank?
           begin
-            time = object.__mongoize_time__
+            time = object.respond_to?(:__mongoize_time__) ? object.__mongoize_time__ : nil
           rescue ArgumentError
             return
           end

lib/mongoid/extensions/time.rb

@@ -38,7 +38,6 @@ module Findable
       :for_js,
       :fourth,
       :fourth!,
-      :geo_near,
       :includes,
       :last!,
       :map_reduce,

lib/mongoid/findable.rb

@@ -289,17 +289,15 @@ def check_scope_validity(value)
       # @return [ Method ] The defined method.
       def define_scope_method(name)
         singleton_class.class_eval do
-          ruby2_keywords(
-            define_method(name) do |*args, **kwargs|
-              scoping = _declared_scopes[name]
-              scope = instance_exec(*args, **kwargs, &scoping[:scope])
-              extension = scoping[:extension]
-              to_merge = scope || queryable
-              criteria = to_merge.empty_and_chainable? ? to_merge : with_default_scope.merge(to_merge)
-              criteria.extend(extension)
-              criteria
-            end
-          )
+          define_method(name) do |*args, **kwargs|
+            scoping = _declared_scopes[name]
+            scope = instance_exec(*args, **kwargs, &scoping[:scope])
+            extension = scoping[:extension]
+            to_merge = scope || queryable
+            criteria = to_merge.empty_and_chainable? ? to_merge : with_default_scope.merge(to_merge)
+            criteria.extend(extension)
+            criteria
+          end
         end
       end