MONGOID-5222 remove InvalidValue from tests

Author: neilshweky

lib/mongoid/criteria/queryable/extensions/boolean.rb

@@ -20,11 +20,8 @@ module ClassMethods
             # @return [ true, false ] The boolean value.
             def evolve(object)
               __evolve__(object) do |obj|
-                begin
-                  mongoize(object)
-                rescue InvalidValue
-                  object
-                end
+                res = mongoize(object)
+                res.nil? ? object : res
               end
             end
           end

spec/mongoid/attributes_spec.rb

@@ -1583,16 +1583,14 @@
     context "when attribute is a Hash" do
       let(:person) { Person.new map: { somekey: "somevalue" } }
 
-      it "raises an error when trying to set a value of invalid type - array" do
-        expect do
-          person.map = []
-        end.to raise_error(Mongoid::Errors::InvalidValue, /The value \[\] cannot be written to a field of type Hash/)
+      it "writes nil when trying to set a value of invalid type - array" do
+        person.map = []
+        expect(person.map).to be_nil
       end
 
-      it "raises an error when trying to set a value of invalid type - boolean" do
-        expect do
-          person.map = false
-        end.to raise_error(Mongoid::Errors::InvalidValue, /The value false cannot be written to a field of type Hash/)
+      it "writes nil when trying to set a value of invalid type - boolean" do
+        person.map = false
+        expect(person.map).to be_nil
       end
 
       it "can set a Hash value" do
@@ -1607,16 +1605,14 @@
         expect(person.aliases).to eq([ :alias_1 ])
       end
 
-      it "raises an error when trying to set a value of invalid type - hash" do
-        expect do
-          person.aliases = {}
-        end.to raise_error(Mongoid::Errors::InvalidValue, /The value {} cannot be written to a field of type Array/)
+      it "writes nil when trying to set a value of invalid type - hash" do
+        person.aliases = {}
+        expect(person.aliases).to be_nil
       end
 
-      it "raises an error when trying to set a value of invalid type - boolean" do
-        expect do
-          person.aliases = false
-        end.to raise_error(Mongoid::Errors::InvalidValue, /The value false cannot be written to a field of type Array/)
+      it "writes nil when trying to set a value of invalid type - boolean" do
+        person.aliases = false
+        expect(person.aliases).to be_nil
       end
     end
 

spec/mongoid/extensions/big_decimal_spec.rb

@@ -268,10 +268,8 @@
           "1a2"
         end
 
-        it "raises an error" do
-          expect do
-            mongoized
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        it "returns nil" do
+          expect(mongoized).to be_nil
         end
       end
 
@@ -292,10 +290,8 @@
           true
         end
 
-        it "raises an error" do
-          expect do
-            mongoized
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        it "returns nil" do
+          expect(mongoized).to be_nil
         end
       end
 
@@ -305,10 +301,8 @@
           false
         end
 
-        it "raises an error" do
-          expect do
-            mongoized
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        it "returns nil" do
+          expect(mongoized).to be_nil
         end
       end
 
@@ -712,10 +706,8 @@
           "1a2"
         end
 
-        it "returns a decimal128" do
-          expect do
-            mongoized
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        it "returns nil" do
+          expect(mongoized).to be_nil
         end
       end
 
@@ -736,10 +728,8 @@
           true
         end
 
-        it "raises an error" do
-          expect do
-            mongoized
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        it "returns nil" do
+          expect(mongoized).to be_nil
         end
       end
 
@@ -749,10 +739,8 @@
           false
         end
 
-        it "raises an error" do
-          expect do
-            mongoized
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        it "returns nil" do
+          expect(mongoized).to be_nil
         end
       end
 

spec/mongoid/extensions/binary_spec.rb

@@ -56,10 +56,8 @@
 
       let(:value) { true }
 
-      it "raises an error" do
-        expect do
-          mongoized
-        end.to raise_error(Mongoid::Errors::InvalidValue)
+      it "returns nil" do
+        expect(mongoized).to be_nil
       end
     end
   end

spec/mongoid/extensions/date_class_mongoize_spec.rb

@@ -102,19 +102,19 @@
           Date.mongoize("")
         end
 
-        it "raises an error" do
-          expect do
-            evolved
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        it "returns nil" do
+          expect(evolved).to be_nil
         end
       end
 
       context "when the string is an invalid time" do
 
-        it "raises an error" do
-          expect do
-            Date.mongoize("time")
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        let(:evolved) do
+          Date.mongoize("time")
+        end
+
+        it "returns nil" do
+          expect(evolved).to be_nil
         end
       end
     end

spec/mongoid/extensions/date_time_spec.rb

@@ -79,10 +79,12 @@
 
     context "when the string is an invalid time" do
 
-      it "raises an error" do
-        expect do
-          DateTime.mongoize("time")
-        end.to raise_error(Mongoid::Errors::InvalidValue)
+      let(:mongoized) do
+        DateTime.mongoize("time")
+      end
+
+      it "returns nil" do
+        expect(mongoized).to be_nil
       end
     end
   end

spec/mongoid/extensions/float_spec.rb

@@ -60,10 +60,12 @@
 
     context "when the value is not a float string" do
 
-      it "return 0" do
-        expect do
-          Float.demongoize('asdf')
-        end.to raise_error(Mongoid::Errors::InvalidValue)
+      let(:demongoized) do
+        Float.demongoize('asdf')
+      end
+
+      it "returns nil" do
+        expect(demongoized).to be_nil
       end
     end
   end
@@ -126,10 +128,12 @@
 
       context "when the string is non numerical" do
 
-        it "return 0" do
-          expect do
-            Float.mongoize("foo")
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        let(:mongoized) do
+          Float.mongoize("foo")
+        end
+
+        it "returns nil" do
+          expect(mongoized).to be_nil
         end
       end
 

spec/mongoid/extensions/integer_spec.rb

@@ -111,10 +111,12 @@
 
       context "when the string is non numerical" do
 
-        it "returns 0" do
-          expect do
-            Integer.mongoize("foo")
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        let(:mongoized) do
+          Integer.mongoize("foo")
+        end
+
+        it "returns nil" do
+          expect(mongoized).to be_nil
         end
       end
 

spec/mongoid/extensions/range_spec.rb

@@ -312,10 +312,8 @@
     context 'given a String' do
       let(:range) { '3' }
 
-      it 'raises an error' do
-        expect do
-          subject
-        end.to raise_error(Mongoid::Errors::InvalidValue)
+      it "returns nil" do
+        is_expected.to be_nil
       end
     end
 
@@ -330,10 +328,8 @@
     context "given a hash with no correct fields" do
       let(:range) { { 'min^' => 1, 'max^' => 5, 'exclude_end^' => true} }
 
-      it "raises an error" do
-        expect do
-          subject
-        end.to raise_error(Mongoid::Errors::InvalidValue)
+      it "returns nil" do
+        is_expected.to be_nil
       end
     end
 

spec/mongoid/extensions/time_spec.rb

@@ -163,10 +163,12 @@
 
     context "when string is empty" do
 
-      it "raises an error" do
-        expect do
-          Time.mongoize("")
-        end.to raise_error(Mongoid::Errors::InvalidValue)
+      let(:mongoized) do
+        Time.mongoize("")
+      end
+
+      it "returns nil" do
+        expect(mongoized).to be_nil
       end
     end
 
@@ -191,10 +193,12 @@
 
       context "when the string is an invalid time" do
 
-        it "raises an error" do
-          expect do
-            Time.mongoize("time")
-          end.to raise_error(Mongoid::Errors::InvalidValue)
+        let(:mongoized) do
+          Time.mongoize("time")
+        end
+
+        it "returns nil" do
+          expect(mongoized).to be_nil
         end
       end