MONGOID-5438 Implement local override for i18n parameters (#5427)

* MONGOID-5438 Implement local override for i18n parameters

* MONGOID-5438 get rid of enfore_available_locale changes

* MONGOID-5438 get rid of before alls

* MONGOID-5438 fix tests caused by rspec precedence

* MONGOID-5438 attempt to fix tests when fallbacks disabled

* MONGOID-5438 make fallbacks default to return [self]

* MONGOID-5438 reset fallbacks

* MONGOID-5438 attempt to fix tests

* MONGOID-5438 retry_test

* MONGOID-5438 undefine fallback methods after fallback tests

* MONGOID-5438 add back defaults

* MONGOID-5438 use new macros

* MONGOID-5438 use before and after suite

* MONGOID-5438 update mrss

* MONGOID-5438 remove suite checks

Author: neilshweky

spec/integration/i18n_fallbacks_spec.rb

@@ -3,11 +3,12 @@
 require 'spec_helper'
 
 describe 'i18n fallbacks' do
-  with_i18n_fallbacks
+  require_fallbacks
 
   context 'when fallbacks are enabled with a locale list' do
+    with_default_i18n_configs
+
     before do
-      I18n.default_locale = :en
       I18n.fallbacks[:de] = [ :en ]
     end
 

spec/mongoid/contextual/memory_spec.rb

@@ -522,6 +522,8 @@
       end
 
       context "when getting a localized field" do
+        with_default_i18n_configs
+
         before do
           I18n.locale = :en
           d = Dictionary.create!(description: 'english-text')
@@ -530,10 +532,6 @@
           d.save!
         end
 
-        after do
-          I18n.locale = :en
-        end
-
         let(:criteria) do
           Dictionary.all.tap do |crit|
             crit.documents = [ Dictionary.first ]
@@ -576,17 +574,11 @@
         end
 
         context 'when fallbacks are enabled with a locale list' do
-          with_i18n_fallbacks
+          require_fallbacks
+          with_default_i18n_configs
 
-          around(:all) do |example|
-            prev_fallbacks = I18n.fallbacks.dup
+          before do
             I18n.fallbacks[:he] = [ :en ]
-            example.run
-            I18n.fallbacks = prev_fallbacks
-          end
-
-          after do
-            I18n.locale = :en
           end
 
           let(:distinct) do
@@ -602,6 +594,8 @@
         end
 
         context "when the localized field is embedded" do
+          with_default_i18n_configs
+
           let(:person) do
             p = Passport.new
             I18n.locale = :en
@@ -612,10 +606,6 @@
             Person.create!(passport: p, employer_id: 12345)
           end
 
-          after do
-            I18n.locale = :en
-          end
-
           let(:criteria) do
             Person.where(employer_id: 12345).tap do |crit|
               crit.documents = [ person ]
@@ -1697,6 +1687,7 @@
       end
 
       context 'when plucking a localized field' do
+        with_default_i18n_configs
 
         before do
           I18n.locale = :en
@@ -1706,10 +1697,6 @@
           d.save!
         end
 
-        after do
-          I18n.locale = :en
-        end
-
         let(:criteria) do
           Dictionary.all.tap do |crit|
             crit.documents = [ Dictionary.first ]
@@ -1766,17 +1753,11 @@
         end
 
         context 'when fallbacks are enabled with a locale list' do
-          with_i18n_fallbacks
+          require_fallbacks
+          with_default_i18n_configs
 
-          around(:all) do |example|
-            prev_fallbacks = I18n.fallbacks.dup
+          before do
             I18n.fallbacks[:he] = [ :en ]
-            example.run
-            I18n.fallbacks = prev_fallbacks
-          end
-
-          after do
-            I18n.locale = :en
           end
 
           let(:plucked) do
@@ -1792,6 +1773,8 @@
         end
 
         context "when the localized field is embedded" do
+          with_default_i18n_configs
+
           before do
             p = Passport.new
             I18n.locale = :en
@@ -1802,10 +1785,6 @@
             Person.create!(passport: p, employer_id: 12345)
           end
 
-          after do
-            I18n.locale = :en
-          end
-
           let(:plucked) do
             Person.where(employer_id: 12345).pluck("pass.name").first
           end
@@ -2045,6 +2024,8 @@
     end
 
     context "when tallying a localized field" do
+      with_default_i18n_configs
+
       let(:d1) { Dictionary.new(description: 'en1') }
       let(:d2) { Dictionary.new(description: 'en1') }
       let(:d3) { Dictionary.new(description: 'en1') }
@@ -2106,6 +2087,7 @@
     end
 
     context "when tallying an embedded localized field" do
+      with_default_i18n_configs
 
       let(:person1) { Person.create!(addresses: [ address1a, address1b ]) }
       let(:person2) { Person.create!(addresses: [ address2a, address2b ]) }

spec/mongoid/contextual/mongo_spec.rb

@@ -561,6 +561,8 @@
     end
 
     context "when getting a localized field" do
+      with_default_i18n_configs
+
       before do
         I18n.locale = :en
         d = Dictionary.create!(description: 'english-text')
@@ -660,13 +662,11 @@
       end
 
       context 'when fallbacks are enabled with a locale list' do
-        with_i18n_fallbacks
+        require_fallbacks
+        with_default_i18n_configs
 
-        around(:all) do |example|
-          prev_fallbacks = I18n.fallbacks.dup
+        before do
           I18n.fallbacks[:he] = [ :en ]
-          example.run
-          I18n.fallbacks = prev_fallbacks
         end
 
         let(:distinct) do
@@ -694,6 +694,8 @@
       end
 
       context "when the localized field is embedded" do
+        with_default_i18n_configs
+
         before do
           p = Passport.new
           I18n.locale = :en
@@ -839,6 +841,8 @@
     end
 
     context "when tallying a localized field" do
+      with_default_i18n_configs
+
       before do
         I18n.locale = :en
         d1 = Dictionary.create!(description: 'en1')
@@ -893,6 +897,7 @@
     end
 
     context "when tallying an embedded localized field" do
+      with_default_i18n_configs
 
       before do
         I18n.locale = :en

spec/mongoid/copyable_spec.rb

@@ -164,19 +164,15 @@
       end
 
       context "when cloning a document with multiple languages field" do
+        with_default_i18n_configs
 
         before do
-          I18n.enforce_available_locales = false
           I18n.locale = 'pt_BR'
           person.desc = "descrição"
           person.addresses.first.name = "descrição"
           person.save!
         end
 
-        after do
-          I18n.locale = :en
-        end
-
         let!(:from_db) do
           Person.find(person.id)
         end
@@ -212,22 +208,18 @@
       end
 
       context "when cloning a document with polymorphic embedded documents with multiple language field" do
+        with_default_i18n_configs
 
         let!(:shipment_address) do
           person.addresses.build({ shipping_name: "Title" }, ShipmentAddress)
         end
 
         before do
-          I18n.enforce_available_locales = false
           I18n.locale = 'pt_BR'
           person.addresses.type(ShipmentAddress).each { |address| address.shipping_name = "Título" }
           person.save!
         end
 
-        after do
-          I18n.locale = :en
-        end
-
         let!(:from_db) do
           Person.find(person.id)
         end

spec/mongoid/criteria/queryable/options_spec.rb

@@ -221,6 +221,7 @@ def localized?
         end
 
         context "when the serializer is localized" do
+          with_default_i18n_configs
 
           before(:all) do
             class Field
@@ -232,7 +233,6 @@ def localized?
 
           after(:all) do
             Object.send(:remove_const, :Field)
-            ::I18n.locale = :en
           end
 
           let(:options) do

spec/mongoid/criteria/queryable/selector_spec.rb

@@ -608,6 +608,7 @@ def localized?
         end
 
         context "when the serializer is localized" do
+          with_default_i18n_configs
 
           before(:all) do
             class Field
@@ -623,7 +624,6 @@ def localized?
 
           after(:all) do
             Object.send(:remove_const, :Field)
-            ::I18n.locale = :en
           end
 
           let(:selector) do

spec/mongoid/criteria_projection_spec.rb

@@ -154,6 +154,7 @@
     end
 
     context 'when the field is localized' do
+      with_default_i18n_configs
 
       before do
         I18n.locale = :en
@@ -163,10 +164,6 @@
         d.save!
       end
 
-      after do
-        I18n.locale = :en
-      end
-
       context 'when entire field is included' do
 
         let(:dictionary) do

spec/mongoid/criteria_spec.rb

@@ -1953,6 +1953,7 @@
     end
 
     context 'when plucking a localized field' do
+      with_default_i18n_configs
 
       before do
         I18n.locale = :en
@@ -1962,10 +1963,6 @@
         d.save!
       end
 
-      after do
-        I18n.locale = :en
-      end
-
       context 'when plucking the entire field' do
         let(:plucked) do
           Dictionary.all.pluck(:description)
@@ -2059,13 +2056,10 @@
       end
 
       context 'when fallbacks are enabled with a locale list' do
-        with_i18n_fallbacks
+        require_fallbacks
 
-        around(:all) do |example|
-          prev_fallbacks = I18n.fallbacks.dup
+        before do
           I18n.fallbacks[:he] = [ :en ]
-          example.run
-          I18n.fallbacks = prev_fallbacks
         end
 
         let(:plucked) do
@@ -2093,6 +2087,8 @@
       end
 
       context "when the localized field is embedded" do
+        with_default_i18n_configs
+
         before do
           p = Passport.new
           I18n.locale = :en