MONGOID-5888 Ensure deeply nested children are validated correctly #6028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comandeo-mongo
approved these changes
Aug 19, 2025
jamis
added a commit
to jamis/mongoid
that referenced
this pull request
Aug 20, 2025
…ongodb#6028) * MONGOID-5888 make sure nested attributes trigger validations on deeply nested children * code review feedback
jamis
added a commit
that referenced
this pull request
Aug 21, 2025
…6028) (#6029) * MONGOID-5888 make sure nested attributes trigger validations on deeply nested children * code review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #6012 (MONGOID-5848, reverting a change that caused a performance regression), validation failures of deeply nested children (i.e. grandchildren and deeper) no longer interrupt the transaction for saving a parent. This PR addresses that by adding a new internal flag (
children_may_have_changed) that thechangedAPI now uses to indicate whether a document should validate it's children or not.The value of that flag is set to true when a child document is processed via nested attributes.