chore: move fake server to utils

Author: durran

test/tools/utils.ts

@@ -463,6 +463,17 @@ export async function makeMultiResponseBatchModelArray(
   return models;
 }
 
+export function fakeServer() {
+  return {
+    s: { state: 'connected' },
+    removeListener: () => true,
+    pool: {
+      checkOut: async () => ({}),
+      checkIn: () => undefined
+    }
+  };
+}
+
 /**
  * A utility to measure the duration of an async function.  This is intended to be used for CSOT
  * testing, where we expect to timeout within a certain threshold and want to measure the duration

test/unit/assorted/server_discovery_and_monitoring.spec.test.ts

@@ -38,7 +38,7 @@ import { Server } from '../../../src/sdam/server';
 import { ServerDescription, type TopologyVersion } from '../../../src/sdam/server_description';
 import { Topology } from '../../../src/sdam/topology';
 import { isRecord, ns, squashError } from '../../../src/utils';
-import { ejson } from '../../tools/utils';
+import { ejson, fakeServer } from '../../tools/utils';
 
 const SDAM_EVENT_CLASSES = {
   ServerDescriptionChangedEvent,
@@ -214,16 +214,7 @@ describe('Server Discovery and Monitoring (spec)', function () {
           .stub(Topology.prototype, 'selectServer')
           .callsFake(async function (_selector, _options) {
             topologySelectServers.restore();
-
-            const fakeServer = {
-              s: { state: 'connected' },
-              removeListener: () => true,
-              pool: {
-                checkOut: async () => ({}),
-                checkIn: () => undefined
-              }
-            };
-            return fakeServer;
+            return fakeServer();
           });
       });
 

test/unit/assorted/server_discovery_and_monitoring.test.ts

@@ -8,6 +8,7 @@ import { Server } from '../../../src/sdam/server';
 import { ServerDescription } from '../../../src/sdam/server_description';
 import { Topology } from '../../../src/sdam/topology';
 import { type TopologyDescription } from '../../../src/sdam/topology_description';
+import { fakeServer } from '../../tools/utils';
 
 describe('Server Discovery and Monitoring', function () {
   let serverConnect: sinon.SinonStub;
@@ -30,16 +31,7 @@ describe('Server Discovery and Monitoring', function () {
       .stub(Topology.prototype, 'selectServer')
       .callsFake(async function (_selector, _options) {
         topologySelectServer.restore();
-
-        const fakeServer = {
-          s: { state: 'connected' },
-          removeListener: () => true,
-          pool: {
-            checkOut: async () => ({}),
-            checkIn: () => undefined
-          }
-        };
-        return fakeServer;
+        return fakeServer();
       });
 
     events = [];

test/unit/assorted/server_selection_spec_helper.js

@@ -9,7 +9,7 @@ const ServerSelectors = require('../../../src/sdam/server_selection');
 
 const sinon = require('sinon');
 const { expect } = require('chai');
-const { topologyWithPlaceholderClient } = require('../../tools/utils');
+const { fakeServer, topologyWithPlaceholderClient } = require('../../tools/utils');
 
 export function serverDescriptionFromDefinition(definition, hosts) {
   hosts = hosts || [];
@@ -105,16 +105,7 @@ export async function executeServerSelectionTest(testDefinition) {
     .stub(Topology.prototype, 'selectServer')
     .callsFake(async function () {
       topologySelectServers.restore();
-
-      const fakeServer = {
-        s: { state: 'connected' },
-        removeListener: () => true,
-        pool: {
-          checkOut: async () => ({}),
-          checkIn: () => undefined
-        }
-      };
-      return fakeServer;
+      return fakeServer();
     });
 
   await topology.connect();