Skip to content

Commit 14025aa

Browse files
committed
chore: try with existing cursor logic
1 parent 07ab153 commit 14025aa

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

src/collection.ts

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -552,6 +552,9 @@ export class Collection<TSchema extends Document = Document> {
552552
options: Omit<FindOneOptions, ''> & Abortable = {}
553553
): Promise<WithId<TSchema> | null> {
554554
const opts = { ...options };
555+
// Explicitly set the limit to 1 and singleBatch to true for all commands, per the spec.
556+
// noCursorTimeout must be unset as well as batchSize.
557+
// See: https://github.com/mongodb/specifications/blob/master/source/crud/crud.md#findone-api-details
555558
opts.singleBatch = true;
556559
if (opts.noCursorTimeout != null) {
557560
delete opts.noCursorTimeout;
@@ -561,16 +564,6 @@ export class Collection<TSchema extends Document = Document> {
561564
}
562565
const cursor = this.find(filter, opts).limit(1);
563566
return await cursor.next();
564-
//await cursor.close();
565-
//return await executeOperation(
566-
// this.client,
567-
// new FindOneOperation(
568-
// this.s.db,
569-
// this.collectionName,
570-
// filter,
571-
// resolveOptions(this as TODO_NODE_3286, options)
572-
// )
573-
//);
574567
}
575568

576569
/**

test/integration/retryable-reads/retryable_reads.spec.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const UNIMPLEMENTED_APIS = [
1414

1515
const skippedTests = ['collection.listIndexes succeeds after retryable handshake network error'];
1616

17-
describe.only('Retryable Reads (unified)', function () {
17+
describe('Retryable Reads (unified)', function () {
1818
runUnifiedSuite(loadSpecTests(path.join('retryable-reads', 'unified')), ({ description }) => {
1919
for (const apiName of UNIMPLEMENTED_APIS) {
2020
if (description.toLowerCase().includes(apiName.toLowerCase())) {

0 commit comments

Comments
 (0)