test(NODE-6500): sync UTR isClientError asserts true for network errors tests (#4492)

baileympearson · web-flow · commit 32b3e34e205c · 2025-03-27T13:01:27.000-04:00
diff --git a/test/spec/crud/unified/estimatedDocumentCount.json b/test/spec/crud/unified/estimatedDocumentCount.json
@@ -249,7 +249,7 @@
           "name": "estimatedDocumentCount",
           "object": "collection0",
           "expectError": {
-            "isError": true
+            "isClientError": true
           }
         }
       ],
diff --git a/test/spec/crud/unified/estimatedDocumentCount.yml b/test/spec/crud/unified/estimatedDocumentCount.yml
@@ -130,7 +130,7 @@ tests:
       - name: estimatedDocumentCount
         object: *collection0
         expectError:
-          isError: true
+          isClientError: true
     expectEvents:
       - client: *client0
         events:
diff --git a/test/spec/retryable-reads/unified/estimatedDocumentCount.json b/test/spec/retryable-reads/unified/estimatedDocumentCount.json
@@ -195,7 +195,7 @@
           "object": "collection1",
           "name": "estimatedDocumentCount",
           "expectError": {
-            "isError": true
+            "isClientError": true
           }
         }
       ],
@@ -241,7 +241,7 @@
           "object": "collection0",
           "name": "estimatedDocumentCount",
           "expectError": {
-            "isError": true
+            "isClientError": true
           }
         }
       ],
diff --git a/test/spec/retryable-reads/unified/estimatedDocumentCount.yml b/test/spec/retryable-reads/unified/estimatedDocumentCount.yml
@@ -116,7 +116,7 @@ tests:
         object: *collection1
         name: estimatedDocumentCount
         expectError:
-          isError: true
+          isClientError: true
     expectEvents:
       -
         client: *client1
diff --git a/test/spec/unified-test-format/valid-pass/expectedError-isClientError.json b/test/spec/unified-test-format/valid-pass/expectedError-isClientError.json
@@ -0,0 +1,74 @@
+{
+  "description": "expectedError-isClientError",
+  "schemaVersion": "1.3",
+  "runOnRequirements": [
+    {
+      "minServerVersion": "4.0",
+      "topologies": [
+        "single",
+        "replicaset"
+      ]
+    },
+    {
+      "minServerVersion": "4.1.7",
+      "topologies": [
+        "sharded",
+        "load-balanced"
+      ]
+    }
+  ],
+  "createEntities": [
+    {
+      "client": {
+        "id": "client0",
+        "useMultipleMongoses": false
+      }
+    },
+    {
+      "database": {
+        "id": "database0",
+        "client": "client0",
+        "databaseName": "test"
+      }
+    }
+  ],
+  "tests": [
+    {
+      "description": "isClientError considers network errors",
+      "operations": [
+        {
+          "name": "failPoint",
+          "object": "testRunner",
+          "arguments": {
+            "client": "client0",
+            "failPoint": {
+              "configureFailPoint": "failCommand",
+              "mode": {
+                "times": 1
+              },
+              "data": {
+                "failCommands": [
+                  "ping"
+                ],
+                "closeConnection": true
+              }
+            }
+          }
+        },
+        {
+          "name": "runCommand",
+          "object": "database0",
+          "arguments": {
+            "commandName": "ping",
+            "command": {
+              "ping": 1
+            }
+          },
+          "expectError": {
+            "isClientError": true
+          }
+        }
+      ]
+    }
+  ]
+}
diff --git a/test/spec/unified-test-format/valid-pass/expectedError-isClientError.yml b/test/spec/unified-test-format/valid-pass/expectedError-isClientError.yml
@@ -0,0 +1,39 @@
+description: "expectedError-isClientError"
+
+schemaVersion: "1.3"
+
+runOnRequirements:
+  - minServerVersion: "4.0"
+    topologies: [single, replicaset]
+  - minServerVersion: "4.1.7"
+    topologies: [sharded, load-balanced]
+
+createEntities:
+  - client:
+      id: &client0 client0
+      useMultipleMongoses: false
+  - database:
+      id: &database0 database0
+      client: *client0
+      databaseName: &database0Name test
+
+tests:
+  - description: "isClientError considers network errors"
+    operations:
+      - name: failPoint
+        object: testRunner
+        arguments:
+          client: *client0
+          failPoint:
+            configureFailPoint: failCommand
+            mode: { times: 1 }
+            data:
+                failCommands: [ ping ]
+                closeConnection: true
+      - name: runCommand
+        object: *database0
+        arguments:
+          commandName: ping
+          command: { ping: 1 }
+        expectError:
+          isClientError: true

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@`
`249`	`249`	`"name": "estimatedDocumentCount",`
`250`	`250`	`"object": "collection0",`
`251`	`251`	`"expectError": {`
`252`		`- "isError": true`
	`252`	`+ "isClientError": true`
`253`	`253`	`}`
`254`	`254`	`}`
`255`	`255`	`],`
Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@`
`195`	`195`	`"object": "collection1",`
`196`	`196`	`"name": "estimatedDocumentCount",`
`197`	`197`	`"expectError": {`
`198`		`- "isError": true`
	`198`	`+ "isClientError": true`
`199`	`199`	`}`
`200`	`200`	`}`
`201`	`201`	`],`
`@@ -241,7 +241,7 @@`
`241`	`241`	`"object": "collection0",`
`242`	`242`	`"name": "estimatedDocumentCount",`
`243`	`243`	`"expectError": {`
`244`		`- "isError": true`
	`244`	`+ "isClientError": true`
`245`	`245`	`}`
`246`	`246`	`}`
`247`	`247`	`],`
Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ tests:`
`116`	`116`	`object: *collection1`
`117`	`117`	`name: estimatedDocumentCount`
`118`	`118`	`expectError:`
`119`		`- isError: true`
	`119`	`+ isClientError: true`
`120`	`120`	`expectEvents:`
`121`	`121`	`-`
`122`	`122`	`client: *client1`