Skip to content

Commit 412829f

Browse files
baileympearsonbaileympearson
committed
comments pt 3
1 parent 8e20e0c commit 412829f

File tree

7 files changed

+9
-13
lines changed

7 files changed

+9
-13
lines changed

‎.evergreen/config.in.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ functions:
376376
MONGODB_URI: ${MONGODB_URI}
377377
binary: bash
378378
args:
379-
- "${PROJECT_DIRECTORY}/.evergreen/run-resource-management-smoke-tests.sh"
379+
- "${PROJECT_DIRECTORY}/.evergreen/run-resource-management-feature-integration.sh"
380380

381381
"compile driver":
382382
- command: subprocess.exec

‎.evergreen/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ functions:
338338
MONGODB_URI: ${MONGODB_URI}
339339
binary: bash
340340
args:
341-
- ${PROJECT_DIRECTORY}/.evergreen/run-resource-management-smoke-tests.sh
341+
- ${PROJECT_DIRECTORY}/.evergreen/run-resource-management-feature-integration.sh
342342
compile driver:
343343
- command: subprocess.exec
344344
type: test

‎.evergreen/run-resource-management-smoke-tests.sh renamed to ‎.evergreen/run-resource-management-feature-integration.sh

File renamed without changes.

‎test/explicit-resource-management/main.test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ async function setUpCollection(client: MongoClient) {
1414
return collection;
1515
}
1616

17-
describe('explicit resource management smoke tests', function () {
17+
describe('explicit resource management feature integration tests', function () {
1818
describe('MongoClient', function () {
1919
it('does not crash or error when used with await-using syntax', async function () {
2020
await using client = new MongoClient(process.env.MONGODB_URI!);
@@ -31,8 +31,6 @@ describe('explicit resource management smoke tests', function () {
3131

3232
await using cursor = collection.find();
3333
await cursor.next();
34-
await cursor.next();
35-
await cursor.next();
3634
})
3735

3836
describe('cursor streams', function() {

‎test/explicit-resource-management/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,7 @@
1515
"@types/chai": "^4.3.16",
1616
"chai": "^4.4.1",
1717
"mongodb": "../../mongodb-current.tgz",
18-
"tslib": "^2.6.3"
19-
},
20-
"devDependencies": {
18+
"tslib": "^2.6.3",
2119
"mocha": "^10.7.0",
2220
"typescript": "5.5"
2321
}

‎test/manual/resource_management.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ describe('Symbol.asyncDispose implementation tests', function () {
1919
});
2020

2121
describe('MongoClient', function () {
22-
it('closes the the client', async function () {
22+
it('the Symbol.asyncDispose method calls close()', async function () {
2323
client = new MongoClient('mongodb://localhost:27017');
2424

2525
const spy = sinon.spy(client, 'close');
@@ -29,7 +29,7 @@ describe('Symbol.asyncDispose implementation tests', function () {
2929
});
3030

3131
describe('ClientSession', function () {
32-
it('ends the session', async function () {
32+
it('the Symbol.asyncDispose method calls endSession()', async function () {
3333
client = new MongoClient('mongodb://localhost:27017');
3434
const session = client.startSession();
3535

@@ -40,7 +40,7 @@ describe('Symbol.asyncDispose implementation tests', function () {
4040
});
4141

4242
describe('ChangeStreams', function () {
43-
it('closes the change stream', async function () {
43+
it('the Symbol.asyncDispose method calls close()', async function () {
4444
client = new MongoClient('mongodb://localhost:27017');
4545
const changeStream = client.watch();
4646

@@ -51,7 +51,7 @@ describe('Symbol.asyncDispose implementation tests', function () {
5151
});
5252

5353
describe('cursors', function () {
54-
it('closes the cursor', async function () {
54+
it('the Symbol.asyncDispose method calls close()', async function () {
5555
client = new MongoClient('mongodb://localhost:27017');
5656
const cursor = client.db('foo').collection('bar').find();
5757

‎test/readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Below is a summary of the types of test automation in this repo.
3232
| TypeScript Definition | `/test/types` | The TypeScript definition tests verify the type definitions are correct. | `npm run check:tsd` |
3333
| GitHub Actions | `/test/action` | Tests that run as GitHub Actions such as dependency checking. | Currently, only `npm run check:dependencies` but could be expanded to more in the future. |
3434
| Code Examples | `/test/integration/node-specific/examples` | Code examples that are also paired with tests that show they are working examples. | Currently, `npm run check:lambda` to test the AWS Lambda example with default auth and `npm run check:lambda:aws` to test the AWS Lambda example with AWS auth. |
35-
| Explicit Resource Management | `/test/integration/explicit-resource-management` | Tests that use explicit resource management with the drivers' disposable resources. | `bash .evergreen/run-resource-management-smoke-test.sh` |
35+
| Explicit Resource Management | `/test/integration/explicit-resource-management` | Tests that use explicit resource management with the driver's disposable resources. | `bash .evergreen/run-resource-management-feature-integration.sh` |
3636

3737
### Spec Tests
3838

0 commit comments

Comments
 (0)