fix(NODE-6377): Remove noResponse option

temp

temp2

Author: aditi-khare-mongoDB

src/cmap/connection.ts

@@ -81,7 +81,6 @@ export interface CommandOptions extends BSONSerializeOptions {
   /** Session to use for the operation */
   session?: ClientSession;
   documentsReturnedIn?: string;
-  noResponse?: boolean;
   omitReadPreference?: boolean;
 
   // TODO(NODE-2802): Currently the CommandOptions take a property willRetryWrite which is a hint
@@ -94,6 +93,9 @@ export interface CommandOptions extends BSONSerializeOptions {
   writeConcern?: WriteConcern;
 
   directConnection?: boolean;
+
+  // Triggers fire-and-forget protocol for commands that don't support WriteConcern
+  moreToCome?: boolean;
 }
 
 /** @public */
@@ -439,7 +441,7 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
         zlibCompressionLevel: this.description.zlibCompressionLevel
       });
 
-      if (options.noResponse || message.moreToCome) {
+      if (message.moreToCome) {
         yield MongoDBResponse.empty;
         return;
       }
@@ -527,11 +529,7 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
             new CommandSucceededEvent(
               this,
               message,
-              options.noResponse
-                ? undefined
-                : message.moreToCome
-                  ? { ok: 1 }
-                  : (object ??= document.toObject(bsonOptions)),
+              message.moreToCome ? { ok: 1 } : (object ??= document.toObject(bsonOptions)),
               started,
               this.description.serverConnectionId
             )

src/mongo_client.ts

@@ -628,7 +628,7 @@ export class MongoClient extends TypedEventEmitter<MongoClientEvents> implements
             this,
             new RunAdminCommandOperation(
               { endSessions },
-              { readPreference: ReadPreference.primaryPreferred, noResponse: true }
+              { readPreference: ReadPreference.primaryPreferred, moreToCome: true }
             )
           );
         } catch (error) {

src/operations/command.ts

@@ -55,7 +55,6 @@ export interface CommandOperationOptions
   // Admin command overrides.
   dbName?: string;
   authdb?: string;
-  noResponse?: boolean;
 }
 
 /** @internal */

src/operations/run_command.ts

@@ -5,8 +5,9 @@ import { type TODO_NODE_3286 } from '../mongo_types';
 import type { ReadPreferenceLike } from '../read_preference';
 import type { Server } from '../sdam/server';
 import type { ClientSession } from '../sessions';
+import type { WriteConcern } from '../write_concern';
 import { MongoDBNamespace } from '../utils';
-import { AbstractOperation } from './operation';
+import { Aspect, defineAspects, AbstractOperation } from './operation';
 
 /** @public */
 export type RunCommandOptions = {
@@ -51,7 +52,7 @@ export class RunAdminCommandOperation<T = Document> extends AbstractOperation<T>
   constructor(
     public command: Document,
     public override options: RunCommandOptions & {
-      noResponse?: boolean;
+      moreToCome?: boolean;
       bypassPinningCheck?: boolean;
     }
   ) {
@@ -72,4 +73,4 @@ export class RunAdminCommandOperation<T = Document> extends AbstractOperation<T>
     });
     return res;
   }
-}
+}

test/integration/connection-monitoring-and-pooling/connection.test.ts

@@ -144,6 +144,21 @@ describe('Connection', function () {
         }
       }
     });
+
+    it('supports fire-and-forget messages', async function () {
+      const options: ConnectionOptions = {
+        ...commonConnectOptions,
+        connectionType: Connection,
+        ...this.configuration.options,
+        metadata: makeClientMetadata({ driverInfo: {} }),
+        extendedMetadata: addContainerMetadata(makeClientMetadata({ driverInfo: {} }))
+      };
+
+      const conn = await connect(options);
+      const readSpy = sinon.spy(conn, 'readMany');
+      await conn.command(ns('$admin.cmd'), { ping: 1 }, { moreToCome: true });
+      expect(readSpy).to.not.have.been.called;
+    });
   });
 
   describe('Connection - functional', function () {

test/integration/node-specific/mongo_client.test.ts

@@ -682,7 +682,7 @@ describe('class MongoClient', function () {
       expect(result2).to.have.property('ok', 1);
     });
 
-    it('sends endSessions with noResponse set', async () => {
+    it('sends endSessions with writeConcern w = 0 set', async () => {
       const session = client.startSession(); // make a session to be ended
       await client.db('test').command({ ping: 1 }, { session });
       await session.endSession();
@@ -698,7 +698,7 @@ describe('class MongoClient', function () {
       expect(startedEvents).to.have.lengthOf(1);
       expect(startedEvents[0]).to.have.property('commandName', 'endSessions');
       expect(endEvents).to.have.lengthOf(1);
-      expect(endEvents[0]).to.have.property('reply', undefined); // noReponse: true
+      expect(endEvents[0]).to.containSubset({ reply: { ok: 1 } }); // writeConcern.w = 0
     });
 
     context('when server selection would return no servers', () => {

test/unit/cmap/connection.test.ts

@@ -28,29 +28,6 @@ describe('new Connection()', function () {
 
   before(() => mock.createServer().then(s => (server = s)));
 
-  it('supports fire-and-forget messages', async function () {
-    server.setMessageHandler(request => {
-      const doc = request.document;
-      if (isHello(doc)) {
-        request.reply(mock.HELLO);
-      }
-
-      // black hole all other requests
-    });
-
-    const options = {
-      ...connectionOptionsDefaults,
-      connectionType: Connection,
-      hostAddress: server.hostAddress(),
-      authProviders: new MongoClientAuthProviders()
-    };
-
-    const conn = await connect(options);
-    const readSpy = sinon.spy(conn, 'readMany');
-    await conn.command(ns('$admin.cmd'), { ping: 1 }, { noResponse: true });
-    expect(readSpy).to.not.have.been.called;
-  });
-
   it('destroys streams which time out', async function () {
     server.setMessageHandler(request => {
       const doc = request.document;