NODE-483 TypeError exception when server.lastIsMaster() returns null

Author: christkv

lib/db.js

@@ -282,13 +282,13 @@ Db.prototype.close = function(force, callback) {
       // Fire close on all children
       for(var i = 0; i < this.s.children.length; i++) {
         this.s.children[i].emit('close');
-      }      
+      }
     }
 
     // Remove listeners after emit
-    self.removeAllListeners('close');    
+    self.removeAllListeners('close');
   }
-  
+
   // Close parent db if set
   if(this.s.parentDb) this.s.parentDb.close();
   // Callback after next event loop tick
@@ -823,17 +823,17 @@ Db.prototype.db = function(dbName) {
 
   // Keep reference to the object
   // if(this.s.parentDb) {
-    // this.s.parentDb.s.children.push(db); 
-    this.addChild(db);    
-  // } 
+    // this.s.parentDb.s.children.push(db);
+    this.addChild(db);
+  // }
   // this.s.children.push(db);
 
   // // Add listeners to the parent database
   // this.once('error', createListener(this, 'error', db));
   // this.once('timeout', createListener(this, 'timeout', db));
   // this.once('close', createListener(this, 'close', db));
   // this.once('parseError', createListener(this, 'parseError', db));
-  
+
   // Return the database
   return db;
 };

lib/mongos.js

@@ -14,7 +14,7 @@ var EventEmitter = require('events').EventEmitter
 /**
  * @fileOverview The **Mongos** class is a class that represents a Mongos Proxy topology and is
  * used to construct connections.
- * 
+ *
  * **Mongos Should not be used, use MongoClient.connect**
  * @example
  * var Db = require('mongodb').Db,
@@ -39,17 +39,17 @@ var EventEmitter = require('events').EventEmitter
  * @param {booelan} [options.ha=true] Turn on high availability monitoring.
  * @param {number} [options.haInterval=5000] Time between each replicaset status check.
  * @param {number} [options.poolSize=5] Number of connections in the connection pool for each server instance, set to 5 as default for legacy reasons.
- * @param {boolean} [options.ssl=false] Use ssl connection (needs to have a mongod server with ssl support) 
+ * @param {boolean} [options.ssl=false] Use ssl connection (needs to have a mongod server with ssl support)
  * @param {object} [options.sslValidate=true] Validate mongod server certificate against ca (needs to have a mongod server with ssl support, 2.4 or higher)
  * @param {array} [options.sslCA=null] Array of valid certificates either as Buffers or Strings (needs to have a mongod server with ssl support, 2.4 or higher)
  * @param {(Buffer|string)} [options.sslCert=null] String or buffer containing the certificate we wish to present (needs to have a mongod server with ssl support, 2.4 or higher)
  * @param {(Buffer|string)} [options.sslKey=null] String or buffer containing the certificate private key we wish to present (needs to have a mongod server with ssl support, 2.4 or higher)
  * @param {(Buffer|string)} [options.sslPass=null] String or buffer containing the certificate password (needs to have a mongod server with ssl support, 2.4 or higher)
- * @param {object} [options.socketOptions=null] Socket options 
- * @param {boolean} [options.socketOptions.noDelay=true] TCP Socket NoDelay option. 
- * @param {number} [options.socketOptions.keepAlive=0] TCP KeepAlive on the socket with a X ms delay before start. 
- * @param {number} [options.socketOptions.connectTimeoutMS=0] TCP Connection timeout setting 
- * @param {number} [options.socketOptions.socketTimeoutMS=0] TCP Socket timeout setting 
+ * @param {object} [options.socketOptions=null] Socket options
+ * @param {boolean} [options.socketOptions.noDelay=true] TCP Socket NoDelay option.
+ * @param {number} [options.socketOptions.keepAlive=0] TCP KeepAlive on the socket with a X ms delay before start.
+ * @param {number} [options.socketOptions.connectTimeoutMS=0] TCP Connection timeout setting
+ * @param {number} [options.socketOptions.socketTimeoutMS=0] TCP Socket timeout setting
  * @fires Mongos#connect
  * @fires Mongos#ha
  * @fires Mongos#joined
@@ -98,7 +98,7 @@ var Mongos = function(servers, options) {
   var finalOptions = shallowClone(options);
 
   // Default values
-  finalOptions.size = typeof options.poolSize == 'number' ? options.poolSize : 5;  
+  finalOptions.size = typeof options.poolSize == 'number' ? options.poolSize : 5;
   finalOptions.reconnect = typeof options.auto_reconnect == 'boolean' ? options.auto_reconnect : true;
   finalOptions.emitError = typeof options.emitError == 'boolean' ? options.emitError : true;
   finalOptions.cursorFactory = Cursor;
@@ -114,7 +114,7 @@ var Mongos = function(servers, options) {
     }
     if(options.socketOptions.socketTimeoutMS)
       finalOptions.socketTimeout = options.socketOptions.socketTimeoutMS;
-  } 
+  }
 
   // Are we running in debug mode
   var debug = typeof options.debug == 'boolean' ? options.debug : false;
@@ -189,9 +189,9 @@ var Mongos = function(servers, options) {
   });
 
   // BSON property
-  Object.defineProperty(this, 'bson', { 
-    enumerable: true, get: function() { 
-      return self.s.mongos.bson; 
+  Object.defineProperty(this, 'bson', {
+    enumerable: true, get: function() {
+      return self.s.mongos.bson;
     }
   });
 
@@ -230,7 +230,7 @@ Mongos.prototype.connect = function(db, _options, callback) {
       // Try to callback
       try {
         callback(err);
-      } catch(err) { 
+      } catch(err) {
         process.nextTick(function() { throw err; })
       }
     }
@@ -276,14 +276,14 @@ Mongos.prototype.connect = function(db, _options, callback) {
     self.s.mongos.on('fullsetup', relay('fullsetup'));
 
     // Emit open event
-    self.emit('open', null, self);      
+    self.emit('open', null, self);
 
     // Return correctly
     try {
       callback(null, self);
-    } catch(err) { 
+    } catch(err) {
       process.nextTick(function() { throw err; })
-    }      
+    }
   }
 
   // Set up listeners
@@ -305,6 +305,7 @@ Mongos.prototype.parserType = function() {
 // Server capabilities
 Mongos.prototype.capabilities = function() {
   if(this.s.sCapabilities) return this.s.sCapabilities;
+  if(this.s.mongos.lastIsMaster() == null) throw new MongoError('cannot establish topology capabilities as driver is still in process of connecting');
   this.s.sCapabilities = new ServerCapabilities(this.s.mongos.lastIsMaster());
   return this.s.sCapabilities;
 }
@@ -344,7 +345,7 @@ Mongos.prototype.cursor = function(ns, cmd, options) {
 
 Mongos.prototype.setBSONParserType = function(type) {
   return this.s.mongos.setBSONParserType(type);
-}  
+}
 
 Mongos.prototype.lastIsMaster = function() {
   return this.s.mongos.lastIsMaster();
@@ -371,7 +372,7 @@ Mongos.prototype.auth = function() {
  */
 Mongos.prototype.connections = function() {
   return this.s.mongos.connections();
-}      
+}
 
 /**
  * A mongos connect event, used to verify that the connection is up and running

lib/replset.js

@@ -19,7 +19,7 @@ var EventEmitter = require('events').EventEmitter
 /**
  * @fileOverview The **ReplSet** class is a class that represents a Replicaset topology and is
  * used to construct connections.
- * 
+ *
  * **ReplSet Should not be used, use MongoClient.connect**
  * @example
  * var Db = require('mongodb').Db,
@@ -44,20 +44,20 @@ var EventEmitter = require('events').EventEmitter
  * @param {booelan} [options.ha=true] Turn on high availability monitoring.
  * @param {number} [options.haInterval=5000] Time between each replicaset status check.
  * @param {string} options.replicaSet The name of the replicaset to connect to.
- * @param {number} [options.secondaryAcceptableLatencyMS=15] Sets the range of servers to pick when using NEAREST (lowest ping ms + the latency fence, ex: range of 1 to (1 + 15) ms) 
+ * @param {number} [options.secondaryAcceptableLatencyMS=15] Sets the range of servers to pick when using NEAREST (lowest ping ms + the latency fence, ex: range of 1 to (1 + 15) ms)
  * @param {boolean} [options.connectWithNoPrimary=false] Sets if the driver should connect even if no primary is available
  * @param {number} [options.poolSize=5] Number of connections in the connection pool for each server instance, set to 5 as default for legacy reasons.
- * @param {boolean} [options.ssl=false] Use ssl connection (needs to have a mongod server with ssl support) 
+ * @param {boolean} [options.ssl=false] Use ssl connection (needs to have a mongod server with ssl support)
  * @param {object} [options.sslValidate=true] Validate mongod server certificate against ca (needs to have a mongod server with ssl support, 2.4 or higher)
  * @param {array} [options.sslCA=null] Array of valid certificates either as Buffers or Strings (needs to have a mongod server with ssl support, 2.4 or higher)
  * @param {(Buffer|string)} [options.sslCert=null] String or buffer containing the certificate we wish to present (needs to have a mongod server with ssl support, 2.4 or higher)
  * @param {(Buffer|string)} [options.sslKey=null] String or buffer containing the certificate private key we wish to present (needs to have a mongod server with ssl support, 2.4 or higher)
  * @param {(Buffer|string)} [options.sslPass=null] String or buffer containing the certificate password (needs to have a mongod server with ssl support, 2.4 or higher)
- * @param {object} [options.socketOptions=null] Socket options 
- * @param {boolean} [options.socketOptions.noDelay=true] TCP Socket NoDelay option. 
- * @param {number} [options.socketOptions.keepAlive=0] TCP KeepAlive on the socket with a X ms delay before start. 
- * @param {number} [options.socketOptions.connectTimeoutMS=0] TCP Connection timeout setting 
- * @param {number} [options.socketOptions.socketTimeoutMS=0] TCP Socket timeout setting 
+ * @param {object} [options.socketOptions=null] Socket options
+ * @param {boolean} [options.socketOptions.noDelay=true] TCP Socket NoDelay option.
+ * @param {number} [options.socketOptions.keepAlive=0] TCP KeepAlive on the socket with a X ms delay before start.
+ * @param {number} [options.socketOptions.connectTimeoutMS=0] TCP Connection timeout setting
+ * @param {number} [options.socketOptions.socketTimeoutMS=0] TCP Socket timeout setting
  * @fires ReplSet#connect
  * @fires ReplSet#ha
  * @fires ReplSet#joined
@@ -70,7 +70,7 @@ var EventEmitter = require('events').EventEmitter
  * @fires ReplSet#parseError
  * @return {ReplSet} a ReplSet instance.
  */
-var ReplSet = function(servers, options) {  
+var ReplSet = function(servers, options) {
   if(!(this instanceof ReplSet)) return new ReplSet(servers, options);
   options = options || {};
   var self = this;
@@ -105,7 +105,7 @@ var ReplSet = function(servers, options) {
   // Final options
   var finalOptions = shallowClone(options);
 
-  // Default values  
+  // Default values
   finalOptions.size = typeof options.poolSize == 'number' ? options.poolSize : 5;
   finalOptions.reconnect = typeof options.auto_reconnect == 'boolean' ? options.auto_reconnect : true;
   finalOptions.emitError = typeof options.emitError == 'boolean' ? options.emitError : true;
@@ -120,11 +120,11 @@ var ReplSet = function(servers, options) {
       this.connectTimeoutMS = options.socketOptions.connectTimeoutMS;
       finalOptions.connectionTimeout = options.socketOptions.connectTimeoutMS;
     }
-    
+
     if(options.socketOptions.socketTimeoutMS) {
       finalOptions.socketTimeout = options.socketOptions.socketTimeoutMS;
     }
-  } 
+  }
 
   // Get the name
   var replicaSet = options.replicaSet || options.rs_name;
@@ -209,13 +209,13 @@ var ReplSet = function(servers, options) {
     // Options
     , options: options
   }
-  
+
   // Debug
   if(debug) {
     // Last ismaster
     Object.defineProperty(this, 'replset', {
       enumerable:true, get: function() { return replset; }
-    });    
+    });
   }
 
   // Last ismaster
@@ -224,9 +224,9 @@ var ReplSet = function(servers, options) {
   });
 
   // BSON property
-  Object.defineProperty(this, 'bson', { 
-    enumerable: true, get: function() { 
-      return replset.bson; 
+  Object.defineProperty(this, 'bson', {
+    enumerable: true, get: function() {
+      return replset.bson;
     }
   });
 
@@ -249,7 +249,7 @@ var translateReadPreference = function(options) {
       , options.readPreference.tags);
   }
 
-  return options;  
+  return options;
 }
 
 ReplSet.prototype.parserType = function() {
@@ -304,12 +304,12 @@ ReplSet.prototype.connect = function(db, _options, callback) {
 
     // Relay ha
     var relayHa = function(t, state) {
-      self.emit('ha', t, state);          
+      self.emit('ha', t, state);
 
       if(t == 'start') {
-        self.emit('ha_connect', t, state);          
+        self.emit('ha_connect', t, state);
       } else if(t == 'end') {
-        self.emit('ha_ismaster', t, state);          
+        self.emit('ha_ismaster', t, state);
       }
     }
 
@@ -318,24 +318,24 @@ ReplSet.prototype.connect = function(db, _options, callback) {
     self.s.replset.on('left', relay('left'));
     self.s.replset.on('ping', relay('ping'));
     self.s.replset.on('ha', relayHa);
-    
+
     self.s.replset.on('fullsetup', function(topology) {
       self.emit('fullsetup', null, self);
     });
-    
+
     self.s.replset.on('all', function(topology) {
       self.emit('all', null, self);
     });
 
     // Emit open event
-    self.emit('open', null, self);      
+    self.emit('open', null, self);
 
     // Return correctly
     try {
       callback(null, self);
-    } catch(err) { 
+    } catch(err) {
       process.nextTick(function() { throw err; })
-    }      
+    }
   }
 
   // Error handler
@@ -352,12 +352,12 @@ ReplSet.prototype.connect = function(db, _options, callback) {
       // Try to callback
       try {
         callback(err);
-      } catch(err) { 
+      } catch(err) {
         if(!self.s.replset.isConnected())
           process.nextTick(function() { throw err; })
       }
     }
-  }    
+  }
 
   // Set up listeners
   self.s.replset.once('timeout', connectErrorHandler('timeout'));
@@ -367,11 +367,12 @@ ReplSet.prototype.connect = function(db, _options, callback) {
 
   // Start connection
   self.s.replset.connect(_options);
-}  
+}
 
 // Server capabilities
 ReplSet.prototype.capabilities = function() {
   if(this.s.sCapabilities) return this.s.sCapabilities;
+  if(this.s.replset.lastIsMaster() == null) throw new MongoError('cannot establish topology capabilities as driver is still in process of connecting');
   this.s.sCapabilities = new ServerCapabilities(this.s.replset.lastIsMaster());
   return this.s.sCapabilities;
 }
@@ -404,7 +405,7 @@ ReplSet.prototype.isConnected = function() {
 
 ReplSet.prototype.setBSONParserType = function(type) {
   return this.s.replset.setBSONParserType(type);
-}  
+}
 
 // Insert
 ReplSet.prototype.cursor = function(ns, cmd, options) {
@@ -429,7 +430,7 @@ ReplSet.prototype.close = function(forceClosed) {
   var events = ['timeout', 'error', 'close', 'joined', 'left'];
   events.forEach(function(e) {
     self.removeAllListeners(e);
-  });        
+  });
 }
 
 ReplSet.prototype.auth = function() {
@@ -444,7 +445,7 @@ ReplSet.prototype.auth = function() {
  */
 ReplSet.prototype.connections = function() {
   return this.s.replset.connections();
-}    
+}
 
 /**
  * A replset connect event, used to verify that the connection is up and running
@@ -524,4 +525,4 @@ ReplSet.prototype.connections = function() {
  * @type {object}
  */
 
-module.exports = ReplSet;
+module.exports = ReplSet;

lib/server.js

@@ -297,6 +297,7 @@ Server.prototype.connect = function(db, _options, callback) {
 // Server capabilities
 Server.prototype.capabilities = function() {
   if(this.s.sCapabilities) return this.s.sCapabilities;
+  if(this.s.server.lastIsMaster() == null) throw new MongoError('cannot establish topology capabilities as driver is still in process of connecting');
   this.s.sCapabilities = new ServerCapabilities(this.s.server.lastIsMaster());
   return this.s.sCapabilities;
 }