fix unit tests

Author: baileympearson

.evergreen/config.yml

@@ -4805,6 +4805,7 @@ buildvariants:
       - test-socks5
       - test-socks5-csfle
       - test-socks5-tls
+      - test-snappy-compression
       - test-zstd-1.x-compression
       - test-zstd-2.x-compression
       - test-tls-support-latest
@@ -4863,6 +4864,7 @@ buildvariants:
       - test-socks5
       - test-socks5-csfle
       - test-socks5-tls
+      - test-snappy-compression
       - test-zstd-1.x-compression
       - test-zstd-2.x-compression
       - test-tls-support-latest
@@ -4921,6 +4923,7 @@ buildvariants:
       - test-socks5
       - test-socks5-csfle
       - test-socks5-tls
+      - test-snappy-compression
       - test-zstd-1.x-compression
       - test-zstd-2.x-compression
       - test-tls-support-latest
@@ -5083,6 +5086,7 @@ buildvariants:
       - test-latest-server-v1-api
       - test-socks5
       - test-socks5-tls
+      - test-snappy-compression
       - test-zstd-1.x-compression
       - test-zstd-2.x-compression
       - test-tls-support-latest
@@ -5129,6 +5133,7 @@ buildvariants:
       - test-latest-server-v1-api
       - test-socks5
       - test-socks5-tls
+      - test-snappy-compression
       - test-zstd-1.x-compression
       - test-zstd-2.x-compression
       - test-tls-support-latest
@@ -5175,6 +5180,7 @@ buildvariants:
       - test-latest-server-v1-api
       - test-socks5
       - test-socks5-tls
+      - test-snappy-compression
       - test-zstd-1.x-compression
       - test-zstd-2.x-compression
       - test-tls-support-latest

.evergreen/generate_evergreen_tasks.js

@@ -803,15 +803,6 @@ BUILD_VARIANTS.push({
   tasks: ['.resource-management']
 });
 
-// TODO(NODE-4575): unskip zstd and snappy on node 16
-for (const variant of BUILD_VARIANTS.filter(
-  variant => variant.expansions && [16, 18, 20].includes(variant.expansions.NODE_LTS_VERSION)
-)) {
-  variant.tasks = variant.tasks.filter(
-    name => !['test-snappy-compression'].includes(name)
-  );
-}
-
 // TODO(NODE-4897): Debug socks5 tests on node latest
 for (const variant of BUILD_VARIANTS.filter(
   variant => variant.expansions && ['latest'].includes(variant.expansions.NODE_LTS_VERSION)

test/unit/cmap/wire_protocol/compression.test.ts

@@ -1,3 +1,4 @@
+import * as zstd from '@mongodb-js/zstd';
 import { expect } from 'chai';
 
 import { compress, Compressor, decompress } from '../../../mongodb';
@@ -12,20 +13,8 @@ describe('compression', function () {
 
         it('compresses the data', async function () {
           const data = await compress(options, buffer);
-          const zstdMagicNumber = data.reverse().toString('hex').substring(16, 26);
-          // Zstd magic number first set of bytes is is 0xFD2FB528
-          expect(zstdMagicNumber).to.equal('00fd2fb528');
-        });
-      });
-
-      context('when a level is provided', function () {
-        const options = { agreedCompressor: 'zstd' as const, zlibCompressionLevel: 2 };
-
-        it('compresses the data', async function () {
-          const data = await compress(options, buffer);
-          const zstdMagicNumber = data.reverse().toString('hex').substring(16, 26);
-          // Zstd magic number first set of bytes is is 0xFD2FB528
-          expect(zstdMagicNumber).to.equal('00fd2fb528');
+          // decompress throws if the message is not zstd compresed
+          expect(await zstd.decompress(data)).to.deep.equal(buffer);
         });
       });
     });