test: move core unit tests from core/unit => unit/core

Author: mbroadst

lib/core/uri_parser.js

@@ -335,6 +335,10 @@ function applyAuthExpectations(parsed) {
   const options = parsed.options;
   const authSource = options.authsource || options.authSource;
   if (authSource != null) {
+    if (parsed.auth == null || parsed.auth.username == null) {
+      throw new MongoParseError('Auth source provided without username');
+    }
+
     parsed.auth = Object.assign({}, parsed.auth, { db: authSource });
   }
 
@@ -549,12 +553,20 @@ function parseConnectionString(uri, options, callback) {
     return callback(new MongoParseError('Unescaped at-sign in authority section'));
   }
 
+  if (authorityParts[0] == null || authorityParts[0] === '') {
+    return callback(new MongoParseError('No username provided in authority section'));
+  }
+
   if (authorityParts.length > 1) {
     const authParts = authorityParts.shift().split(':');
     if (authParts.length > 2) {
       return callback(new MongoParseError('Unescaped colon in authority section'));
     }
 
+    if (authParts[0] === '') {
+      return callback(new MongoParseError('Invalid empty username provided'));
+    }
+
     if (!auth.username) auth.username = qs.unescape(authParts[0]);
     if (!auth.password) auth.password = authParts[1] ? qs.unescape(authParts[1]) : null;
   }

test/core/functional/replset_state.test.js

@@ -2,12 +2,13 @@
 
 const expect = require('chai').expect,
   f = require('util').format,
+  p = require('path'),
   fs = require('fs'),
   ObjectId = require('bson').ObjectId,
   ReplSetState = require('../../../lib/core/topologies/replset_state');
 
 describe('ReplicaSet state', function() {
-  const path = f('%s/../spec/server-discovery-and-monitoring/rs', __dirname);
+  const path = p.resolve(__dirname, '../../spec/server-discovery-and-monitoring/rs');
 
   fs
     .readdirSync(path)

test/spec/auth/README.rst

@@ -0,0 +1,53 @@
+==========
+Auth Tests
+==========
+
+The YAML and JSON files in this directory tree are platform-independent tests
+that drivers can use to prove their conformance to the Auth Spec at least with
+respect to connection string URI input.
+
+Drivers should do additional unit testing if there are alternate ways of
+configuring credentials on a client.
+
+Driver must also conduct the prose tests in the Auth Spec test plan section.
+
+Format
+------
+
+Each YAML file contains an object with a single ``tests`` key. This key is an
+array of test case objects, each of which have the following keys:
+
+- ``description``: A string describing the test.
+- ``uri``: A string containing the URI to be parsed.
+- ``valid:`` A boolean indicating if the URI should be considered valid.
+- ``credential``: If null, the credential must not be considered configured for the
+  the purpose of deciding if the driver should authenticate to the topology.  If non-null,
+  it is an object containing one or more of the following properties of a credential:
+
+  - ``username``: A string containing the username. For auth mechanisms
+    that do not utilize a password, this may be the entire ``userinfo`` token
+    from the connection string.
+  - ``password``: A string containing the password.
+  - ``source``: A string containing the authentication database.
+  - ``mechanism``: A string containing the authentication mechanism.  A null value for
+    this key is used to indicate that a mechanism wasn't specified and that mechanism
+    negotiation is required.  Test harnesses should modify the mechanism test as needed
+    to assert this condition.
+  - ``mechanism_properties``: A document containing mechanism-specific properties.  It
+    specifies a subset of properties that must match.  If a key exists in the test data,
+    it must exist with the corresponding value in the credential.  Other values may
+    exist in the credential without failing the test.
+
+If any key is missing, no assertion about that key is necessary.  Except as
+specified explicitly above, if a key is present, but the test value is null,
+the observed value for that key must be uninitialized (whatever that means for
+a given driver and data type).
+
+Implementation notes
+====================
+
+Testing whether a URI is valid or not should simply be a matter of checking
+whether URI parsing (or MongoClient construction) raises an error or exception.
+
+If a credential is configured, its properties must be compared to the
+``credential`` field.