Skip to content

Commit 5dfc742

Browse files
fixups
1 parent 4b8802e commit 5dfc742

File tree

2 files changed

+7
-17
lines changed

2 files changed

+7
-17
lines changed

test/readme.md

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -345,13 +345,6 @@ The following steps will walk you through how to create and test a MongoDB Serve
345345
346346
This script uses aws secrets manager to fetch credentials. Make sure you are logged into AWS and have your profile set correctly.
347347

348-
349-
Use AWS secrets manager to fetch credentials that enable usage of the Atlas API:
350-
351-
```bash
352-
bash ${DRIVERS_TOOLS}/.evergreen/secrets_handling/setup-secrets.sh drivers/serverless
353-
```
354-
355348
1. Run the setup-serverless script:
356349

357350
```bash
@@ -365,12 +358,10 @@ source secrets-export.sh
365358
source serverless.env
366359
```
367360

368-
3. Comment out the line in `.evergreen/run-serverless-tests.sh` that sources `install-dependencies.sh`.
361+
3. Comment out the line in `.evergreen/run-serverless-tests.sh` that sources `install-dependencies.sh` (this downloads node and npm and is only used in CI).
369362

370363
4. Run the `.evergreen/run-serverless-tests.sh` script directly to test serverless instances from your local machine.
371364

372-
> Hint: If the test script fails with an error along the lines of `Uncaught TypeError: Cannot read properties of undefined (reading 'processId')`, ensure you do **not** have the `FAKE_MONGODB_SERVICE_ID` environment variable set.
373-
374365
### Load Balanced
375366

376367
The following steps will walk you through how to start and test a load balancer.

test/tools/runner/config.ts

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import {
1313
type WriteConcernSettings
1414
} from '../../mongodb';
1515
import { getEnvironmentalOptions } from '../utils';
16-
import { ServerlessFilter } from './filters/serverless_filter';
1716

1817
interface ProxyParams {
1918
proxyHost?: string;
@@ -100,7 +99,7 @@ export class TestConfiguration {
10099
this.parameters = { ...context.parameters };
101100
this.singleMongosLoadBalancerUri = context.singleMongosLoadBalancerUri;
102101
this.multiMongosLoadBalancerUri = context.multiMongosLoadBalancerUri;
103-
this.isServerless = !!ServerlessFilter.isServerless;
102+
this.isServerless = !!process.env.SERVERLESS;
104103
this.topologyType = this.isLoadBalanced ? TopologyType.LoadBalanced : context.topologyType;
105104
this.buildInfo = context.buildInfo;
106105
this.serverApi = context.serverApi;
@@ -118,11 +117,11 @@ export class TestConfiguration {
118117
replicaSet: url.searchParams.get('replicaSet'),
119118
proxyURIParams: url.searchParams.get('proxyHost')
120119
? {
121-
proxyHost: url.searchParams.get('proxyHost'),
122-
proxyPort: Number(url.searchParams.get('proxyPort')),
123-
proxyUsername: url.searchParams.get('proxyUsername'),
124-
proxyPassword: url.searchParams.get('proxyPassword')
125-
}
120+
proxyHost: url.searchParams.get('proxyHost'),
121+
proxyPort: Number(url.searchParams.get('proxyPort')),
122+
proxyUsername: url.searchParams.get('proxyUsername'),
123+
proxyPassword: url.searchParams.get('proxyPassword')
124+
}
126125
: undefined
127126
};
128127
if (url.username) {

0 commit comments

Comments
 (0)