Skip to content

Commit 65b244e

Browse files
remove unnecessary family specification
1 parent ec82ae9 commit 65b244e

File tree

2 files changed

+8
-18
lines changed

2 files changed

+8
-18
lines changed

test/manual/atlas-data-lake-testing/atlas_data_lake_testing.prose.js

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ describe('Atlas Data Lake - prose', function () {
3131
* If a driver constructs and issues killCursors commands in other ways (e.g. public API), this test MUST be adapted to test all such code paths.
3232
*/
3333
it('1. Test that the driver properly constructs and issues a killCursors command to Atlas Data Lake.', async function () {
34-
// TODO(NODE-4884): once happy eyeballs support is added, we no longer need to set the default dns resolution order for CI
35-
client = new MongoClient('mongodb://mhuser:pencil@localhost', { family: 4 });
34+
client = new MongoClient('mongodb://mhuser:pencil@localhost');
3635
const db = client.db('admin');
3736
await db.command({ killCursors: 'kill_cursor_collection' });
3837
});
@@ -41,8 +40,7 @@ describe('Atlas Data Lake - prose', function () {
4140
* For these tests, create a MongoClient using a valid connection string without auth credentials and execute a ping command.
4241
*/
4342
it('2. Test that the driver can establish a connection with Atlas Data Lake without authentication.', async function () {
44-
// TODO(NODE-4884): once happy eyeballs support is added, we no longer need to set the default dns resolution order for CI
45-
client = new MongoClient('mongodb://localhost', { family: 4 });
43+
client = new MongoClient('mongodb://localhost');
4644
const db = client.db('admin');
4745
await db.command({ ping: 1 });
4846
});
@@ -52,10 +50,7 @@ describe('Atlas Data Lake - prose', function () {
5250
* from the drivers-evergreen-tools ADL configuration and execute a ping command.
5351
*/
5452
it('3a. Test that the driver can establish a connection with Atlas Data Lake with authentication. (SCRAM-SHA-1)', async function () {
55-
// TODO(NODE-4884): once happy eyeballs support is added, we no longer need to set the default dns resolution order for CI
56-
client = new MongoClient('mongodb://mhuser:pencil@localhost?authMechanism=SCRAM-SHA-1', {
57-
family: 4
58-
});
53+
client = new MongoClient('mongodb://mhuser:pencil@localhost?authMechanism=SCRAM-SHA-1');
5954
const db = client.db('admin');
6055
await db.command({ ping: 1 });
6156
await db.command({ killCursors: 'kill_cursor_collection' });
@@ -65,10 +60,7 @@ describe('Atlas Data Lake - prose', function () {
6560
* Repeat the authentication test using SCRAM-SHA-256.
6661
*/
6762
it('3b. Test that the driver can establish a connection with Atlas Data Lake with authentication. (SCRAM-SHA-256)', async function () {
68-
// TODO(NODE-4884): once happy eyeballs support is added, we no longer need to set the default dns resolution order for CI
69-
client = new MongoClient('mongodb://mhuser:pencil@localhost?authMechanism=SCRAM-SHA-256', {
70-
family: 4
71-
});
63+
client = new MongoClient('mongodb://mhuser:pencil@localhost?authMechanism=SCRAM-SHA-256');
7264
const db = client.db('admin');
7365
await db.command({ ping: 1 });
7466
await db.command({ killCursors: 'kill_cursor_collection' });

test/tools/runner/hooks/configuration.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -113,12 +113,10 @@ const testConfigBeforeHook = async function () {
113113
return;
114114
}
115115

116-
const client = new MongoClient(loadBalanced ? SINGLE_MONGOS_LB_URI : MONGODB_URI, {
117-
...getEnvironmentalOptions(),
118-
// TODO(NODE-4884): once happy eyeballs support is added, we no longer need to set
119-
// the default dns resolution order for CI
120-
family: 4
121-
});
116+
const client = new MongoClient(
117+
loadBalanced ? SINGLE_MONGOS_LB_URI : MONGODB_URI,
118+
getEnvironmentalOptions()
119+
);
122120

123121
await client.db('test').command({ ping: 1 });
124122

0 commit comments

Comments
 (0)