chore: undefined error fix

Author: nbbeeken

test/integration/node-specific/client_close.test.ts

@@ -65,10 +65,11 @@ describe('MongoClient.close() Integration', () => {
                 authMechanism: 'MONGODB-OIDC'
               };
               const client = new MongoClient(uri, options);
-              client.connect();
+              const connectPromise = client.connect();
               expect(process.getActiveResourcesInfo()).to.include('FSReqPromise');
               await client.close();
               expect(process.getActiveResourcesInfo()).to.not.include('FSReqPromise');
+              await connectPromise;
             }
           );
         });
@@ -80,6 +81,7 @@ describe('MongoClient.close() Integration', () => {
     describe('Node.js resource: Server Selection Timer', () => {
       describe('after a Topology is created through client.connect()', () => {
         const metadata: MongoDBMetadataUI = { requires: { topology: 'replicaset' } };
+
         it.skip('server selection timers are cleaned up by client.close()', metadata, async () => {
           const run = async function ({ MongoClient, uri, expect, sleep, mongodb, getTimerCount }) {
             const serverSelectionTimeoutMS = 2222;
@@ -160,7 +162,7 @@ describe('MongoClient.close() Integration', () => {
                     const heartbeatFrequencyMS = 2000;
                     const client = new MongoClient('mongodb://fakeUri', { heartbeatFrequencyMS });
                     const willBeHeartbeatFailed = once(client, 'serverHeartbeatFailed');
-                    client.connect();
+                    const connectPromise = client.connect();
                     await willBeHeartbeatFailed;
                     function getMonitorTimer(servers) {
                       for (const [, server] of servers) {
@@ -174,6 +176,8 @@ describe('MongoClient.close() Integration', () => {
                     expect(getMonitorTimer(servers)).to.not.exist;
 
                     expect(getTimerCount()).to.equal(0);
+
+                    await connectPromise;
                   };
                   await runScriptAndGetProcessInfo('timer-heartbeat-failed-monitor', config, run);
                 }

test/integration/node-specific/resource_tracking_script_builder.ts

@@ -174,27 +174,32 @@ export async function runScriptAndGetProcessInfo(
     REPORT_RESOURCE_SCRIPT_PATH,
     func
   );
-  await writeFile(scriptName, scriptContent, { encoding: 'utf8' });
-  const logFile = name + '.logs.txt';
 
+  const logFile = name + '.logs.txt';
   const stdErrFile = 'err.out';
+
+  await unlink(scriptName).catch(() => null);
+  await unlink(logFile).catch(() => null);
+  await unlink(stdErrFile).catch(() => null);
+
+  await writeFile(scriptName, scriptContent, { encoding: 'utf8' });
+
   const script = spawn(process.execPath, [scriptName], {
     stdio: ['ignore', 'ignore', openSync(stdErrFile, 'w')]
   });
 
   const willClose = once(script, 'close');
 
   // make sure the process ended
-  const [exitCode] = await willClose;
+  const [exitCode] = (await willClose) as [number];
 
   // format messages from child process as an object
   const messages = (await readFile(logFile, 'utf-8'))
     .trim()
     .split('\n')
-    .map(line => JSON.parse(line))
-    .reduce((acc, curr) => ({ ...acc, ...curr }), {});
+    .map(line => JSON.parse(line));
 
-  const stdErrSize = await readFile(stdErrFile, { encoding: 'utf8' });
+  const stdErr = await readFile(stdErrFile, { encoding: 'utf8' });
 
   // delete temporary files
   await unlink(scriptName);
@@ -203,18 +208,23 @@ export async function runScriptAndGetProcessInfo(
 
   // assertions about exit status
   if (exitCode) {
+    const { error } = messages.find(m => m.error != null);
+    expect(error).to.exist;
     const assertionError = new AssertionError(
-      messages.error?.message + '\n\t' + JSON.stringify(messages.error?.resources, undefined, 2)
+      error.message + '\n\t' + JSON.stringify(error.resources, undefined, 2)
     );
-    assertionError.stack = messages.error?.stack + new Error().stack.slice('Error'.length);
+    assertionError.stack = error.stack + new Error().stack.slice('Error'.length);
     throw assertionError;
   }
 
   // assertions about resource status
-  expect(messages.beforeExitHappened).to.be.true;
-  expect(messages.newResources.libuvResources).to.be.empty;
-  expect(messages.newResources.activeResources).to.be.empty;
+  const { beforeExitHappened } = messages.find(m => 'beforeExitHappened' in m);
+  const { newResources } = messages.find(m => 'newResources' in m);
+
+  expect(beforeExitHappened).to.be.true;
+  expect(newResources.libuvResources).to.be.empty;
+  expect(newResources.activeResources).to.be.empty;
 
   // assertion about error output
-  expect(stdErrSize).to.be.empty;
+  expect(stdErr).to.be.empty;
 }

test/tools/fixtures/process_resource_script.in.js

@@ -1,7 +1,7 @@
 'use strict';
 
 /* eslint-disable no-undef */
-/* eslint-disable no-unused-vars */
+
 const driverPath = DRIVER_SOURCE_PATH;
 const func = FUNCTION_STRING;
 const scriptName = SCRIPT_NAME_STRING;
@@ -48,7 +48,6 @@ function getNewLibuvResourceArray() {
    * @param {LibuvResource} resource
    */
   function isNewLibuvResource(resource) {
-    const serverType = ['tcp', 'udp'];
     return (
       !originalReportAddresses.includes(resource.address) && resource.is_referenced // if a resource is unreferenced, it's not keeping the event loop open
     );
@@ -128,10 +127,10 @@ async function main() {
 }
 
 main()
-  .then(() => {})
+  .then(() => null)
   .catch(e => {
     log({ error: { message: e.message, stack: e.stack, resources: getNewResources() } });
-    process.exit(1);
+    process.exit(2);
   });
 
 setTimeout(() => {