fixes

Author: baileympearson

drivers-evergreen-tools

@@ -794,7 +794,7 @@ export class MongoClient extends TypedEventEmitter<MongoClientEvents> implements
             this,
             new RunAdminCommandOperation(
               { endSessions },
-              { readPreference: ReadPreference.primaryPreferred, writeConcern: { w: 0 } }
+              { readPreference: ReadPreference.primaryPreferred, noResponse: true }
             )
           );
         } catch (error) {

src/mongo_client.ts

@@ -262,8 +262,6 @@ export abstract class ModernizedCommandOperation<T> extends ModernizedOperation<
       return decorateWithExplain(command, this.explain);
     }
 
-    console.log(command);
-
     return command;
   }
 }

src/operations/command.ts

@@ -66,6 +66,11 @@ export class DistinctOperation extends ModernizedCommandOperation<any[] | Docume
     if (this.options.comment !== undefined) {
       command.comment = this.options.comment;
     }
+
+    if (this.options.hint != null) {
+      command.hint = this.options.hint;
+    }
+
     return command;
   }
 

src/operations/distinct.ts

@@ -1,3 +1,4 @@
+import { type Abortable } from '..';
 import type { BSONSerializeOptions, Document } from '../bson';
 import { type Connection } from '../cmap/connection';
 import {
@@ -28,7 +29,8 @@ export type RunCommandOptions = {
   timeoutMS?: number;
   /** @internal */
   omitMaxTimeMS?: boolean;
-} & BSONSerializeOptions;
+} & BSONSerializeOptions &
+  Abortable;
 
 /** @internal */
 export class RunCommandOperation<T = Document> extends ModernizedCommandOperation<T> {
@@ -56,7 +58,7 @@ export class RunCommandOperation<T = Document> extends ModernizedCommandOperatio
   }
 
   override buildOptions(timeoutContext: TimeoutContext): ServerCommandOptions {
-    return { session: this.session, timeoutContext };
+    return { session: this.session, timeoutContext, signal: this.options.signal };
   }
 }
 
@@ -101,13 +103,15 @@ export class RunAdminCommandOperation<T = Document> extends ModernizedCommandOpe
   override options: RunCommandOptions & {
     writeConcern?: WriteConcern;
     bypassPinningCheck?: boolean;
+    noResponse?: boolean;
   };
 
   constructor(
     command: Document,
     options: RunCommandOptions & {
       writeConcern?: WriteConcern;
       bypassPinningCheck?: boolean;
+      noResponse?: boolean;
     }
   ) {
     super(undefined, options);
@@ -125,6 +129,6 @@ export class RunAdminCommandOperation<T = Document> extends ModernizedCommandOpe
   }
 
   override buildOptions(timeoutContext: TimeoutContext): ServerCommandOptions {
-    return { session: this.session, timeoutContext };
+    return { session: this.session, timeoutContext, noResponse: this.options.noResponse };
   }
 }

src/operations/run_command.ts

@@ -8,6 +8,7 @@ import {
   type MongoClient,
   MongoServerError
 } from '../mongodb';
+import { type FailPoint } from '../tools/utils';
 import { assert as test, filterForCommands, setupDatabase } from './shared';
 
 describe('Indexes', function () {
@@ -36,6 +37,19 @@ describe('Indexes', function () {
     expect(response).to.exist;
   });
 
+  it('createIndex() throws an error error when createIndex fails', async function () {
+    await client.db('admin').command(<FailPoint>{
+      configureFailPoint: 'failCommand',
+      mode: { times: 1 },
+      data: {
+        failCommands: ['createIndexes'],
+        errorCode: 10
+      }
+    });
+    const error = await db.createIndex('promiseCollectionCollections1', { a: 1 }).catch(e => e);
+    expect(error).to.be.instanceOf(MongoServerError);
+  });
+
   it('shouldCorrectlyExtractIndexInformation', async function () {
     const collection = await db.createCollection('test_index_information');
     await collection.insertMany([{ a: 1 }], this.configuration.writeConcernMax());

test/integration/index_management.test.ts

@@ -14,49 +14,6 @@ describe('Collection', function () {
     await cleanup();
   });
 
-  context('#createIndex', () => {
-    let client;
-
-    before(function () {
-      client = new MongoClient(`mongodb://${server.uri()}`);
-    });
-
-    after(async function () {
-      await client.close();
-    });
-
-    it('should error when createIndex fails', async function () {
-      const ERROR_RESPONSE = {
-        ok: 0,
-        errmsg:
-          'WiredTigerIndex::insert: key too large to index, failing  1470 { : "56f37cb8e4b089e98d52ab0e", : "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa..." }',
-        code: 17280
-      };
-
-      server.setMessageHandler(request => {
-        const doc = request.document;
-
-        if (isHello(doc)) {
-          return request.reply(Object.assign({}, HELLO));
-        }
-
-        if (doc.createIndexes) {
-          return request.reply(ERROR_RESPONSE);
-        }
-
-        if (doc.insert === 'system.indexes') {
-          return request.reply(ERROR_RESPONSE);
-        }
-      });
-
-      const coll = client.db('foo').collection('bar');
-      const e = await coll.createIndex({ a: 1 }).catch(e => e);
-      expect(e).to.have.property('ok', ERROR_RESPONSE.ok);
-      expect(e).to.have.property('errmsg', ERROR_RESPONSE.errmsg);
-      expect(e).to.have.property('code', ERROR_RESPONSE.code);
-    });
-  });
-
   context('#aggregate', () => {
     // general test for aggregate function
     function testAggregate(config, done) {