NODE-506 What is the proper error handling mechanism for bulk/batch operations?

Author: christkv

HISTORY.md

@@ -1,6 +1,7 @@
 2.0.40 07-14-2015
 -----------------
 - Updated mongodb-core to 1.2.7 for APM support.
+- NODE-506  Ensures that errors from bulk unordered and ordered are instanceof Error (Issue #1282, https://github.com/owenallenaz). 
 
 2.0.39 07-14-2015
 -----------------

lib/bulk/ordered.js

@@ -409,7 +409,7 @@ var executeCommands = function(self, callback) {
     // If we are ordered and have errors and they are
     // not all replication errors terminate the operation
     if(self.s.bulkResult.writeErrors.length > 0) {
-      return callback(self.s.bulkResult.writeErrors[0], new BulkWriteResult(self.s.bulkResult));
+      return callback(toError(self.s.bulkResult.writeErrors[0]), new BulkWriteResult(self.s.bulkResult));
     }
 
     // Execute the next command in line

lib/bulk/unordered.js

@@ -453,7 +453,7 @@ var executeBatches = function(self, callback) {
 				// Driver level error
 				if(error) return callback(error);
 				// Treat write errors
-        var error = self.s.bulkResult.writeErrors.length > 0 ? self.s.bulkResult.writeErrors[0] : null;
+        var error = self.s.bulkResult.writeErrors.length > 0 ? toError(self.s.bulkResult.writeErrors[0]) : null;
         callback(error, new BulkWriteResult(self.s.bulkResult));
       }
     });

test/functional/bulk_tests.js

@@ -82,6 +82,7 @@ exports['Should correctly handle ordered multiple batch api write command error'
         // Execute the operations
         batch.execute(function(err, result) {
           // Basic properties check
+          test.equal(err instanceof Error, true);
           test.equal(1, result.nInserted);
           test.equal(true, result.hasWriteErrors());
           test.ok(1, result.getWriteErrorCount());
@@ -454,6 +455,7 @@ exports['Should correctly handle single unordered batch API'] = {
         // Execute the operations
         batch.execute(function(err, result) {
           // Basic properties check
+          test.equal(err instanceof Error, true);
           test.equal(2, result.nInserted);
           test.equal(0, result.nUpserted);
           test.equal(0, result.nMatched);