requested changes: add in exitCode message, skip unimplemented tests, fix options

Author: aditi-khare-mongoDB

test/integration/node-specific/client_close.test.ts

@@ -1,5 +1,4 @@
 /* eslint-disable @typescript-eslint/no-empty-function */
-
 import { type TestConfiguration } from '../../tools/runner/config';
 import { runScriptAndGetProcessInfo } from './resource_tracking_script_builder';
 
@@ -20,12 +19,14 @@ describe.skip('MongoClient.close() Integration', () => {
           config,
           async function run({ MongoClient, uri, expect }) {
             const infiniteFile = '/dev/zero';
-            const client = new MongoClient(uri, { tlsCertificateKeyFile: infiniteFile });
-            client.connect();
+            const client = new MongoClient(uri, { tls: true, tlsCertificateKeyFile: infiniteFile });
+            const connectPromise = client.connect();
             expect(process.getActiveResourcesInfo()).to.include('FSReqPromise');
             await client.close();
             expect(process.getActiveResourcesInfo()).to.not.include('FSReqPromise');
-          }
+            const err = await connectPromise.catch(e => e);
+            expect(err).to.exist;
+          } 
         );
       });
     });
@@ -74,7 +75,7 @@ describe.skip('MongoClient.close() Integration', () => {
   describe('Topology', () => {
     describe('Node.js resource: Server Selection Timer', () => {
       describe('after a Topology is created through client.connect()', () => {
-        it('server selection timers are cleaned up by client.close()', async () => {});
+        it.skip('server selection timers are cleaned up by client.close()', async () => {});
       });
     });
 
@@ -90,25 +91,25 @@ describe.skip('MongoClient.close() Integration', () => {
         describe('MonitorInterval', () => {
           describe('Node.js resource: Timer', () => {
             describe('after a new monitor is made', () => {
-              it('monitor interval timer is cleaned up by client.close()', async () => {});
+              it.skip('monitor interval timer is cleaned up by client.close()', async () => {});
             });
 
             describe('after a heartbeat fails', () => {
-              it('the new monitor interval timer is cleaned up by client.close()', async () => {});
+              it.skip('the new monitor interval timer is cleaned up by client.close()', async () => {});
             });
           });
         });
 
         describe('Connection Monitoring', () => {
           describe('Node.js resource: Socket', () => {
-            it('no sockets remain after client.close()', metadata, async function () {});
+            it.skip('no sockets remain after client.close()', metadata, async function () {});
           });
         });
 
         describe('RTT Pinger', () => {
           describe('Node.js resource: Timer', () => {
             describe('after entering monitor streaming mode ', () => {
-              it('the rtt pinger timer is cleaned up by client.close()', async () => {
+              it.skip('the rtt pinger timer is cleaned up by client.close()', async () => {
                 // helloReply has a topologyVersion defined
               });
             });
@@ -117,7 +118,7 @@ describe.skip('MongoClient.close() Integration', () => {
           describe('Connection', () => {
             describe('Node.js resource: Socket', () => {
               describe('when rtt monitoring is turned on', () => {
-                it('no sockets remain after client.close()', async () => {});
+                it.skip('no sockets remain after client.close()', async () => {});
               });
             });
           });
@@ -127,25 +128,25 @@ describe.skip('MongoClient.close() Integration', () => {
       describe('ConnectionPool', () => {
         describe('Node.js resource: minPoolSize timer', () => {
           describe('after new connection pool is created', () => {
-            it('the minPoolSize timer is cleaned up by client.close()', async () => {});
+            it.skip('the minPoolSize timer is cleaned up by client.close()', async () => {});
           });
         });
 
         describe('Node.js resource: checkOut Timer', () => {
           // waitQueueTimeoutMS
           describe('after new connection pool is created', () => {
-            it('the wait queue timer is cleaned up by client.close()', async () => {});
+            it.skip('the wait queue timer is cleaned up by client.close()', async () => {});
           });
         });
 
         describe('Connection', () => {
           describe('Node.js resource: Socket', () => {
             describe('after a connection is checked out', () => {
-              it('no sockets remain after client.close()', async () => {});
+              it.skip('no sockets remain after client.close()', async () => {});
             });
 
             describe('after a minPoolSize has been set on the ConnectionPool', () => {
-              it('no sockets remain after client.close()', async () => {});
+              it.skip('no sockets remain after client.close()', async () => {});
             });
           });
         });
@@ -155,7 +156,7 @@ describe.skip('MongoClient.close() Integration', () => {
     describe('SrvPoller', () => {
       describe('Node.js resource: Timer', () => {
         describe('after SRVPoller is created', () => {
-          it('timers are cleaned up by client.close()', async () => {});
+          it.skip('timers are cleaned up by client.close()', async () => {});
         });
       });
     });
@@ -164,27 +165,27 @@ describe.skip('MongoClient.close() Integration', () => {
   describe('ClientSession (Implicit)', () => {
     describe('Server resource: LSID/ServerSession', () => {
       describe('after a clientSession is implicitly created and used', () => {
-        it('the server-side ServerSession is cleaned up by client.close()', async function () {});
+        it.skip('the server-side ServerSession is cleaned up by client.close()', async function () {});
       });
     });
 
     describe('Server resource: Transactions', () => {
       describe('after a clientSession is implicitly created and used', () => {
-        it('the server-side transaction is cleaned up by client.close()', async function () {});
+        it.skip('the server-side transaction is cleaned up by client.close()', async function () {});
       });
     });
   });
 
   describe('ClientSession (Explicit)', () => {
     describe('Server resource: LSID/ServerSession', () => {
       describe('after a clientSession is created and used', () => {
-        it('the server-side ServerSession is cleaned up by client.close()', async function () {});
+        it.skip('the server-side ServerSession is cleaned up by client.close()', async function () {});
       });
     });
 
     describe('Server resource: Transactions', () => {
       describe('after a clientSession is created and used', () => {
-        it('the server-side transaction is cleaned up by client.close()', async function () {});
+        it.skip('the server-side transaction is cleaned up by client.close()', async function () {});
       });
     });
   });
@@ -287,14 +288,14 @@ describe.skip('MongoClient.close() Integration', () => {
       });
 
       describe('Node.js resource: Socket', () => {
-        it('no sockets remain after client.close()', metadata, async () => {});
+        it.skip('no sockets remain after client.close()', metadata, async () => {});
       });
     });
   });
 
   describe('Server resource: Cursor', () => {
     describe('after cursors are created', () => {
-      it('all active server-side cursors are closed by client.close()', async function () {});
+      it.skip('all active server-side cursors are closed by client.close()', async function () {});
     });
   });
 });

test/integration/node-specific/resource_tracking_script_builder.ts

@@ -3,7 +3,7 @@ import { on, once } from 'node:events';
 import { readFile, unlink, writeFile } from 'node:fs/promises';
 import * as path from 'node:path';
 
-import { expect } from 'chai';
+import { AssertionError, expect } from 'chai';
 import { parseSnapshot } from 'v8-heapsnapshot';
 
 import { type BSON, type ClientEncryption, type MongoClient } from '../../mongodb';
@@ -187,7 +187,11 @@ export async function runScriptAndGetProcessInfo(
   await unlink(logFile);
 
   // assertions about exit status
-  expect(exitCode, 'process should have exited with zero').to.equal(0);
+  if (exitCode) { 
+    const assertionError = new AssertionError(messages.error.message); 
+    assertionError.stack = messages.error.stack + new Error().stack.slice('Error'.length); 
+    throw assertionError; 
+  }
 
   // assertions about resource status
   expect(messages.beforeExitHappened).to.be.true;

test/tools/fixtures/process_resource_script.in.js

@@ -78,12 +78,14 @@ async function main() {
 main()
   .then(() => {})
   .catch(e => {
-    log({ exitCode: 1, error: util.inspect(e) });
+    log({ exitCode: 1, error: { message: e.message, stack: e.stack } });
   });
 
 setTimeout(() => {
   // this means something was in the event loop such that it hung for more than 10 seconds
   // so we kill the process
+  log({ newLibuvResources: getNewLibuvResourceArray() });
+  log({ exitCode: 99, error: { message: 'Process timed out: resources remain in the event loop.' } });
   process.exit(99);
   // using `unref` will ensure this setTimeout call is not a resource / does not keep the event loop running
 }, 10000).unref();