fix(NODE-6377): Remove noResponse option

Author: aditi-khare-mongoDB

src/cmap/connection.ts

@@ -81,7 +81,6 @@ export interface CommandOptions extends BSONSerializeOptions {
   /** Session to use for the operation */
   session?: ClientSession;
   documentsReturnedIn?: string;
-  noResponse?: boolean;
   omitReadPreference?: boolean;
 
   // TODO(NODE-2802): Currently the CommandOptions take a property willRetryWrite which is a hint
@@ -439,7 +438,7 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
         zlibCompressionLevel: this.description.zlibCompressionLevel
       });
 
-      if (options.noResponse || message.moreToCome) {
+      if (message.moreToCome) {
         yield MongoDBResponse.empty;
         return;
       }
@@ -527,11 +526,7 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
             new CommandSucceededEvent(
               this,
               message,
-              options.noResponse
-                ? undefined
-                : message.moreToCome
-                  ? { ok: 1 }
-                  : (object ??= document.toObject(bsonOptions)),
+              message.moreToCome ? { ok: 1 } : (object ??= document.toObject(bsonOptions)),
               started,
               this.description.serverConnectionId
             )

src/mongo_client.ts

@@ -628,7 +628,7 @@ export class MongoClient extends TypedEventEmitter<MongoClientEvents> implements
             this,
             new RunAdminCommandOperation(
               { endSessions },
-              { readPreference: ReadPreference.primaryPreferred, noResponse: true }
+              { readPreference: ReadPreference.primaryPreferred, writeConcern: { w: 0 } }
             )
           );
         } catch (error) {

src/operations/command.ts

@@ -55,7 +55,6 @@ export interface CommandOperationOptions
   // Admin command overrides.
   dbName?: string;
   authdb?: string;
-  noResponse?: boolean;
 }
 
 /** @internal */

src/operations/run_command.ts

@@ -5,8 +5,9 @@ import { type TODO_NODE_3286 } from '../mongo_types';
 import type { ReadPreferenceLike } from '../read_preference';
 import type { Server } from '../sdam/server';
 import type { ClientSession } from '../sessions';
+import type { WriteConcern } from '../write_concern';
 import { MongoDBNamespace } from '../utils';
-import { AbstractOperation } from './operation';
+import { Aspect, defineAspects, AbstractOperation } from './operation';
 
 /** @public */
 export type RunCommandOptions = {
@@ -51,7 +52,7 @@ export class RunAdminCommandOperation<T = Document> extends AbstractOperation<T>
   constructor(
     public command: Document,
     public override options: RunCommandOptions & {
-      noResponse?: boolean;
+      writeConcern?: WriteConcern;
       bypassPinningCheck?: boolean;
     }
   ) {
@@ -73,3 +74,7 @@ export class RunAdminCommandOperation<T = Document> extends AbstractOperation<T>
     return res;
   }
 }
+
+defineAspects(RunAdminCommandOperation, [
+  Aspect.WRITE_OPERATION
+]);

test/integration/collection-management/collection.test.ts

@@ -551,15 +551,15 @@ describe('Collection', function () {
     }
   }
 
-  it('isCapped should return false for uncapped collections', async function () {
+  it.only('isCapped should return false for uncapped collections', async function () {
     await testCapped(configuration, {
       config: configuration,
       collName: 'uncapped',
       opts: { capped: false }
     });
   });
 
-  it('isCapped should return false for collections instantiated without specifying capped', async function () {
+  it.only('isCapped should return false for collections instantiated without specifying capped', async function () {
     await testCapped(configuration, { config: configuration, collName: 'uncapped2', opts: {} });
   });
 

test/integration/crud/misc_cursors.test.js

@@ -1496,7 +1496,7 @@ describe('Cursor', function () {
     }
   });
 
-  it('does not auto destroy streams', function (done) {
+  it.only('does not auto destroy streams', function (done) {
     const docs = [];
 
     for (var i = 0; i < 10; i++) {

test/integration/node-specific/mongo_client.test.ts

@@ -682,7 +682,7 @@ describe('class MongoClient', function () {
       expect(result2).to.have.property('ok', 1);
     });
 
-    it('sends endSessions with noResponse set', async () => {
+    it('sends endSessions with writeConcern w = 0 set', async () => {
       const session = client.startSession(); // make a session to be ended
       await client.db('test').command({ ping: 1 }, { session });
       await session.endSession();
@@ -698,7 +698,7 @@ describe('class MongoClient', function () {
       expect(startedEvents).to.have.lengthOf(1);
       expect(startedEvents[0]).to.have.property('commandName', 'endSessions');
       expect(endEvents).to.have.lengthOf(1);
-      expect(endEvents[0]).to.have.property('reply', undefined); // noReponse: true
+      expect(endEvents[0]).to.containSubset({ reply: { ok: 1 } }); // writeConcern.w = 0
     });
 
     context('when server selection would return no servers', () => {

test/integration/read-write-concern/write_concern.test.ts

@@ -15,7 +15,7 @@ import {
 import * as mock from '../../tools/mongodb-mock/index';
 import { filterForCommands } from '../shared';
 
-describe('Write Concern', function () {
+describe.only('Write Concern', function () {
   context('when the WriteConcern is set in the uri', function () {
     let client;
     const events: CommandStartedEvent[] = [];

test/unit/cmap/connection.test.ts

@@ -47,7 +47,7 @@ describe('new Connection()', function () {
 
     const conn = await connect(options);
     const readSpy = sinon.spy(conn, 'readMany');
-    await conn.command(ns('$admin.cmd'), { ping: 1 }, { noResponse: true });
+    await conn.command(ns('$admin.cmd'), { ping: 1 }, { writeConcern: { w: 0 } });
     expect(readSpy).to.not.have.been.called;
   });