Skip to content

Commit afe4936

Browse files
committed
feat(NODE-3922): remove behaviour around ocsp tls options
1 parent bff57ed commit afe4936

File tree

3 files changed

+3
-12
lines changed

3 files changed

+3
-12
lines changed

src/client-side-encryption/state_machine.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,7 @@ const stateToString = new Map([
6868
const INSECURE_TLS_OPTIONS = [
6969
'tlsInsecure',
7070
'tlsAllowInvalidCertificates',
71-
'tlsAllowInvalidHostnames',
72-
73-
// These options are disallowed by the spec, so we explicitly filter them out if provided, even
74-
// though the StateMachine does not declare support for these options.
75-
'tlsDisableOCSPEndpointCheck',
76-
'tlsDisableCertificateRevocationCheck'
71+
'tlsAllowInvalidHostnames'
7772
];
7873

7974
/**

src/connection_string.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,6 @@ function checkTLSOptions(allOptions: CaseInsensitiveMap): void {
172172
};
173173
check('tlsInsecure', 'tlsAllowInvalidCertificates');
174174
check('tlsInsecure', 'tlsAllowInvalidHostnames');
175-
check('tlsInsecure', 'tlsDisableCertificateRevocationCheck');
176-
check('tlsInsecure', 'tlsDisableOCSPEndpointCheck');
177-
check('tlsAllowInvalidCertificates', 'tlsDisableCertificateRevocationCheck');
178-
check('tlsAllowInvalidCertificates', 'tlsDisableOCSPEndpointCheck');
179-
check('tlsDisableCertificateRevocationCheck', 'tlsDisableOCSPEndpointCheck');
180175
}
181176
function getBoolean(name: string, value: unknown): boolean {
182177
if (typeof value === 'boolean') return value;

test/unit/assorted/uri_options.spec.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ describe('URI option spec tests', function () {
1010
// Skipped because this does not apply to Node
1111
'Valid options specific to single-threaded drivers are parsed correctly',
1212

13-
// TODO(NODE-3922): have not implemented option support
13+
// These options are specific to OCSP which the driver does not implement
14+
// and will not be implemented in the future.
1415
'tlsDisableCertificateRevocationCheck can be set to true',
1516
'tlsDisableCertificateRevocationCheck can be set to false',
1617
'tlsDisableOCSPEndpointCheck can be set to true',

0 commit comments

Comments
 (0)