remove NPM_VERSION from ci config; make LATEST_LTS_VERSION required for CI tasks

Author: baileympearson

.evergreen/ci_matrix_constants.js

@@ -1,7 +1,7 @@
 const MONGODB_VERSIONS = ['latest', 'rapid', '8.0', '7.0', '6.0', '5.0', '4.4', '4.2'];
 const versions = [
-  { codeName: 'iron', versionNumber: '20.19.0', npmVersion: 'latest' },
-  { codeName: 'jod', versionNumber: 22, npmVersion: 'latest' }
+  { codeName: 'iron', versionNumber: '20.19.0' },
+  { codeName: 'jod', versionNumber: 22 }
 ];
 const NODE_VERSIONS = versions.map(({ versionNumber }) => versionNumber).sort();
 const LOWEST_LTS = NODE_VERSIONS[0];

.evergreen/config.yml

@@ -1844,7 +1844,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: 20.19.0}
-            - {key: NPM_VERSION, value: latest}
       - func: install dependencies
       - func: run unit tests
   - name: run-unit-tests-node-22
@@ -1856,7 +1855,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: '22'}
-            - {key: NPM_VERSION, value: latest}
       - func: install dependencies
       - func: run unit tests
   - name: run-lint-checks
@@ -1879,7 +1877,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: '22'}
-            - {key: NPM_VERSION, value: '9'}
       - func: install dependencies
       - func: check resource management
   - name: test-explicit-resource-management-feature-integration
@@ -1906,7 +1903,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: 20.19.0}
-            - {key: NPM_VERSION, value: '9'}
             - {key: TS_VERSION, value: next}
             - {key: TYPES_VERSION, value: 22.15.3}
       - func: install dependencies
@@ -1921,7 +1917,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: 20.19.0}
-            - {key: NPM_VERSION, value: '9'}
             - {key: TS_VERSION, value: current}
             - {key: TYPES_VERSION, value: 22.15.3}
       - func: install dependencies
@@ -1936,7 +1931,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: 20.19.0}
-            - {key: NPM_VERSION, value: '9'}
             - {key: TS_VERSION, value: '4.4'}
             - {key: TYPES_VERSION, value: 18.11.9}
       - func: install dependencies
@@ -1951,7 +1945,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: 20.19.0}
-            - {key: NPM_VERSION, value: '9'}
             - {key: TS_VERSION, value: current}
             - {key: TYPES_VERSION, value: 22.15.3}
       - func: install dependencies
@@ -1974,7 +1967,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: 20.19.0}
-            - {key: NPM_VERSION, value: '9'}
             - {key: VERSION, value: '5.0'}
             - {key: TOPOLOGY, value: replica_set}
             - {key: CLIENT_ENCRYPTION, value: 'true'}
@@ -1992,7 +1984,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: 20.19.0}
-            - {key: NPM_VERSION, value: '9'}
             - {key: VERSION, value: rapid}
             - {key: TOPOLOGY, value: replica_set}
             - {key: CLIENT_ENCRYPTION, value: 'true'}
@@ -2010,7 +2001,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: 20.19.0}
-            - {key: NPM_VERSION, value: '9'}
             - {key: VERSION, value: latest}
             - {key: TOPOLOGY, value: replica_set}
             - {key: CLIENT_ENCRYPTION, value: 'true'}
@@ -2028,7 +2018,6 @@ tasks:
         params:
           updates:
             - {key: NODE_LTS_VERSION, value: 20.19.0}
-            - {key: NPM_VERSION, value: '9'}
             - {key: VERSION, value: '7.0'}
             - {key: TOPOLOGY, value: replica_set}
             - {key: CLIENT_ENCRYPTION, value: 'true'}
@@ -2449,7 +2438,7 @@ tasks:
         type: setup
         params:
           updates:
-            - {key: NPM_VERSION, value: '9'}
+            - {key: NODE_LTS_VERSION, value: 20.19.0}
             - {key: VERSION, value: rapid}
             - {key: TOPOLOGY, value: server}
       - func: install dependencies
@@ -2464,7 +2453,7 @@ tasks:
         type: setup
         params:
           updates:
-            - {key: NPM_VERSION, value: '9'}
+            - {key: NODE_LTS_VERSION, value: 20.19.0}
             - {key: VERSION, value: rapid}
             - {key: AUTH, value: auth}
             - {key: ORCHESTRATION_FILE, value: auth-aws.json}
@@ -2874,7 +2863,6 @@ buildvariants:
     run_on: rhel80-large
     expansions:
       NODE_LTS_VERSION: 20.19.0
-      NPM_VERSION: latest
       CLIENT_ENCRYPTION: 'true'
       TEST_CSFLE: 'true'
     tasks:
@@ -2930,7 +2918,6 @@ buildvariants:
     run_on: rhel80-large
     expansions:
       NODE_LTS_VERSION: 22
-      NPM_VERSION: latest
       CLIENT_ENCRYPTION: 'true'
       TEST_CSFLE: 'true'
     tasks:
@@ -3039,7 +3026,6 @@ buildvariants:
     run_on: windows-vsCurrent-large
     expansions:
       NODE_LTS_VERSION: 20.19.0
-      NPM_VERSION: latest
       CLIENT_ENCRYPTION: 'false'
       TEST_CSFLE: 'false'
     tasks:
@@ -3085,7 +3071,6 @@ buildvariants:
     run_on: windows-vsCurrent-large
     expansions:
       NODE_LTS_VERSION: 22
-      NPM_VERSION: latest
       CLIENT_ENCRYPTION: 'false'
       TEST_CSFLE: 'false'
     tasks:
@@ -3133,7 +3118,6 @@ buildvariants:
       CLIENT_ENCRYPTION: true
       RUN_WITH_MONGOCRYPTD: true
       NODE_LTS_VERSION: 20.19.0
-      NPM_VERSION: 9
     tasks:
       - test-latest-csfle-mongocryptd
       - test-rapid-csfle-mongocryptd
@@ -3150,7 +3134,6 @@ buildvariants:
       CLIENT_ENCRYPTION: true
       RUN_WITH_MONGOCRYPTD: true
       NODE_LTS_VERSION: 20.19.0
-      NPM_VERSION: 9
     tasks:
       - test-latest-csfle-mongocryptd
       - test-rapid-csfle-mongocryptd

.evergreen/generate_evergreen_tasks.js

@@ -285,7 +285,7 @@ AWS_LAMBDA_HANDLER_TASKS.push({
   tags: ['latest', 'lambda'],
   commands: [
     updateExpansions({
-      NPM_VERSION: 9,
+      NODE_LTS_VERSION: LOWEST_LTS,
       VERSION: 'rapid',
       TOPOLOGY: 'server'
     }),
@@ -301,7 +301,7 @@ AWS_LAMBDA_HANDLER_TASKS.push({
   tags: ['latest', 'lambda'],
   commands: [
     updateExpansions({
-      NPM_VERSION: 9,
+      NODE_LTS_VERSION: LOWEST_LTS,
       VERSION: 'rapid',
       AUTH: 'auth',
       ORCHESTRATION_FILE: 'auth-aws.json',
@@ -395,10 +395,7 @@ for (const {
     const nodeLtsDisplayName = `Node${NODE_LTS_VERSION}`;
     const name = `${osName}-${NODE_LTS_VERSION >= 20 ? nodeLtsDisplayName : nodeLTSCodeName}`;
     const display_name = `${osDisplayName} ${nodeLtsDisplayName}`;
-    const NPM_VERSION = versions.find(
-      ({ versionNumber }) => versionNumber === NODE_LTS_VERSION
-    ).npmVersion;
-    const expansions = { NODE_LTS_VERSION, NPM_VERSION };
+    const expansions = { NODE_LTS_VERSION };
     const taskNames = tasks.map(({ name }) => name);
 
     expansions.CLIENT_ENCRYPTION = String(!!clientEncryption);
@@ -455,8 +452,7 @@ for (const nodeVersion of [LOWEST_LTS, LATEST_LTS]) {
     expansions: {
       CLIENT_ENCRYPTION: true,
       RUN_WITH_MONGOCRYPTD: true,
-      NODE_LTS_VERSION: LOWEST_LTS,
-      NPM_VERSION: 9
+      NODE_LTS_VERSION: LOWEST_LTS
     },
     tasks: MONGOCRYPTD_CSFLE_TASKS.map(task => task.name)
   });
@@ -475,14 +471,13 @@ BUILD_VARIANTS.push({
 
 const unitTestTasks = Array.from(
   (function* () {
-    for (const { versionNumber: NODE_LTS_VERSION, npmVersion: NPM_VERSION } of versions) {
+    for (const { versionNumber: NODE_LTS_VERSION } of versions) {
       yield {
         name: `run-unit-tests-node-${NODE_LTS_VERSION}`,
         tags: ['unit-tests'],
         commands: [
           updateExpansions({
-            NODE_LTS_VERSION,
-            NPM_VERSION
+            NODE_LTS_VERSION
           }),
           { func: 'install dependencies' },
           { func: 'run unit tests' }
@@ -512,8 +507,7 @@ SINGLETON_TASKS.push(
       tags: ['resource-management'],
       commands: [
         updateExpansions({
-          NODE_LTS_VERSION: LATEST_LTS,
-          NPM_VERSION: 9
+          NODE_LTS_VERSION: LATEST_LTS
         }),
         { func: 'install dependencies' },
         { func: 'check resource management' }
@@ -545,7 +539,6 @@ function* makeTypescriptTasks() {
       commands: [
         updateExpansions({
           NODE_LTS_VERSION: LOWEST_LTS,
-          NPM_VERSION: 9,
           TS_VERSION,
           TYPES_VERSION
         }),
@@ -561,7 +554,6 @@ function* makeTypescriptTasks() {
       commands: [
         updateExpansions({
           NODE_LTS_VERSION: LOWEST_LTS,
-          NPM_VERSION: 9,
           TS_VERSION,
           TYPES_VERSION
         }),
@@ -625,7 +617,6 @@ for (const serverVersion of ['5.0', 'rapid', 'latest']) {
     commands: [
       updateExpansions({
         NODE_LTS_VERSION: LOWEST_LTS,
-        NPM_VERSION: 9,
         VERSION: serverVersion,
         TOPOLOGY: 'replica_set',
         CLIENT_ENCRYPTION: true
@@ -645,7 +636,6 @@ customDependencyTests.push({
   commands: [
     updateExpansions({
       NODE_LTS_VERSION: LOWEST_LTS,
-      NPM_VERSION: 9,
       VERSION: '7.0',
       TOPOLOGY: 'replica_set',
       CLIENT_ENCRYPTION: true

.evergreen/install-dependencies.sh

@@ -5,7 +5,8 @@ set -o errexit  # Exit the script with error if any of the commands fail
 ## a nodejs major version (i.e., 16)
 ## 'latest'
 ## a full nodejs version, in the format v<major>.<minor>.patch
-export NODE_LTS_VERSION=${NODE_LTS_VERSION:-16}
+if [ -z ${NODE_LTS_VERSION+omitted} ]; then echo "NODE_LTS_VERSION is unset" && exit 1; fi
+
 # npm version can be defined in the environment for cases where we need to install
 # a version lower than latest to support EOL Node versions. When not provided will
 # be handled by this script in drivers tools.