NOT providing replSet name in MongoClient connection URI will force single server connection. Fixes issue where it was impossible to directly connect to a replicaset member server.

Author: christkv

HISTORY.md

@@ -2,6 +2,7 @@
 -----------------
 * Propagate timeout event correctly to db instances.
 * Application Monitoring API (APM) implemented.
+* NOT providing replSet name in MongoClient connection URI will force single server connection. Fixes issue where it was impossible to directly connect to a replicaset member server.
 
 2.0.42 08-18-2015
 -----------------

lib/db.js

@@ -659,7 +659,6 @@ var evaluate = function(self, code, parameters, options, callback) {
  * @param {boolean} [options.nolock=false] Tell MongoDB not to block on the evaulation of the javascript.
  * @param {Db~resultCallback} [callback] The results callback
  * @return {Promise} returns Promise if no callback passed
- * @deprecated MongoDB 3.2 and higher no longer support eval.
  */
 Db.prototype.eval = function(code, parameters, options, callback) {
   var self = this;

lib/mongo_client.js

@@ -240,8 +240,6 @@ var connect = function(url, options, callback) {
         ? new Server(object.servers[i].domain_socket, _server_options)
         : new Server(object.servers[i].host, object.servers[i].port, _server_options);
 
-    var setName;
-
     var connectFunction = function(__server) {
       // Attempt connect
       new Db(object.dbName, __server, {w:1, native_parser:false}).open(function(err, db) {
@@ -257,7 +255,6 @@ var connect = function(url, options, callback) {
           // Check what type of server we have
           if(isMasterDoc.setName) {
             totalNumberOfMongodServers++;
-            setName = isMasterDoc.setName;
           }
 
           if(isMasterDoc.msg && isMasterDoc.msg == "isdbgrid") totalNumberOfMongosServers++;
@@ -288,13 +285,16 @@ var connect = function(url, options, callback) {
             && totalNumberOfMongosServers == 0
             && object.servers.length == 1
             && (!object.rs_options.replicaSet || !object.rs_options.rs_name)) {
+            
             var obj = object.servers[0];
             serverConfig = obj.domain_socket ?
                 new Server(obj.domain_socket, object.server_options)
               : new Server(obj.host, obj.port, object.server_options);
+          
           } else if(totalNumberOfMongodServers > 0
             || totalNumberOfMongosServers > 0
             || object.rs_options.replicaSet || object.rs_options.rs_name) {
+            
             var finalServers = object.servers
               .filter(function(serverObj) {
                 return errorServers[serverObj.host + ":" + serverObj.port] == null;
@@ -309,10 +309,19 @@ var connect = function(url, options, callback) {
             // Set up the final configuration
             if(totalNumberOfMongodServers > 0) {
               try {
-                if (totalNumberOfMongodServers == 1) {
-                  object.rs_options.replicaSet = object.rs_options.replicaSet || setName;
+                
+                // If no replicaset name was provided, we wish to perform a
+                // direct connection
+                if(totalNumberOfMongodServers == 1 
+                  && (!object.rs_options.replicaSet || !object.rs_options.rs_name)) {
+                  serverConfig = finalServers[0];
+                } else if(totalNumberOfMongodServers == 1) {
+                  object.rs_options.replicaSet = object.rs_options.replicaSet || object.rs_options.rs_name;
+                  serverConfig = new ReplSet(finalServers, object.rs_options);
+                } else {
+                  serverConfig = new ReplSet(finalServers, object.rs_options);                  
                 }
-                serverConfig = new ReplSet(finalServers, object.rs_options);
+
               } catch(err) {
                 return callback(err, null);
               }

lib/server.js

@@ -278,6 +278,7 @@ Server.prototype.connect = function(db, _options, callback) {
     try {
       callback(null, self);
     } catch(err) {
+      console.log(err.stack)
       process.nextTick(function() { throw err; })
     }
   }

test/functional/logger_tests.js

@@ -76,3 +76,47 @@ exports['Should not fail with undefined id'] = {
     });
   }
 }
+
+/**
+ * Should No fail with undefined id
+ * @ignore
+ */
+exports['Should correctly log cursor'] = {
+  metadata: { requires: { topology: ['single'] } },
+  
+  // The actual test we wish to run
+  test: function(configuration, test) {
+    var MongoClient = configuration.require.MongoClient
+      , Logger = configuration.require.Logger;
+
+    MongoClient.connect('mongodb://localhost:27017/test', {}, function(err, db) {
+      test.equal(null, err);
+
+      // Status
+      var logged = false;
+
+      // Set the current logger
+      Logger.setCurrentLogger(function() {
+        test.ok(msg != null);
+        test.equal('debug', context.type);
+        test.equal('Db', context.className);
+        logged = true;        
+      });
+
+      // Set the filter
+      Logger.setLevel('debug');
+      Logger.filter('class', ['Cursor']);
+
+      // perform any operation that gets logged
+      db.collection('logging').find().toArray(function(err, d) {
+        test.equal(null, err);
+        test.ok(logged);
+
+        // Clean up
+        Logger.reset();
+        db.close();
+        test.done();
+      });
+    });
+  }
+}

test/functional/replset_connection_tests.js

@@ -949,20 +949,22 @@ exports['Should Correctly remove server going into recovery mode'] = {
 /**
  * @ignore
  */
-exports['Should not give an error when using a single server seed and no setName'] = {
+exports['Should return single server direct connection when replicaSet not provided'] = {
   metadata: { requires: { topology: 'replicaset' } },
 
   // The actual test we wish to run
   test: function(configuration, test) {
     var mongo = configuration.require
-      , MongoClient = mongo.MongoClient;
+      , MongoClient = mongo.MongoClient
+      , Server = mongo.Server;
 
     var url = f("mongodb://localhost:%s/%s"
       , configuration.port
       , "integration_test_");
 
     MongoClient.connect(url, function(err, db) {
       test.equal(null, err);
+      test.ok(db.serverConfig instanceof Server);
 
       restartAndDone(configuration, test);
     });

test/functional/replset_operations_tests.js

@@ -37,7 +37,7 @@ exports['Should fail due to w:5 and wtimeout:1 with ordered batch api'] = {
     // Create url
     var url = format("mongodb://%s,%s/%s?replicaSet=%s&readPreference=%s"
       , format("%s:%s", configuration.host, configuration.port)
-      , format("%s:%s", configuration.host, configuration.host + 1)
+      , format("%s:%s", configuration.host, configuration.port + 1)
       , "integration_test_"
       , configuration.replicasetName
       , "primary");
@@ -83,6 +83,7 @@ exports['Should fail due to w:5 and wtimeout:1 with ordered batch api'] = {
     }
 
     MongoClient.connect(url, function(err, db) {
+      console.dir(err)
       test.equal(null, err);
 
       executeTests(db, function() {
@@ -357,7 +358,7 @@ exports['Should Correctly group using replicaset'] = {
     // Create url
     var url = format("mongodb://%s,%s/%s?replicaSet=%s&readPreference=%s"
       , format("%s:%s", configuration.host, configuration.port)
-      , format("%s:%s", configuration.host, configuration.host + 1)
+      , format("%s:%s", configuration.host, configuration.port + 1)
       , "integration_test_"
       , configuration.replicasetName
       , "primary");
@@ -402,7 +403,7 @@ exports['Should fail to do map reduce to out collection'] = {
     // Create url
     var url = format("mongodb://%s,%s/%s?replicaSet=%s&readPreference=%s"
       , format("%s:%s", configuration.host, configuration.port)
-      , format("%s:%s", configuration.host, configuration.host + 1)
+      , format("%s:%s", configuration.host, configuration.port + 1)
       , "integration_test_"
       , configuration.replicasetName
       , "primary");