Skip to content

Commit de14804

Browse files
mbroadstdaprahamian
authored andcommitted
chore: remove dead operation code
NODE-1962
1 parent 2eab8aa commit de14804

File tree

6 files changed

+67
-1045
lines changed

6 files changed

+67
-1045
lines changed

lib/collection.js

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,11 @@ const CommandCursor = require('./command_cursor');
2727
// Operations
2828
const checkForAtomicOperators = require('./operations/collection_ops').checkForAtomicOperators;
2929
const ensureIndex = require('./operations/collection_ops').ensureIndex;
30-
const findAndModify = require('./operations/collection_ops').findAndModify;
31-
const findAndRemove = require('./operations/collection_ops').findAndRemove;
3230
const group = require('./operations/collection_ops').group;
3331
const parallelCollectionScan = require('./operations/collection_ops').parallelCollectionScan;
34-
const removeDocuments = require('./operations/collection_ops').removeDocuments;
32+
const removeDocuments = require('./operations/common_functions').removeDocuments;
3533
const save = require('./operations/collection_ops').save;
36-
const updateDocuments = require('./operations/collection_ops').updateDocuments;
34+
const updateDocuments = require('./operations/common_functions').updateDocuments;
3735

3836
const AggregateOperation = require('./operations/aggregate');
3937
const BulkWriteOperation = require('./operations/bulk_write');
@@ -48,6 +46,7 @@ const DropIndexOperation = require('./operations/drop_index');
4846
const DropIndexesOperation = require('./operations/drop_indexes');
4947
const EstimatedDocumentCountOperation = require('./operations/estimated_document_count');
5048
const FindOneOperation = require('./operations/find_one');
49+
const FindAndModifyOperation = require('./operations/find_and_modify');
5150
const FindOneAndDeleteOperation = require('./operations/find_one_and_delete');
5251
const FindOneAndReplaceOperation = require('./operations/find_one_and_replace');
5352
const FindOneAndUpdateOperation = require('./operations/find_one_and_update');
@@ -1665,14 +1664,11 @@ function _findAndModify(query, sort, doc, options, callback) {
16651664
// Force read preference primary
16661665
options.readPreference = ReadPreference.PRIMARY;
16671666

1668-
return executeLegacyOperation(this.s.topology, findAndModify, [
1669-
this,
1670-
query,
1671-
sort,
1672-
doc,
1673-
options,
1667+
return executeOperation(
1668+
this.s.topology,
1669+
new FindAndModifyOperation(this, query, sort, doc, options),
16741670
callback
1675-
]);
1671+
);
16761672
}
16771673

16781674
/**
@@ -1695,13 +1691,14 @@ Collection.prototype.findAndRemove = deprecate(function(query, sort, options, ca
16951691
sort = args.length ? args.shift() || [] : [];
16961692
options = args.length ? args.shift() || {} : {};
16971693

1698-
return executeLegacyOperation(this.s.topology, findAndRemove, [
1699-
this,
1700-
query,
1701-
sort,
1702-
options,
1694+
// Add the remove option
1695+
options.remove = true;
1696+
1697+
return executeOperation(
1698+
this.s.topology,
1699+
new FindAndModifyOperation(this, query, sort, null, options),
17031700
callback
1704-
]);
1701+
);
17051702
}, 'collection.findAndRemove is deprecated. Use findOneAndDelete instead.');
17061703

17071704
/**

0 commit comments

Comments
 (0)