clean up logs per suggestions

Author: baileympearson

test/integration/node-specific/resource_clean_up.test.ts

@@ -32,7 +32,7 @@ describe('Driver Resources', () => {
     }
   });
 
-  context('on MongoClient.close()', () => {
+  context.only('on MongoClient.close()', () => {
     before('create leak reproduction script', async function () {
       if (globalThis.AbortController == null || typeof this.configuration.serverApi === 'string') {
         return;

test/integration/node-specific/resource_tracking_script_builder.ts

@@ -51,7 +51,6 @@ export async function testScriptFactory(
   uri: string,
   resourceScriptPath: string,
   func: ResourceTestFunction,
-  logFn: string,
   iterations?: number
 ) {
   let resourceScript = await readFile(resourceScriptPath, { encoding: 'utf8' });
@@ -61,7 +60,6 @@ export async function testScriptFactory(
   resourceScript = resourceScript.replace('SCRIPT_NAME_STRING', JSON.stringify(name));
   resourceScript = resourceScript.replace('URI_STRING', JSON.stringify(uri));
   resourceScript = resourceScript.replace('ITERATIONS_STRING', `${iterations}`);
-  resourceScript = resourceScript.replace('LOG_FN', `${logFn.toString()}`);
 
   return resourceScript;
 }
@@ -95,8 +93,17 @@ export async function runScriptAndReturnHeapInfo(
   func: HeapResourceTestFunction,
   { iterations = 100 } = {}
 ) {
-  const log = (...args) => process.stdout.write(`${args}\n`);
-
+  const log = (...args) => {
+    const payload =
+      args
+        .map(item =>
+          typeof item === 'string'
+            ? item
+            : inspect(item, { depth: Infinity, breakLength: Infinity })
+        )
+        .join(', ') + '\n';
+    process.stdout.write(payload);
+  };
   log('starting');
   const scriptName = `${name}.cjs`;
   const heapsnapshotFile = `${name}.heapsnapshot.json`;
@@ -106,7 +113,6 @@ export async function runScriptAndReturnHeapInfo(
     config.url(),
     HEAP_RESOURCE_SCRIPT_PATH,
     func,
-    `(...args) => process.stdout.write('(subprocess): ' + args)`,
     iterations
   );
   await writeFile(scriptName, scriptContent, { encoding: 'utf8' });
@@ -133,11 +139,11 @@ export async function runScriptAndReturnHeapInfo(
 
   log('fetching messages 1...');
   const starting = await messages.next();
-  log('fetching messages 2: ', inspect(starting, { depth: Infinity }));
+  log('fetching messages 2: ', starting);
 
   const ending = await messages.next();
 
-  log('fetching messages 3: ', inspect(ending, { depth: Infinity }));
+  log('fetching messages 3: ', ending);
 
   const startingMemoryUsed = starting.value[0].startingMemoryUsed;
   const endingMemoryUsed = ending.value[0].endingMemoryUsed;

test/tools/fixtures/heap_resource_script.in.js

@@ -7,7 +7,7 @@ const func = FUNCTION_STRING;
 const name = SCRIPT_NAME_STRING;
 const uri = URI_STRING;
 const iterations = ITERATIONS_STRING;
-const log = LOG_FN;
+const { inspect } = require('util');
 
 const { MongoClient } = require(driverPath);
 const process = require('node:process');
@@ -22,20 +22,30 @@ const run = func;
 
 const MB = (2 ** 10) ** 2;
 
+const log = (...args) => {
+  const payload =
+    args
+      .map(item =>
+        typeof item === 'string' ? item : inspect(item, { depth: Infinity, breakLength: Infinity })
+      )
+      .join(', ') + '\n';
+  process.stdout.write('(subprocess): ' + payload);
+};
+
 async function main() {
-  log('starting execution' + '\n');
+  log('starting execution');
   const startingMemoryUsed = process.memoryUsage().heapUsed / MB;
   process.send({ startingMemoryUsed });
 
-  log('sent first message' + '\n');
+  log('sent first message');
 
   for (let iteration = 0; iteration < iterations; iteration++) {
     await run({ MongoClient, uri, iteration });
-    iteration % 20 === 0 && log(`iteration ${iteration} complete\n`);
+    iteration % 20 === 0 && log(`iteration ${iteration} complete`);
     global.gc();
   }
 
-  log('script executed' + '\n');
+  log('script executed');
 
   global.gc();
   // Sleep b/c maybe gc will run
@@ -44,16 +54,16 @@ async function main() {
 
   const endingMemoryUsed = process.memoryUsage().heapUsed / MB;
 
-  log('sending second message' + '\n');
+  log('sending second message');
 
   process.send({ endingMemoryUsed });
-  log('second message sent.' + '\n');
+  log('second message sent.');
 
   const start = now();
   v8.writeHeapSnapshot(`${name}.heapsnapshot.json`);
   const end = now();
 
-  log(`heap snapshot written in ${end - start}ms. script exiting` + '\n');
+  log(`heap snapshot written in ${end - start}ms. script exiting`);
 }
 
 main()