refactor: errors before handshake should mark server unknown

Author: mbroadst

lib/core/sdam/server.js

@@ -279,7 +279,11 @@ class Server extends EventEmitter {
     }
 
     this.s.pool.withConnection((err, conn, cb) => {
-      if (err) return cb(err);
+      if (err) {
+        markServerUnknown(this, err);
+        return cb(err);
+      }
+
       conn.command(ns, cmd, options, makeOperationHandler(this, options, cb));
     }, callback);
   }
@@ -299,7 +303,11 @@ class Server extends EventEmitter {
     }
 
     this.s.pool.withConnection((err, conn, cb) => {
-      if (err) return cb(err);
+      if (err) {
+        markServerUnknown(this, err);
+        return cb(err);
+      }
+
       conn.query(ns, cmd, cursorState, options, makeOperationHandler(this, options, cb));
     }, callback);
   }
@@ -319,7 +327,11 @@ class Server extends EventEmitter {
     }
 
     this.s.pool.withConnection((err, conn, cb) => {
-      if (err) return cb(err);
+      if (err) {
+        markServerUnknown(this, err);
+        return cb(err);
+      }
+
       conn.getMore(ns, cursorState, batchSize, options, makeOperationHandler(this, options, cb));
     }, callback);
   }
@@ -341,7 +353,11 @@ class Server extends EventEmitter {
     }
 
     this.s.pool.withConnection((err, conn, cb) => {
-      if (err) return cb(err);
+      if (err) {
+        markServerUnknown(this, err);
+        return cb(err);
+      }
+
       conn.killCursors(ns, cursorState, makeOperationHandler(this, null, cb));
     }, callback);
   }
@@ -436,11 +452,22 @@ function executeWriteOperation(args, options, callback) {
   }
 
   server.s.pool.withConnection((err, conn, cb) => {
-    if (err) return cb(err);
+    if (err) {
+      markServerUnknown(server, err);
+      return cb(err);
+    }
+
     conn[op](ns, ops, options, makeOperationHandler(server, options, cb));
   }, callback);
 }
 
+function markServerUnknown(server, error) {
+  server.emit(
+    'descriptionReceived',
+    new ServerDescription(server.description.address, null, { error })
+  );
+}
+
 function makeOperationHandler(server, options, callback) {
   return function handleOperationResult(err, result) {
     if (err) {