Skip to content

Conversation

kreeksec
Copy link

@kreeksec kreeksec commented Oct 22, 2024

Description

cookie is a basic HTTP cookie parser and serializer for HTTP servers. The cookie name could be used to set other fields of the cookie, resulting in an unexpected cookie value. A similar escape can be used for path and domain, which could be abused to alter other fields of the cookie. Upgrade to 0.7.0, which updates the validation for name, path, and domain. The cookie name could be used to set other fields of the cookie, resulting in an unexpected cookie value. For example, serialize("userName=<script>alert('XSS3')</script>; Max-Age=2592000; a", value) would result in "userName=<script>alert('XSS3')</script>; Max-Age=2592000; a=test", setting userName cookie to <script> and ignoring value.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@alexbevi
Copy link
Contributor

alexbevi commented Oct 22, 2024

This appears to be related to GHSA-pxg6-pf52-xh8x / jshttp/cookie#167

@nbbeeken
Copy link
Contributor

These are dev-only dependencies and do not impact the driver or development workflow. NODE-6426 will probably be done soon and clear up any local development warnings here.

@nbbeeken nbbeeken closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants