-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ci(NODE-6755): add tags to benchmarks #4419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minus the dead code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, CI failures look unrelated, though we should figure out what's happening
|
The waterfall isn't going to be pretty, but nothing here has caused the red and purple. |
Description
What is changing?
tagstoBenchmarkModuletype to facilitate adding tags to benchmarks that get reported when usingperf.sendTAGenum to driver.mts that contains the tags we use across all of our benchmarks for ease of use and to prevent accidental misspellings of tagsnormalized_throughputmeasurement to all benchmarksping_throughput_in_megabytes_per_second/cpuBaseline_throughput_in_megabytes_per_secondthroughput_in_megabytes_per_second/ping_throughput_in_megabytes_per_secondIs there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript