Skip to content

chore(NODE-6939): update typescript to 5.8.3 #4526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 4, 2025
Merged

chore(NODE-6939): update typescript to 5.8.3 #4526

merged 9 commits into from
Jun 4, 2025

Conversation

@durran
Copy link
Member

@durran durran commented Apr 30, 2025 •
edited
Loading

Description

Updates typescript to 5.8.3

What is changing?

  • Update typescript.
  • Updates dependencies that were out of date with the TS update.
  • Enable erasableSyntaxOnly option. Large doc inserts are consistently slower by ~10%
  • Fixes all errors due to the new TS option.
  • Fixes all issues arising from the eslint related updates.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6939

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

durran
durran commented Apr 30, 2025
View reviewed changes
@durran durran marked this pull request as ready for review April 30, 2025 15:06
@durran durran requested a review from a team as a code owner April 30, 2025 15:06
@baileympearson baileympearson self-assigned this Apr 30, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 30, 2025
baileympearson
baileympearson requested changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes

@durran durran requested a review from baileympearson May 4, 2025 21:04
@durran durran force-pushed the NODE-6939 branch 3 times, most recently from beb0929 to 10bea61 Compare May 9, 2025 20:49
nbbeeken
nbbeeken suggested changes May 14, 2025
View reviewed changes
@baileympearson
Copy link
Contributor

Perf analyzer comparison: https://performance-analyzer.server-tig.prod.corp.mongodb.com/perf-analyzer-viz/?comparison_id=683f24ec51694836575b4933&selected_tab=data-table&percent_filter=0%7C%7C100&z_filter=0%7C%7C10&filter_type=Default

I don't see anything alarming either.

baileympearson
baileympearson approved these changes Jun 3, 2025
View reviewed changes
@baileympearson baileympearson requested a review from dariakp June 4, 2025 15:07
@baileympearson baileympearson merged commit 57ef31b into main Jun 4, 2025
26 of 29 checks passed
@baileympearson baileympearson deleted the NODE-6939 branch June 4, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baileympearson baileympearson baileympearson approved these changes

@dariakp dariakp Awaiting requested review from dariakp

+1 more reviewer

@nbbeeken nbbeeken nbbeeken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baileympearson baileympearson

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@durran @baileympearson @nbbeeken @dariakp