-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor(NODE-7086): refactor misc operations #4613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3864c4
to
c16f98c
Compare
be8fe94
to
90223cd
Compare
a530a00
to
3bb0216
Compare
a6b4a70
to
8da7c75
Compare
d06bcc5
to
5c28cd0
Compare
5c28cd0
to
9e006f3
Compare
Note - I cannot approve and merge this as I opened it. @baileympearson LGTM but you'll have to do that. |
9e006f3
to
9bc2a30
Compare
9bc2a30
to
8e4912a
Compare
baileympearson
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR refactors the remaining operations to use ModernizedOperation. Along the way, I cleaned up the driver's RunCommandOperation layer a bit to remove duplicated code. Specifically:
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript