Skip to content

Conversation

durran
Copy link
Member

@durran durran commented Aug 5, 2025

Description

What is changing?

This PR refactors the remaining operations to use ModernizedOperation. Along the way, I cleaned up the driver's RunCommandOperation layer a bit to remove duplicated code. Specifically:

  • RunAdminCommand is no longer necessary and has been removed
  • A subclass of RunCommandOperation has been added that handles cursor-creating operations
Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran force-pushed the NODE-7086 branch 6 times, most recently from e3864c4 to c16f98c Compare August 11, 2025 13:38
@durran durran force-pushed the NODE-7086 branch 2 times, most recently from be8fe94 to 90223cd Compare August 14, 2025 21:19
@baileympearson baileympearson force-pushed the NODE-7086 branch 2 times, most recently from a530a00 to 3bb0216 Compare August 20, 2025 14:52
@durran durran self-assigned this Aug 20, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 20, 2025
@baileympearson baileympearson marked this pull request as ready for review August 21, 2025 14:37
@baileympearson baileympearson requested a review from a team as a code owner August 21, 2025 14:37
@durran
Copy link
Member Author

durran commented Aug 22, 2025

Note - I cannot approve and merge this as I opened it. @baileympearson LGTM but you'll have to do that.

@baileympearson baileympearson merged commit 0aac1fb into main Aug 25, 2025
29 of 31 checks passed
@baileympearson baileympearson deleted the NODE-7086 branch August 25, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants