Skip to content

Conversation

tadjik1
Copy link
Contributor

@tadjik1 tadjik1 commented Oct 2, 2025

Description

Summary of Changes

This PR migrates the integration tests for crud/crud_api. The changes include:

  • Refactor callbacks to async/await
  • Direct import from the src folder
  • Removing old test requirements (for example, for mongodb >= 3, or topology "ssl")
  • Changing some independent tests within the single it into separate describe with multiple tests in it
Notes for Reviewers

The file is huge, and there are many changes in it, but I tried to keep the same structure, I hope it's still manageable to review it. Let me know if you want me to break down PR into pieces somehow.

What is the motivation for this change?

This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review October 6, 2025 08:17
@tadjik1 tadjik1 requested a review from a team as a code owner October 6, 2025 08:17
@baileympearson baileympearson self-assigned this Oct 6, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 6, 2025
@tadjik1
Copy link
Contributor Author

tadjik1 commented Oct 8, 2025

thanks for the review @baileympearson, I addressed all the comments, you are right, couple of tests should just be removed, and the metadata requirements can be lift off for the current setup.

@tadjik1 tadjik1 requested a review from baileympearson October 9, 2025 08:45
@baileympearson baileympearson merged commit 897cbae into main Oct 9, 2025
24 of 27 checks passed
@baileympearson baileympearson deleted the NODE-7194 branch October 9, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants