wip feat(NODE-7121): prevent connection churn on backpressure errors when establishing connections #4800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-7121
branch
from
1951cf9 to
f4f55f6
Compare
baileympearson
force-pushed
the
NODE-7121
branch
from
f4f55f6 to
e14a3ef
Compare
baileympearson
commented
Nov 20, 2025
| isAuthOrEstablishmentHandshakeError | ||
| ) { | ||
| // Do NOT clear the pool if we encounter a system overloaded error. | ||
| if (isSystemOverloadError) { |
Contributor
Author
There was a problem hiding this comment.
Only this line is relevant for the actual backpressure change. The rest is a nice-to-have refactor that makes Node's SDAM error handling more closely match the spec's pseudocode (easier for me to develop and review). When the time comes, I'll probably break the refactor into a standalone commit to ease review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript