feat(NODE-5393): Migrate AWS signature v4 logic into driver #4824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompare the output with the old aws4 library
PavelSafronov
changed the title
baileympearson
added
the
Primary Review
baileympearson
requested changes
Dec 16, 2025
addaleax
reviewed
Dec 17, 2025
- removed extraneous new types - removed unnecessary AWS4 interface - getHmacArray renamed - removed unnecessary env-reading code - added a bunch of comments about the sigv4 algorithm - removed tests that did not pass in any credentials, we never do this
tadjik1
reviewed
Dec 19, 2025
nbbeeken
reviewed
Dec 19, 2025
nbbeeken
approved these changes
Dec 19, 2025
Contributor
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
all good on my end 🙂 thanks for taking on the improvements!
baileympearson
requested changes
Jan 5, 2026
Contributor
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
Just some minor comments. Nice work!
baileympearson
requested changes
Jan 6, 2026
rename Options to AwsSigv4Options Co-authored-by: Bailey Pearson <[email protected]>
addaleax
previously approved these changes
Jan 8, 2026
baileympearson
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Replace optional dependency on aws4 package with a minimal equivalent implementation.
What is the motivation for this change?
This helps us reduce our runtime dependencies, as part of https://jira.mongodb.org/browse/NODE-6601
Release Highlight
aws4package no longer required for AWS authenticationThe aws4 package is no longer required to use AWS authentication.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript