Skip to content

Commit 026a990

Browse files
author
Sophia Marie Terry
committed
Trying to fix possible word splitting
1 parent 5ef60b0 commit 026a990

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/scripts/ipa_version_check.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ current_version=$(jq -r '.version' tools/spectral/ipa/package.json)
55

66
previous_version=$(git show origin/"${BASE_BRANCH}":tools/spectral/ipa/package.json | jq -r '.version')
77

8-
if [[ -z "$previous_version" || "$previous_version" == "null" ]]; then
8+
if [[ -z "${previous_version}" || "${previous_version}" == "null" ]]; then
99
previous_version="none"
1010
fi
1111

12-
if [[ "$previous_version" == "$current_version" ]]; then
12+
if [[ "${previous_version}" == "${current_version}" ]]; then
1313
echo "false"
1414
else
1515
echo "true"

.github/workflows/ipa-changelog.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ jobs:
2626
run: |
2727
chmod +x ./.github/scripts/ipa_version_check.sh
2828
version_changed=$(./.github/scripts/ipa_version_check.sh)
29-
echo "Version changed? $version_changed"
30-
echo "version_changed=$version_changed" >> $GITHUB_OUTPUT
29+
echo "Version changed? ${version_changed}"
30+
echo "version_changed=${version_changed}" >> $GITHUB_OUTPUT
3131
- name: Check Changelog
3232
working-directory: tools/spectral/ipa
3333
env:
@@ -38,12 +38,12 @@ jobs:
3838
# Check for uncommitted changes specific to CHANGELOG.md
3939
uncommitted_changes=$(git status --porcelain | grep "CHANGELOG.md" || echo "")
4040
41-
if [[ "$VERSION_BUMP" == "false" && -n "$uncommitted_changes" ]]; then
41+
if [[ "${VERSION_BUMP}" == "false" && -n "${uncommitted_changes}" ]]; then
4242
echo "Error: Changelog should only be updated alongside a version bump. Please restore the changelog."
4343
exit 1
4444
fi
4545

46-
if [[ "$VERSION_BUMP" == "true" && -z "$uncommitted_changes" ]]; then
46+
if [[ "${VERSION_BUMP}" == "true" && -z "${uncommitted_changes}" ]]; then
4747
echo "Error: Changelog must be updated alongside a version bump. Please run 'npm run gen-ipa-changelog' from the ipa directory and commit the changes."
4848
exit 1
4949
fi

0 commit comments

Comments
 (0)