Skip to content

Commit 09cc5a6

Browse files
author
Sophia Marie Terry
committed
New logic for non-custom method overrides
1 parent b4f18a5 commit 09cc5a6

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

tools/spectral/ipa/rulesets/functions/IPA106ValidOperationID.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
handleInternalError,
77
} from './utils/collectionUtils.js';
88
import { isCustomMethodIdentifier } from './utils/resourceEvaluation.js';
9-
import { hasCustomMethodOverride } from './utils/extensions.js';
9+
import { hasCustomMethodOverride, hasMethodVerbOverride, VERB_OVERRIDE_EXTENSION } from './utils/extensions.js';
1010
import { validateOperationIdAndReturnErrors } from './utils/validations/validateOperationIdAndReturnErrors.js';
1111

1212
const RULE_NAME = 'xgen-IPA-106-valid-operation-id';
@@ -23,6 +23,10 @@ export default (input, { methodName }, { path }) => {
2323
return;
2424
}
2525

26+
if (hasMethodVerbOverride(input, methodName)) {
27+
methodName = input[VERB_OVERRIDE_EXTENSION].verb;
28+
}
29+
2630
try {
2731
const errors = validateOperationIdAndReturnErrors(methodName, resourcePath, input, path);
2832

tools/spectral/ipa/rulesets/functions/IPA107ValidOperationID.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
handleInternalError,
77
} from './utils/collectionUtils.js';
88
import { isCustomMethodIdentifier } from './utils/resourceEvaluation.js';
9-
import { hasCustomMethodOverride } from './utils/extensions.js';
9+
import { hasCustomMethodOverride, hasMethodVerbOverride, VERB_OVERRIDE_EXTENSION } from './utils/extensions.js';
1010
import { validateOperationIdAndReturnErrors } from './utils/validations/validateOperationIdAndReturnErrors.js';
1111

1212
const RULE_NAME = 'xgen-IPA-107-valid-operation-id';
@@ -23,6 +23,10 @@ export default (input, { methodName }, { path }) => {
2323
return;
2424
}
2525

26+
if (hasMethodVerbOverride(input, methodName)) {
27+
methodName = input[VERB_OVERRIDE_EXTENSION].verb;
28+
}
29+
2630
try {
2731
const errors = validateOperationIdAndReturnErrors(methodName, resourcePath, input, path);
2832

tools/spectral/ipa/rulesets/functions/IPA108ValidOperationID.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
handleInternalError,
77
} from './utils/collectionUtils.js';
88
import { isCustomMethodIdentifier } from './utils/resourceEvaluation.js';
9-
import { hasCustomMethodOverride } from './utils/extensions.js';
9+
import { hasCustomMethodOverride, hasMethodVerbOverride, VERB_OVERRIDE_EXTENSION } from './utils/extensions.js';
1010
import { validateOperationIdAndReturnErrors } from './utils/validations/validateOperationIdAndReturnErrors.js';
1111

1212
const RULE_NAME = 'xgen-IPA-108-valid-operation-id';
@@ -23,6 +23,10 @@ export default (input, { methodName }, { path }) => {
2323
return;
2424
}
2525

26+
if (hasMethodVerbOverride(input, methodName)) {
27+
methodName = input[VERB_OVERRIDE_EXTENSION].verb;
28+
}
29+
2630
try {
2731
const errors = validateOperationIdAndReturnErrors(methodName, resourcePath, input, path);
2832

0 commit comments

Comments
 (0)