Skip to content

Commit 0ac3fde

Browse files
author
Sophia Marie Terry
committed
Reintroduce base branch param with different usage
1 parent 439da11 commit 0ac3fde

File tree

4 files changed

+17
-11
lines changed

4 files changed

+17
-11
lines changed
Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
1-
#!/bin/bash
2-
set -eou pipefail
3-
4-
current_version=$(jq -r '.version' tools/spectral/ipa/package.json)
1+
#!/bin/bash
2+
set -eou pipefail
53

6-
previous_version=$(git show HEAD~1:tools/spectral/ipa/package.json | jq -r '.version' || echo "none")
4+
current_version=$(jq -r '.version' tools/spectral/ipa/package.json)
5+
6+
previous_version=$(git show origin/"${BASE_BRANCH}":tools/spectral/ipa/package.json | jq -r '.version')
77

8-
if [[ "${previous_version}" == "${current_version}" ]]; then
9-
echo "false"
10-
else
11-
echo "true"
8+
if [[ -z "${previous_version}" || "${previous_version}" == "null" ]]; then
9+
previous_version="none"
10+
fi
11+
12+
if [[ "${previous_version}" == "${current_version}" ]]; then
13+
echo "false"
14+
else
15+
echo "true"
1216
fi

.github/workflows/ipa-changelog.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ jobs:
2121
2222
- name: Fetch Versions
2323
id: version_check
24+
env:
25+
BASE_BRANCH: ${{ github.event.pull_request.base.ref }}
2426
run: |
2527
version_changed=$(./.github/scripts/ipa_version_check.sh)
2628
echo "Version changed? ${version_changed}"

.github/workflows/ipa-release.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ jobs:
2424
.github/scripts
2525
- name: Fetch Versions
2626
id: version_check
27+
env:
28+
BASE_BRANCH: "HEAD~1"
2729
run: |
2830
version_changed=$(./.github/scripts/ipa_version_check.sh)
2931
echo "Version changed? ${version_changed}"

tools/spectral/ipa/CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,3 @@
22

33
All notable changes to this project will be documented in this file. Dates are displayed in UTC.
44

5-
6-
TEst

0 commit comments

Comments
 (0)