CLOUDP-283505: Allow empty removals

blva · blva · commit 0be00b24a457 · 2024-11-12T11:57:07.000Z
diff --git a/tools/cli/internal/changelog/outputfilter/squash.go b/tools/cli/internal/changelog/outputfilter/squash.go
@@ -11,7 +11,8 @@ import (
 var (
 	// identifierRegex matches text enclosed in single quotes.
 	// Example: it'll match "value" from the string "added the new required request property 'value'".
-	identifierRegex = regexp.MustCompile(`'([^']+)'`)
+	// Example: it'll match "" and "/items/dataProcessRegion/region" from the string removed the '' enum value from the '/items/dataProcessRegion/region' response property.
+	identifierRegex = regexp.MustCompile(`'([^']*)'`)
 )
 
 type SquashHandler interface {

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,8 @@ import (`
`11`	`11`	`var (`
`12`	`12`	`// identifierRegex matches text enclosed in single quotes.`
`13`	`13`	`// Example: it'll match "value" from the string "added the new required request property 'value'".`
`14`		- identifierRegex = regexp.MustCompile(`'([^']+)'`)
	`14`	`+ // Example: it'll match "" and "/items/dataProcessRegion/region" from the string removed the '' enum value from the '/items/dataProcessRegion/region' response property.`
	`15`	+ identifierRegex = regexp.MustCompile(`'([^']*)'`)
`15`	`16`	`)`
`16`	`17`
`17`	`18`	`type SquashHandler interface {`