Add more tests

Author: blva

tools/cli/internal/cli/versions/versions.go

@@ -112,7 +112,7 @@ func (o *Opts) versionsAsBytes(versions []string) ([]byte, error) {
 }
 
 func (o *Opts) PreRunE(_ []string) error {
-	o.stabilityLevel = strings.ToUpper(o.stabilityLevel)
+	o.stabilityLevel = strings.ToLower(o.stabilityLevel)
 	if o.stabilityLevel != "" && o.stabilityLevel != apiversion.PreviewStabilityLevel && o.stabilityLevel != apiversion.StableStabilityLevel {
 		return fmt.Errorf("stability level must be %q or %q, got %q", apiversion.PreviewStabilityLevel, apiversion.StableStabilityLevel, o.stabilityLevel)
 	}

tools/cli/internal/cli/versions/versions_test.go

@@ -75,7 +75,7 @@ func TestVersion_RunWithPreview(t *testing.T) {
 	assert.Contains(t, string(b), "preview")
 }
 
-func TestVersion_RunStabilityLevelPreview(t *testing.T) {
+func TestVersion_RunStabilityLevelPreviewAndPrivatePreview(t *testing.T) {
 	fs := afero.NewMemMapFs()
 	opts := &Opts{
 		basePath:       "../../../test/data/base_spec_with_private_preview.json",
@@ -95,14 +95,14 @@ func TestVersion_RunStabilityLevelPreview(t *testing.T) {
 	assert.Contains(t, string(b), "private-preview")
 }
 
-func TestVersion_RunStabilityLevelStable(t *testing.T) {
+func TestVersion_PreviewAndPublicPreview(t *testing.T) {
 	fs := afero.NewMemMapFs()
 	opts := &Opts{
-		basePath:       "../../../test/data/base_spec_with_private_preview.json",
+		basePath:       "../../../test/data/base_spec_with_public_preview.json",
 		outputPath:     "foas.json",
 		fs:             fs,
 		env:            "staging",
-		stabilityLevel: "STABLE",
+		stabilityLevel: "PREVIEW",
 	}
 
 	require.NoError(t, opts.Run())
@@ -111,18 +111,18 @@ func TestVersion_RunStabilityLevelStable(t *testing.T) {
 
 	// Check initial versions
 	assert.NotEmpty(t, b)
-	assert.Contains(t, string(b), "2023-02-01")
-	assert.NotContains(t, string(b), "private-review")
+	assert.NotContains(t, string(b), "private-preview")
+	assert.Contains(t, string(b), "preview")
 }
 
-func TestVersion_PreviewAndPublicPreview(t *testing.T) {
+func TestVersion_RunStabilityLevelStable(t *testing.T) {
 	fs := afero.NewMemMapFs()
 	opts := &Opts{
-		basePath:       "../../../test/data/base_spec_with_public_preview.json",
+		basePath:       "../../../test/data/base_spec_with_private_preview.json",
 		outputPath:     "foas.json",
 		fs:             fs,
 		env:            "staging",
-		stabilityLevel: "PREVIEW",
+		stabilityLevel: "STABLE",
 	}
 
 	require.NoError(t, opts.Run())
@@ -133,5 +133,87 @@ func TestVersion_PreviewAndPublicPreview(t *testing.T) {
 	assert.NotEmpty(t, b)
 	assert.Contains(t, string(b), "2023-02-01")
 	assert.NotContains(t, string(b), "private-preview")
-	assert.Contains(t, string(b), "preview")
+}
+
+func TestVersion_PreRun(t *testing.T) {
+	t.Run("NoBasePath", func(t *testing.T) {
+		opts := &Opts{}
+		err := opts.PreRunE(nil)
+		require.Error(t, err)
+		assert.Contains(t, err.Error(), "no OAS detected")
+	})
+
+	t.Run("InvalidOutputPath", func(t *testing.T) {
+		opts := &Opts{
+			basePath:   "base",
+			outputPath: "output",
+		}
+		err := opts.PreRunE(nil)
+		require.Error(t, err)
+		assert.Contains(t, err.Error(), "output file must be either a JSON or YAML file")
+	})
+
+	t.Run("InvalidFormat", func(t *testing.T) {
+		opts := &Opts{
+			basePath:   "base",
+			outputPath: "output.json",
+			format:     "invalid",
+		}
+		err := opts.PreRunE(nil)
+		require.Error(t, err)
+		assert.Contains(t, err.Error(), "output format must be either 'json' or 'yaml'")
+	})
+
+	t.Run("ValidFormat", func(t *testing.T) {
+		opts := &Opts{
+			basePath:   "base",
+			outputPath: "output.json",
+			format:     "json",
+		}
+		err := opts.PreRunE(nil)
+		require.NoError(t, err)
+	})
+
+	t.Run("ValidFormatYAML", func(t *testing.T) {
+		opts := &Opts{
+			basePath:   "base",
+			outputPath: "output.yaml",
+			format:     "yaml",
+		}
+		err := opts.PreRunE(nil)
+		require.NoError(t, err)
+	})
+
+	t.Run("InvalidStabilityLevel", func(t *testing.T) {
+		opts := &Opts{
+			basePath:       "base",
+			outputPath:     "output.yaml",
+			format:         "yaml",
+			stabilityLevel: "invalid",
+		}
+		err := opts.PreRunE(nil)
+		require.Error(t, err)
+		assert.Contains(t, err.Error(), "stability level must be")
+	})
+	t.Run("ValidStabilityLevelPreview", func(t *testing.T) {
+		opts := &Opts{
+			basePath:       "base",
+			outputPath:     "output.yaml",
+			format:         "yaml",
+			stabilityLevel: "preview",
+		}
+		err := opts.PreRunE(nil)
+		require.NoError(t, err)
+	})
+
+	t.Run("ValidStabilityLevelPreviewUppercase", func(t *testing.T) {
+		opts := &Opts{
+			basePath:       "base",
+			outputPath:     "output.yaml",
+			format:         "yaml",
+			stabilityLevel: "PREVIEW",
+		}
+		err := opts.PreRunE(nil)
+		require.NoError(t, err)
+	})
 }